chore: fix related uint testing files ,

fix implementation logic.

Author: AndrewAminInstabug

example/lib/src/screens/screen_render_page.dart

@@ -1,17 +1,32 @@
 part of '../../main.dart';
 
-class ScreenRenderPage extends StatelessWidget {
+class ScreenRenderPage extends StatefulWidget {
   const ScreenRenderPage({Key? key}) : super(key: key);
   static const String screenName = "/screenRenderPageRoute";
 
+  @override
+  State<ScreenRenderPage> createState() => _ScreenRenderPageState();
+}
+
+class _ScreenRenderPageState extends State<ScreenRenderPage> {
+  final durationController = TextEditingController();
+
   @override
   Widget build(BuildContext context) {
     return Page(title: 'Screen Render', children: [
-
+      SizedBox.fromSize(size: const Size.fromHeight(16.0)),
       const AnimatedBox(),
-       SizedBox.fromSize(size: const Size.fromHeight(50),),
+      SizedBox.fromSize(
+        size: const Size.fromHeight(50),
+      ),
+      InstabugTextField(
+        label: 'Frame duration in milliseconds',
+        labelStyle: Theme.of(context).textTheme.labelMedium,
+        controller: durationController,
+      ),
+      SizedBox.fromSize(size: const Size.fromHeight(16.0)),
       InstabugButton(
-        text: 'Perform Frozen Frame',
+        text: 'Perform Heavy Computation',
         onPressed: () => _simulateHeavyComputation(),
       ),
       InstabugButton(
@@ -36,9 +51,13 @@ class ScreenRenderPage extends StatelessWidget {
   // Simulates a computationally expensive task
   void _simulateHeavyComputation() {
     final startTime = DateTime.now();
+    final pauseTime = double.tryParse(durationController.text.trim());
     // Block the UI thread for ~500ms
-    while (DateTime.now().difference(startTime).inMilliseconds <= 1000) {
-      // Busy waiting (not recommended in real apps)
+    if (pauseTime == null) {
+      return log("enter a valid number");
+    }
+    while (DateTime.now().difference(startTime).inMilliseconds <= pauseTime) {
+      // Busy waiting
     }
   }
 }

lib/src/modules/instabug.dart

@@ -198,7 +198,7 @@ class Instabug {
 
     if (await FlagsConfig.screenRendering.isEnabled()) {
       checkForWidgetBinding();
-      await InstabugScreenRenderManager.I.init(WidgetsBinding.instance);
+      InstabugScreenRenderManager.I.init(WidgetsBinding.instance);
     }
 
     return FeatureFlagsManager().registerW3CFlagsListener();

lib/src/utils/instabug_navigator_observer.dart

@@ -28,7 +28,8 @@ class InstabugNavigatorObserver extends NavigatorObserver {
       ScreenLoadingManager.I
           .startUiTrace(maskedScreenName, screenName)
           .then((uiTraceId) {
-        if (uiTraceId != null) {
+        if (uiTraceId != null &&
+            InstabugScreenRenderManager.I.screenRenderEnabled) {
           InstabugScreenRenderManager.I
               .startScreenRenderCollectorForTraceId(uiTraceId);
         }

lib/src/utils/screen_rendering/instabug_screen_render_manager.dart

@@ -8,6 +8,7 @@ import 'package:instabug_flutter/src/modules/apm.dart';
 import 'package:instabug_flutter/src/utils/screen_rendering/instabug_widget_binding_observer.dart';
 import 'package:meta/meta.dart';
 
+//todo: remove logs
 extension on int {
   int get inMicro => this * 1000;
 }
@@ -37,10 +38,10 @@ class InstabugScreenRenderManager {
   int _frozenFramesTotalDuration = 0;
 
   bool _isTimingsListenerAttached = false;
-
+  bool screenRenderEnabled = false;
   InstabugScreenRenderManager._();
 
-  static  InstabugScreenRenderManager _instance =
+  static InstabugScreenRenderManager _instance =
       InstabugScreenRenderManager._();
 
   /// Returns the singleton instance of [InstabugScreenRenderManager].
@@ -52,25 +53,15 @@ class InstabugScreenRenderManager {
   /// Logging tag for debugging purposes.
   static const tag = "ScreenRenderManager";
 
-  /// A named constructor used for testing purposes
-  @internal
-  @visibleForTesting
-  InstabugScreenRenderManager.init();
-
-  /// Allows setting a custom instance for testing.
-  @visibleForTesting
-  // ignore: use_setters_to_change_properties
-  static void setInstance(InstabugScreenRenderManager instance) {
-    _instance = instance;
-  }
   /// setup function for [InstabugScreenRenderManager]
   @internal
-  Future<void> init(WidgetsBinding widgetBinding) async {
+  void init(WidgetsBinding widgetBinding, [double? refreshRate]) {
     if (!_isTimingsListenerAttached) {
       _widgetsBinding = widgetBinding;
       _addWidgetBindingObserver();
-      await _initStaticValues();
+      _initStaticValues(refreshRate);
       _initFrameTimings();
+      screenRenderEnabled = true;
     }
   }
 
@@ -153,22 +144,24 @@ class InstabugScreenRenderManager {
   /// Presently, on Android and Web this collection will only contain the display that the current window is on.
   /// On iOS, it will only contains the main display on the phone or tablet.
   /// On Desktop, it will contain only a main display with a valid refresh rate but invalid size and device pixel ratio values.
-  //todo: will be removed after getting the actual value from native side.
+  //todo: will be compared with value from native side after it's implemented.
   double get _getDeviceRefreshRate =>
-      _widgetsBinding.platformDispatcher.displays.last.refreshRate;
+      _widgetsBinding.platformDispatcher.displays.first.refreshRate;
 
   /// Get device refresh rate from native side.
+  //todo: will be compared with value from native side after it's implemented.
+  // ignore: unused_element
   Future<double> get _getDeviceRefreshRateFromNative =>
       APM.getDeviceRefreshRate();
 
   /// Initialize the static variables
-  Future<void> _initStaticValues() async {
+  void _initStaticValues(double? refreshRate) {
     _timingsCallback = (timings) {
       for (final frameTiming in timings) {
         analyzeFrameTiming(frameTiming);
       }
     };
-    _deviceRefreshRate = await _getDeviceRefreshRateFromNative;
+    _deviceRefreshRate = refreshRate ?? _getDeviceRefreshRate;
     _slowFrameThresholdMs = _targetMsPerFrame(_deviceRefreshRate);
     _screenRenderForAutoUiTrace = InstabugScreenRenderData(frameData: []);
     _screenRenderForCustomUiTrace = InstabugScreenRenderData(frameData: []);
@@ -270,7 +263,7 @@ class InstabugScreenRenderManager {
     _delayedFrames.add(InstabugFrameData(startTime, duration));
   }
 
-  //todo: to be removed
+  //todo: will be removed
   void _displayFrameTimingDetails(FrameTiming frameTiming) {
     if (_isSlow) {
       debugPrint(
@@ -306,15 +299,19 @@ class InstabugScreenRenderManager {
   }
 
   @visibleForTesting
-  Future<void> reportScreenRending(InstabugScreenRenderData screenRenderData,
-      [UiTraceType type = UiTraceType.auto]) async {
+  Future<void> reportScreenRending(
+    InstabugScreenRenderData screenRenderData, [
+    UiTraceType type = UiTraceType.auto,
+  ]) async {
     if (type == UiTraceType.auto) {
       _reportScreenRenderForAutoUiTrace(screenRenderData);
     } else {
       _reportScreenRenderForCustomUiTrace(screenRenderData);
     }
-    log("Reported Data (${type == UiTraceType.auto ? 'auto' : 'custom'}): $screenRenderData",
-        name: tag);
+    log(
+      "Reported Data (${type == UiTraceType.auto ? 'auto' : 'custom'}): $screenRenderData",
+      name: tag,
+    );
   }
 
   Future<void> _reportScreenRenderForCustomUiTrace(
@@ -348,6 +345,16 @@ class InstabugScreenRenderManager {
   }
 
   /// --------------------------- testing helper functions ---------------------
+
+  @visibleForTesting
+  InstabugScreenRenderManager.init();
+
+  @visibleForTesting
+  // ignore: use_setters_to_change_properties
+  static void setInstance(InstabugScreenRenderManager instance) {
+    _instance = instance;
+  }
+
   @visibleForTesting
   InstabugScreenRenderData get screenRenderForAutoUiTrace =>
       _screenRenderForAutoUiTrace;

lib/src/utils/screen_rendering/instabug_widget_binding_observer.dart

@@ -5,11 +5,12 @@ import 'package:instabug_flutter/src/utils/screen_name_masker.dart';
 import 'package:instabug_flutter/src/utils/screen_rendering/instabug_screen_render_manager.dart';
 import 'package:meta/meta.dart';
 
+//todo: remove logs
 class InstabugWidgetsBindingObserver extends WidgetsBindingObserver {
   InstabugWidgetsBindingObserver._();
 
   static final InstabugWidgetsBindingObserver _instance =
-  InstabugWidgetsBindingObserver._();
+      InstabugWidgetsBindingObserver._();
 
   /// Returns the singleton instance of [InstabugWidgetsBindingObserver].
   static InstabugWidgetsBindingObserver get instance => _instance;
@@ -28,7 +29,8 @@ class InstabugWidgetsBindingObserver extends WidgetsBindingObserver {
       ScreenLoadingManager.I
           .startUiTrace(maskedScreenName, lastUiTrace.screenName)
           .then((uiTraceId) {
-        if (uiTraceId != null) {
+        if (uiTraceId != null &&
+            InstabugScreenRenderManager.I.screenRenderEnabled) {
           InstabugScreenRenderManager.I
               .startScreenRenderCollectorForTraceId(uiTraceId);
         }

test/apm_test.dart

@@ -165,6 +165,9 @@ void main() {
   test('[startUITrace] should call host method', () async {
     const name = 'UI-trace';
 
+    //disable the feature flag for screen render feature in order to skip its checking.
+    when(mHost.isScreenRenderEnabled()).thenAnswer((_) async => false);
+
     await APM.startUITrace(name);
 
     verify(
@@ -214,7 +217,6 @@ void main() {
     verify(
       mHost.startCpUiTrace(screenName, microTimeStamp, traceId),
     ).called(1);
-    verifyNoMoreInteractions(mHost);
   });
 
   test('[reportScreenLoading] should call host method', () async {
@@ -235,7 +237,6 @@ void main() {
         uiTraceId,
       ),
     ).called(1);
-    verifyNoMoreInteractions(mHost);
   });
 
   test('[endScreenLoading] should call host method', () async {
@@ -247,7 +248,6 @@ void main() {
     verify(
       mHost.endScreenLoadingCP(timeStampMicro, uiTraceId),
     ).called(1);
-    verifyNoMoreInteractions(mHost);
   });
 
   test('[isSEndScreenLoadingEnabled] should call host method', () async {

test/instabug_test.dart

@@ -3,6 +3,7 @@ import 'dart:typed_data';
 import 'package:flutter/widgets.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:instabug_flutter/instabug_flutter.dart';
+import 'package:instabug_flutter/src/generated/apm.api.g.dart';
 import 'package:instabug_flutter/src/generated/instabug.api.g.dart';
 import 'package:instabug_flutter/src/utils/enum_converter.dart';
 import 'package:instabug_flutter/src/utils/feature_flags_manager.dart';
@@ -17,6 +18,7 @@ import 'instabug_test.mocks.dart';
   InstabugHostApi,
   IBGBuildInfo,
   ScreenNameMasker,
+  ApmHostApi,
 ])
 void main() {
   TestWidgetsFlutterBinding.ensureInitialized();
@@ -25,12 +27,14 @@ void main() {
   final mHost = MockInstabugHostApi();
   final mBuildInfo = MockIBGBuildInfo();
   final mScreenNameMasker = MockScreenNameMasker();
+  final mApmHost = MockApmHostApi();
 
   setUpAll(() {
     Instabug.$setHostApi(mHost);
     FeatureFlagsManager().$setHostApi(mHost);
     IBGBuildInfo.setInstance(mBuildInfo);
     ScreenNameMasker.setInstance(mScreenNameMasker);
+    APM.$setHostApi(mApmHost);
   });
 
   test('[setEnabled] should call host method', () async {
@@ -78,6 +82,10 @@ void main() {
         "isW3cCaughtHeaderEnabled": true,
       }),
     );
+
+    //disable the feature flag for screen render feature in order to skip its checking.
+    when(mApmHost.isScreenRenderEnabled()).thenAnswer((_) async => false);
+
     await Instabug.init(
       token: token,
       invocationEvents: events,

test/utils/instabug_navigator_observer_test.dart

@@ -10,13 +10,10 @@ import 'package:mockito/mockito.dart';
 
 import 'instabug_navigator_observer_test.mocks.dart';
 
-@GenerateMocks([
-  InstabugHostApi,
-  ScreenLoadingManager,
-])
+@GenerateMocks([InstabugHostApi])
+@GenerateNiceMocks([MockSpec<ScreenLoadingManager>()])
 void main() {
   TestWidgetsFlutterBinding.ensureInitialized();
-  WidgetsFlutterBinding.ensureInitialized();
 
   final mHost = MockInstabugHostApi();
   final mScreenLoadingManager = MockScreenLoadingManager();
@@ -41,7 +38,7 @@ void main() {
   });
 
   test('should report screen change when a route is pushed', () {
-    fakeAsync((async) {
+    fakeAsync((async) async {
       observer.didPush(route, previousRoute);
 
       async.elapse(const Duration(milliseconds: 1000));