Skip to content

Commit 2f1aa27

Browse files
chore: rename [willRedirectToAppStore] to [willRedirectToStore],
chore: add changes to CHANGELOG.md
1 parent 3ede9b6 commit 2f1aa27

File tree

8 files changed

+18
-11
lines changed

8 files changed

+18
-11
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# Changelog
22

3+
## [Unreleased](https://github.com/Instabug/Instabug-React-Native/compare/v12.7.0...dev)
4+
5+
### Added
6+
7+
- Adds custom app rating api ([#453](https://github.com/Instabug/Instabug-Flutter/pull/453))
8+
9+
310
## [12.7.0](https://github.com/Instabug/Instabug-Flutter/compare/v12.5.0...v12.7.0) (February 15, 2024)
411

512
### Added

android/src/main/java/com/instabug/flutter/modules/InstabugApi.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ public void networkLog(@NonNull Map<String, Object> data) {
398398
}
399399

400400
@Override
401-
public void willRedirectToAppStore() {
401+
public void willRedirectToStore() {
402402
Instabug.willRedirectToStore();
403403
}
404404
}

android/src/test/java/com/instabug/flutter/InstabugApiTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -551,8 +551,8 @@ public void testNetworkLog() {
551551
}
552552

553553
@Test
554-
public void testWillRedirectToAppStore() {
555-
api.willRedirectToAppStore();
554+
public void testWillRedirectToStore() {
555+
api.willRedirectToStore();
556556
mInstabug.verify(Instabug::willRedirectToStore);
557557
}
558558
}

example/ios/InstabugTests/InstabugApiTests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -400,7 +400,7 @@ - (void)testNetworkLog {
400400

401401
- (void)testWillRedirectToAppStore {
402402
FlutterError *error;
403-
[self.api willRedirectToAppStoreWithError:&error];
403+
[self.api willRedirectToStoreWithError:&error];
404404

405405
OCMVerify([self.mInstabug willRedirectToAppStore]);
406406
}

ios/Classes/Modules/InstabugApi.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@ - (void)networkLogData:(NSDictionary<NSString *, id> *)data error:(FlutterError
305305
}
306306
}
307307

308-
- (void)willRedirectToAppStoreWithError:(FlutterError * _Nullable __autoreleasing *)error {
308+
- (void)willRedirectToStoreWithError:(FlutterError * _Nullable __autoreleasing *)error {
309309
[Instabug willRedirectToAppStore];
310310
}
311311

lib/src/modules/instabug.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ class Instabug {
414414
}
415415

416416
/// This API has to be call when using custom app rating prompt
417-
static Future<void> willRedirectToAppStore() async {
418-
return _host.willRedirectToAppStore();
417+
static Future<void> willRedirectToStore() async {
418+
return _host.willRedirectToStore();
419419
}
420420
}

pigeons/instabug.api.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,5 +55,5 @@ abstract class InstabugHostApi {
5555

5656
void networkLog(Map<String, Object> data);
5757

58-
void willRedirectToAppStore();
58+
void willRedirectToStore();
5959
}

test/instabug_test.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -384,13 +384,13 @@ void main() {
384384
).called(1);
385385
});
386386

387-
test('[willRedirectToAppStore] should call host method', () async {
387+
test('[willRedirectToStore] should call host method', () async {
388388
//arrange
389-
await Instabug.willRedirectToAppStore();
389+
await Instabug.willRedirectToStore();
390390

391391
//assert
392392
verify(
393-
mHost.willRedirectToAppStore(),
393+
mHost.willRedirectToStore(),
394394
).called(1);
395395
});
396396
}

0 commit comments

Comments
 (0)