Call return handler for void methods on iOS

Author: guykogus

CHANGELOG.md

@@ -6,6 +6,7 @@
 ## v9.1.8 (2021-02-17)
 
 * Fixes an issue with iOS invocation events causing the welcome message not to show.
+* Change all `void ... async` methods to `Future<void> ... async` so that callers can use `await`.
 
 ## v9.1.7 (2020-10-01)
 

ios/Classes/InstabugFlutterPlugin.m

@@ -39,10 +39,12 @@ - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
           const char *type = [signature methodReturnType];
 
           if (strcmp(type, "v") != 0) {
-              void *returnVal;
+            void *returnVal;
             [inv getReturnValue:&returnVal];
             NSObject *resultSet = (__bridge NSObject *)returnVal;
             result(resultSet);
+          } else {
+            result(nil);
           }
       }
     if (!isImplemented) {

lib/BugReporting.dart

@@ -1,5 +1,6 @@
 import 'dart:async';
 import 'dart:io' show Platform;
+
 import 'package:flutter/services.dart';
 import 'package:instabug_flutter/Instabug.dart';
 
@@ -74,7 +75,7 @@ class BugReporting {
 
   ///Enables and disables manual invocation and prompt options for bug and feedback.
   /// [boolean] isEnabled
-  static void setEnabled(bool isEnabled) async {
+  static Future<void> setEnabled(bool isEnabled) async {
     final List<dynamic> params = <dynamic>[isEnabled];
     await _channel.invokeMethod<Object>('setBugReportingEnabled:', params);
   }
@@ -83,7 +84,7 @@ class BugReporting {
   /// This block is executed on the UI thread. Could be used for performing any
   /// UI changes before the SDK's UI is shown.
   /// [function]  A callback that gets executed before invoking the SDK
-  static void setOnInvokeCallback(Function function) async {
+  static Future<void> setOnInvokeCallback(Function function) async {
     _channel.setMethodCallHandler(_handleMethod);
     _onInvokeCallback = function;
     await _channel.invokeMethod<Object>('setOnInvokeCallback');
@@ -93,7 +94,7 @@ class BugReporting {
   /// This block is executed on the UI thread. Could be used for performing any
   /// UI changes before the SDK's UI is shown.
   /// [function]  A callback that gets executed before invoking the SDK
-  static void setOnDismissCallback(Function function) async {
+  static Future<void> setOnDismissCallback(Function function) async {
     _channel.setMethodCallHandler(_handleMethod);
     _onDismissCallback = function;
     await _channel.invokeMethod<Object>('setOnDismissCallback');
@@ -102,7 +103,7 @@ class BugReporting {
   /// Sets the events that invoke the feedback form.
   /// Default is set by `Instabug.startWithToken`.
   /// [invocationEvents] invocationEvent List of events that invokes the
-  static void setInvocationEvents(
+  static Future<void> setInvocationEvents(
       List<InvocationEvent> invocationEvents) async {
     final List<String> invocationEventsStrings = <String>[];
     if (invocationEvents != null) {
@@ -121,8 +122,8 @@ class BugReporting {
   /// attachments. In iOS 10+,NSPhotoLibraryUsageDescription should be set in
   /// info.plist to enable gallery image attachments.
   /// [screenRecording] A boolean to enable or disable screen recording attachments.
-  static void setEnabledAttachmentTypes(bool screenshot, bool extraScreenshot,
-      bool galleryImage, bool screenRecording) async {
+  static Future<void> setEnabledAttachmentTypes(bool screenshot,
+      bool extraScreenshot, bool galleryImage, bool screenRecording) async {
     final List<dynamic> params = <dynamic>[
       screenshot,
       extraScreenshot,
@@ -136,7 +137,7 @@ class BugReporting {
 
   ///Sets what type of reports, bug or feedback, should be invoked.
   /// [reportTypes] - List of reportTypes
-  static void setReportTypes(List<ReportType> reportTypes) async {
+  static Future<void> setReportTypes(List<ReportType> reportTypes) async {
     final List<String> reportTypesStrings = <String>[];
     if (reportTypes != null) {
       reportTypes.forEach((e) {
@@ -150,7 +151,7 @@ class BugReporting {
   /// Sets whether the extended bug report mode should be disabled, enabled with
   /// required fields or enabled with optional fields.
   /// [extendedBugReportMode] ExtendedBugReportMode enum
-  static void setExtendedBugReportMode(
+  static Future<void> setExtendedBugReportMode(
       ExtendedBugReportMode extendedBugReportMode) async {
     final List<dynamic> params = <dynamic>[extendedBugReportMode.toString()];
     await _channel.invokeMethod<Object>('setExtendedBugReportMode:', params);
@@ -159,7 +160,7 @@ class BugReporting {
   /// Sets the invocation options.
   /// Default is set by `Instabug.startWithToken`.
   /// [invocationOptions] List of invocation options
-  static void setInvocationOptions(
+  static Future<void> setInvocationOptions(
       List<InvocationOption> invocationOptions) async {
     final List<String> invocationOptionsStrings = <String>[];
     if (invocationOptions != null) {
@@ -174,7 +175,7 @@ class BugReporting {
   /// Invoke bug reporting with report type and options.
   /// [reportType] type
   /// [invocationOptions]  List of invocation options
-  static void show(
+  static Future<void> show(
       ReportType reportType, List<InvocationOption> invocationOptions) async {
     final List<String> invocationOptionsStrings = <String>[];
     if (invocationOptions != null) {
@@ -193,7 +194,7 @@ class BugReporting {
   /// Sets the threshold value of the shake gesture for iPhone/iPod Touch
   /// Default for iPhone is 2.5.
   /// [iPhoneShakingThreshold] iPhoneShakingThreshold double
-  static void setShakingThresholdForiPhone(
+  static Future<void> setShakingThresholdForiPhone(
       double iPhoneShakingThreshold) async {
     if (Platform.isIOS) {
       final List<dynamic> params = <dynamic>[iPhoneShakingThreshold];
@@ -205,7 +206,8 @@ class BugReporting {
   /// Sets the threshold value of the shake gesture for iPad
   /// Default for iPhone is 0.6.
   /// [iPadShakingThreshold] iPhoneShakingThreshold double
-  static void setShakingThresholdForiPad(double iPadShakingThreshold) async {
+  static Future<void> setShakingThresholdForiPad(
+      double iPadShakingThreshold) async {
     if (Platform.isIOS) {
       final List<dynamic> params = <dynamic>[iPadShakingThreshold];
       await _channel.invokeMethod<Object>(
@@ -218,7 +220,8 @@ class BugReporting {
   /// you could increase the shaking difficulty level by
   /// increasing the `350` value and vice versa
   /// [androidThreshold] iPhoneShakingThreshold int
-  static void setShakingThresholdForAndroid(int androidThreshold) async {
+  static Future<void> setShakingThresholdForAndroid(
+      int androidThreshold) async {
     if (Platform.isAndroid) {
       final List<dynamic> params = <dynamic>[androidThreshold];
       await _channel.invokeMethod<Object>(

lib/Chats.dart

@@ -1,4 +1,5 @@
 import 'dart:async';
+
 import 'package:flutter/services.dart';
 
 class Chats {
@@ -8,19 +9,21 @@ class Chats {
     final String version = await _channel.invokeMethod('getPlatformVersion');
     return version;
   }
-  
+
   @deprecated
+
   ///Use {@link BugReporting.show} instead.
   ///Manual invocation for chats view.
-  static void show() async {
+  static Future<void> show() async {
     await _channel.invokeMethod<Object>('showChats');
   }
 
   @deprecated
+
   ///Use {@link BugReporting.setReportTypes} instead.
   /// Enables and disables everything related to creating new chats.
   /// [boolean] isEnabled
-  static void setEnabled(bool isEnabled) async {
+  static Future<void> setEnabled(bool isEnabled) async {
     final List<dynamic> params = <dynamic>[isEnabled];
     await _channel.invokeMethod<Object>('setChatsEnabled:', params);
   }

lib/CrashReporting.dart

@@ -1,8 +1,9 @@
 import 'dart:async';
 import 'dart:convert';
 import 'dart:io' show Platform, exit;
-import 'package:flutter/services.dart';
+
 import 'package:flutter/foundation.dart';
+import 'package:flutter/services.dart';
 import 'package:instabug_flutter/models/crash_data.dart';
 import 'package:instabug_flutter/models/exception_data.dart';
 import 'package:stack_trace/stack_trace.dart';
@@ -17,13 +18,13 @@ class CrashReporting {
 
   ///Enables and disables Enables and disables automatic crash reporting.
   /// [boolean] isEnabled
-  static void setEnabled(bool isEnabled) async {
+  static Future<void> setEnabled(bool isEnabled) async {
     enabled = isEnabled;
     final List<dynamic> params = <dynamic>[isEnabled];
     await _channel.invokeMethod<Object>('setCrashReportingEnabled:', params);
   }
 
-  static void reportCrash(dynamic exception, StackTrace stack) async {
+  static Future<void> reportCrash(dynamic exception, StackTrace stack) async {
     if (kReleaseMode && enabled) {
       _reportUnhandledCrash(exception, stack);
     } else {
@@ -35,19 +36,21 @@ class CrashReporting {
   /// Reports a handled crash to you dashboard
   /// [dynamic] exception
   /// [StackTrace] stack
-  static void reportHandledCrash(dynamic exception, [StackTrace stack]) async {
+  static Future<void> reportHandledCrash(dynamic exception,
+      [StackTrace stack]) async {
     if (stack != null) {
       _sendCrash(exception, stack, true);
     } else {
       _sendCrash(exception, StackTrace.current, true);
     }
   }
 
-  static void _reportUnhandledCrash(dynamic exception, StackTrace stack) async {
+  static Future<void> _reportUnhandledCrash(
+      dynamic exception, StackTrace stack) async {
     _sendCrash(exception, stack, false);
   }
 
-  static void _sendCrash(
+  static Future<void> _sendCrash(
       dynamic exception, StackTrace stack, bool handled) async {
     final Trace trace = Trace.from(stack);
     final List<ExceptionData> frames = <ExceptionData>[];

lib/FeatureRequests.dart

@@ -1,10 +1,8 @@
 import 'dart:async';
+
 import 'package:flutter/services.dart';
 
-enum ActionType {
-  requestNewFeature,
-  addCommentToFeature
-}
+enum ActionType { requestNewFeature, addCommentToFeature }
 
 class FeatureRequests {
   static const MethodChannel _channel = MethodChannel('instabug_flutter');
@@ -15,7 +13,7 @@ class FeatureRequests {
   }
 
   ///Shows the UI for feature requests list
-  static void show() async {
+  static Future<void> show() async {
     await _channel.invokeMethod<Object>('showFeatureRequests');
   }
 
@@ -24,7 +22,7 @@ class FeatureRequests {
   /// [isEmailFieldRequired] A boolean to indicate whether email
   /// field is required or not.
   /// [actionTypes] An enum that indicates which action types will have the isEmailFieldRequired
-  static void setEmailFieldRequired(
+  static Future<void> setEmailFieldRequired(
       bool isEmailFieldRequired, List<ActionType> actionTypes) async {
     final List<String> actionTypesStrings = <String>[];
     if (actionTypes != null) {