Merge pull request #240 from Instabug/refactor/remove-deprecated-apis

[MOB-8884] Remove Deprecated APIs

Author: Ali Abdelfattah

android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java

@@ -162,7 +162,6 @@ static void registerCustomTextPlaceHolderKeysArgs(Map<String, Object> args) {
         args.put("CustomTextPlaceHolderKey.invalidEmailMessage", InstabugCustomTextPlaceHolder.Key.INVALID_EMAIL_MESSAGE);
         args.put("CustomTextPlaceHolderKey.invalidCommentMessage", InstabugCustomTextPlaceHolder.Key.INVALID_COMMENT_MESSAGE);
         args.put("CustomTextPlaceHolderKey.invocationHeader", InstabugCustomTextPlaceHolder.Key.INVOCATION_HEADER);
-        args.put("CustomTextPlaceHolderKey.startChats", InstabugCustomTextPlaceHolder.Key.START_CHATS);
         args.put("CustomTextPlaceHolderKey.reportQuestion", InstabugCustomTextPlaceHolder.Key.REPORT_QUESTION);
         args.put("CustomTextPlaceHolderKey.reportBug", InstabugCustomTextPlaceHolder.Key.REPORT_BUG);
         args.put("CustomTextPlaceHolderKey.reportFeedback", InstabugCustomTextPlaceHolder.Key.REPORT_FEEDBACK);

android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java

@@ -14,7 +14,6 @@
 import com.instabug.apm.networking.APMNetworkLogger;
 import com.instabug.bug.BugReporting;
 import com.instabug.bug.invocation.Option;
-import com.instabug.chat.Chats;
 import com.instabug.chat.Replies;
 import com.instabug.crash.CrashReporting;
 import com.instabug.featuresrequest.FeatureRequests;
@@ -828,31 +827,6 @@ public void setEmailFieldRequiredForFeatureRequests(final Boolean isEmailRequire
         FeatureRequests.setEmailFieldRequired(isEmailRequired, actions);
     }
 
-    /**
-     * Manual invocation for chats view.
-     */
-    public void showChats() {
-        Chats.show();
-    }
-
-    /**
-     * Enables and disables everything related to creating new chats.
-     * 
-     * @param {boolean} isEnabled
-     */
-    public void setChatsEnabled(final boolean isEnabled) {
-        new Handler(Looper.getMainLooper()).post(new Runnable() {
-            @Override
-            public void run() {
-                if (isEnabled) {
-                    Chats.setState(Feature.State.ENABLED);
-                } else {
-                    Chats.setState(Feature.State.DISABLED);
-                }
-            }
-        });
-    }
-
     /**
      * Enables and disables everything related to receiving replies.
      * 

android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java

@@ -255,7 +255,6 @@ private List<InstabugCustomTextPlaceHolder.Key> getCurrentlySupportedKeysBySDK()
         keys.add(InstabugCustomTextPlaceHolder.Key.INVALID_EMAIL_MESSAGE);
         keys.add(InstabugCustomTextPlaceHolder.Key.INVALID_COMMENT_MESSAGE);
         keys.add(InstabugCustomTextPlaceHolder.Key.INVOCATION_HEADER);
-        keys.add(InstabugCustomTextPlaceHolder.Key.START_CHATS);
         keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_QUESTION);
         keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_BUG);
         keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_FEEDBACK);
@@ -296,7 +295,6 @@ private List<InstabugCustomTextPlaceHolder.Key> getAllCustomTextPlaceHolderKeys(
         keys.add(InstabugCustomTextPlaceHolder.Key.INVALID_EMAIL_MESSAGE);
         keys.add(InstabugCustomTextPlaceHolder.Key.INVALID_COMMENT_MESSAGE);
         keys.add(InstabugCustomTextPlaceHolder.Key.INVOCATION_HEADER);
-        keys.add(InstabugCustomTextPlaceHolder.Key.START_CHATS);
         keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_QUESTION);
         keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_BUG);
         keys.add(InstabugCustomTextPlaceHolder.Key.REPORT_FEEDBACK);

ios/Classes/InstabugFlutterPlugin.h

@@ -402,17 +402,6 @@
   */
 + (void)setEmailFieldRequiredForFeatureRequests:(NSNumber *)isEmailFieldRequired forAction:(NSArray *)actionTypesArray;
 
-/**
-  * Manual invocation for chats view. 
-  */
-+ (void)showChats;
-
-/**
-  * Enables and disables everything related to creating new chats.
-  * @param isEnabled isEnabled 
-  */
-+ (void)setChatsEnabled:(NSNumber *)isEnabled;
-
 /**
   * Enables and disables everything related to receiving replies.
   * @param isEnabled isEnabled 

ios/Classes/InstabugFlutterPlugin.m

@@ -678,22 +678,6 @@ + (void)setEmailFieldRequiredForFeatureRequests:(NSNumber*)isEmailFieldRequired
     [IBGFeatureRequests setEmailFieldRequired:boolValue forAction:actionTypes];
 }
 
-/**
-  * Manual invocation for chats view. 
-  */
-+ (void)showChats {
-   [IBGChats show];
-}
-
-/**
-  * Enables and disables everything related to creating new chats.
-  * @param {boolean} isEnabled 
-  */
-+ (void)setChatsEnabled:(NSNumber *)isEnabled {
-   BOOL boolValue = [isEnabled boolValue];
-   IBGChats.enabled = boolValue;
-}
-
 /**
   * Enables and disables everything related to receiving replies.
   * @param {boolean} isEnabled 
@@ -1055,7 +1039,6 @@ + (NSDictionary *)constants {
       @"CustomTextPlaceHolderKey.invalidEmailMessage": kIBGInvalidEmailMessageStringName,
       @"CustomTextPlaceHolderKey.invalidCommentMessage": kIBGInvalidCommentMessageStringName,
       @"CustomTextPlaceHolderKey.invocationHeader": kIBGInvocationTitleStringName,
-      @"CustomTextPlaceHolderKey.startChats": kIBGChatsTitleStringName,
       @"CustomTextPlaceHolderKey.reportQuestion": kIBGAskAQuestionStringName,
       @"CustomTextPlaceHolderKey.reportBug": kIBGReportBugStringName,
       @"CustomTextPlaceHolderKey.reportFeedback": kIBGReportFeedbackStringName,

lib/Chats.dart

@@ -54,7 +54,6 @@ enum CustomTextPlaceHolderKey {
   invalidEmailMessage,
   invalidCommentMessage,
   invocationHeader,
-  startChats,
   reportQuestion,
   reportBug,
   reportFeedback,

lib/Instabug.dart

@@ -8,7 +8,6 @@ import 'package:flutter/services.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:instabug_flutter/APM.dart';
 import 'package:instabug_flutter/BugReporting.dart';
-import 'package:instabug_flutter/Chats.dart';
 import 'package:instabug_flutter/CrashReporting.dart';
 import 'package:instabug_flutter/FeatureRequests.dart';
 import 'package:instabug_flutter/Instabug.dart';
@@ -846,23 +845,6 @@ void main() {
     ]);
   });
 
-  test('showChats Test', () async {
-    await Chats.show();
-    expect(log, <Matcher>[isMethodCall('showChats', arguments: null)]);
-  });
-
-  test('setChatsEnabled: Test', () async {
-    const isEnabled = false;
-    final List<dynamic> args = <dynamic>[isEnabled];
-    await Chats.setEnabled(isEnabled);
-    expect(log, <Matcher>[
-      isMethodCall(
-        'setChatsEnabled:',
-        arguments: args,
-      )
-    ]);
-  });
-
   test('setRepliesEnabled: Test', () async {
     const isEnabled = false;
     final List<dynamic> args = <dynamic>[isEnabled];
@@ -1152,7 +1134,7 @@ void main() {
     expect(log, <Matcher>[isMethodCall('endUITrace', arguments: null)]);
   });
 
-    test('endAppLaunch: Test', () async {
+  test('endAppLaunch: Test', () async {
     final List<dynamic> args = <dynamic>[null];
     APM.endAppLaunch();
     expect(log, <Matcher>[isMethodCall('endAppLaunch', arguments: null)]);