Skip to content

Commit 953cb53

Browse files
chore: fix ci failed jobs
1 parent 35a0c5a commit 953cb53

11 files changed

+19
-33
lines changed

lib/instabug_flutter.dart

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ export 'src/models/feature_flag.dart';
55
export 'src/models/network_data.dart';
66
export 'src/models/trace.dart';
77
export 'src/models/w3c_header.dart';
8-
98
// Modules
109
export 'src/modules/apm.dart';
1110
export 'src/modules/bug_reporting.dart';
@@ -20,5 +19,5 @@ export 'src/modules/surveys.dart';
2019
// Utils
2120
export 'src/utils/instabug_navigator_observer.dart';
2221
export 'src/utils/screen_loading/instabug_capture_screen_loading.dart';
23-
export 'src/utils/ui_trace/route_matcher.dart';
2422
export 'src/utils/screen_name_masker.dart' show ScreenNameMaskingCallback;
23+
export 'src/utils/ui_trace/route_matcher.dart';

lib/src/models/InstabugFrameData.dart renamed to lib/src/models/instabug_frame_data.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ class InstabugFrameData {
88
String toString() => "start time: $startTimeTimestamp, duration: $duration";
99

1010
@override
11+
// ignore: hash_and_equals
1112
bool operator ==(covariant InstabugFrameData other) {
1213
if (identical(this, other)) return true;
1314
return startTimeTimestamp == other.startTimeTimestamp &&

lib/src/models/InstabugScreenRenderData.dart renamed to lib/src/models/instabug_screen_render_data.dart

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import 'package:flutter/foundation.dart';
2-
import 'package:instabug_flutter/src/models/InstabugFrameData.dart';
2+
import 'package:instabug_flutter/src/models/instabug_frame_data.dart';
33

44
class InstabugScreenRenderData {
55
int traceId;
@@ -32,6 +32,7 @@ class InstabugScreenRenderData {
3232
'Frame Data[\n${frameData.map((element) => '\t\n$element')}\n]';
3333

3434
@override
35+
// ignore: hash_and_equals
3536
bool operator ==(covariant InstabugScreenRenderData other) {
3637
if (identical(this, other)) return true;
3738
return traceId == other.traceId &&

lib/src/modules/instabug.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
// ignore_for_file: avoid_classes_with_only_static_members
2+
// ignore_for_file: deprecated_member_use
23

34
import 'dart:async';
45

lib/src/utils/screen_loading/screen_loading_manager.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import 'package:instabug_flutter/src/utils/ibg_build_info.dart';
44
import 'package:instabug_flutter/src/utils/ibg_date_time.dart';
55
import 'package:instabug_flutter/src/utils/instabug_logger.dart';
66
import 'package:instabug_flutter/src/utils/instabug_montonic_clock.dart';
7-
import 'package:instabug_flutter/src/utils/ui_trace/flags_config.dart';
87
import 'package:instabug_flutter/src/utils/screen_loading/screen_loading_trace.dart';
8+
import 'package:instabug_flutter/src/utils/ui_trace/flags_config.dart';
99
import 'package:instabug_flutter/src/utils/ui_trace/ui_trace.dart';
1010
import 'package:meta/meta.dart';
1111

lib/src/utils/screen_rendering/instabug_screen_render_manager.dart

Lines changed: 7 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import 'dart:developer';
22
import 'dart:ui';
33

44
import 'package:flutter/widgets.dart';
5-
import 'package:instabug_flutter/src/models/InstabugFrameData.dart';
6-
import 'package:instabug_flutter/src/models/InstabugScreenRenderData.dart';
5+
import 'package:instabug_flutter/src/models/instabug_frame_data.dart';
6+
import 'package:instabug_flutter/src/models/instabug_screen_render_data.dart';
77
import 'package:instabug_flutter/src/modules/apm.dart';
88
import 'package:instabug_flutter/src/utils/screen_rendering/instabug_widget_binding_observer.dart';
99
import 'package:meta/meta.dart';
@@ -39,6 +39,7 @@ class InstabugScreenRenderManager {
3939

4040
bool _isTimingsListenerAttached = false;
4141
bool screenRenderEnabled = false;
42+
4243
InstabugScreenRenderManager._();
4344

4445
static InstabugScreenRenderManager _instance =
@@ -55,8 +56,9 @@ class InstabugScreenRenderManager {
5556

5657
/// setup function for [InstabugScreenRenderManager]
5758
@internal
58-
Future<void> init(WidgetsBinding widgetBinding) async {
59-
if (!_isTimingsListenerAttached) {
59+
Future<void> init(WidgetsBinding? widgetBinding) async {
60+
// passing WidgetsBinding? (nullable) for flutter versions prior than 3.x
61+
if (!_isTimingsListenerAttached && widgetBinding != null) {
6062
_widgetsBinding = widgetBinding;
6163
_addWidgetBindingObserver();
6264
await _initStaticValues();
@@ -139,18 +141,8 @@ class InstabugScreenRenderManager {
139141
double _targetMsPerFrame(double displayRefreshRate) =>
140142
1 / displayRefreshRate * 1000;
141143

142-
/// Check if getting from native would return different value.
143-
/// Platforms may limit what information is available to the application with regard to secondary displays and/or displays that do not have an active application window.
144-
/// Presently, on Android and Web this collection will only contain the display that the current window is on.
145-
/// On iOS, it will only contains the main display on the phone or tablet.
146-
/// On Desktop, it will contain only a main display with a valid refresh rate but invalid size and device pixel ratio values.
147-
//todo: will be compared with value from native side after it's implemented.
148-
// double get _getDeviceRefreshRate =>
149-
// _widgetsBinding.platformDispatcher.displays.first.refreshRate;
150-
151144
/// Get device refresh rate from native side.
152145
//todo: will be compared with value from native side after it's implemented.
153-
// ignore: unused_element
154146
Future<double> get _getDeviceRefreshRateFromNative =>
155147
APM.getDeviceRefreshRate();
156148

@@ -263,7 +255,7 @@ class InstabugScreenRenderManager {
263255
_delayedFrames.add(InstabugFrameData(startTime, duration));
264256
}
265257

266-
//todo: will be removed
258+
//todo: will be removed (is used for debugging)
267259
void _displayFrameTimingDetails(FrameTiming frameTiming) {
268260
if (_isSlow) {
269261
debugPrint(

lib/src/utils/screen_rendering/instabug_widget_binding_observer.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ class InstabugWidgetsBindingObserver extends WidgetsBindingObserver {
6666
}
6767

6868
void _handleDefaultState() {
69-
//todo: will be removed
69+
//todo: will be implemented in next story
7070
debugPrint("default");
7171
}
7272
}

test/instabug_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// ignore_for_file: deprecated_member_use
12
import 'dart:typed_data';
23

34
import 'package:flutter/widgets.dart';

test/utils/screen_loading/screen_loading_manager_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import 'package:instabug_flutter/src/utils/instabug_logger.dart';
99
import 'package:instabug_flutter/src/utils/instabug_montonic_clock.dart';
1010
import 'package:instabug_flutter/src/utils/screen_loading/screen_loading_manager.dart';
1111
import 'package:instabug_flutter/src/utils/screen_loading/screen_loading_trace.dart';
12-
import 'package:instabug_flutter/src/utils/ui_trace/ui_trace.dart';
1312
import 'package:instabug_flutter/src/utils/ui_trace/flags_config.dart';
13+
import 'package:instabug_flutter/src/utils/ui_trace/ui_trace.dart';
1414
import 'package:mockito/annotations.dart';
1515
import 'package:mockito/mockito.dart';
1616

test/utils/screen_render/instabug_screen_render_manager_test.dart

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,9 @@ import 'package:flutter/widgets.dart';
44
import 'package:flutter_test/flutter_test.dart';
55
import 'package:instabug_flutter/instabug_flutter.dart';
66
import 'package:instabug_flutter/src/generated/apm.api.g.dart';
7-
import 'package:instabug_flutter/src/models/InstabugFrameData.dart';
8-
import 'package:instabug_flutter/src/models/InstabugScreenRenderData.dart';
7+
import 'package:instabug_flutter/src/models/instabug_frame_data.dart';
8+
import 'package:instabug_flutter/src/models/instabug_screen_render_data.dart';
9+
910
import 'package:instabug_flutter/src/utils/screen_rendering/instabug_screen_render_manager.dart';
1011
import 'package:mockito/annotations.dart';
1112
import 'package:mockito/mockito.dart';

0 commit comments

Comments
 (0)