Fix void calls on iOS (#205)

Author: via-guy

CHANGELOG.md

@@ -1,3 +1,7 @@
+## v10.11.1 (2022-02-18)
+
+* Fixes iOS platform calls not completing with `void` return type
+
 ## v10.11.0 (2022-01-04)
 
 * Adds support for APM.endAppLaunch API

analysis_options.yaml

@@ -155,7 +155,7 @@ linter:
     - throw_in_finally
     # - type_annotate_public_apis # subset of always_specify_types
     - type_init_formals
-    # - unawaited_futures # too many false positives
+    - unawaited_futures
     # - unnecessary_await_in_return # not yet tested
     - unnecessary_brace_in_string_interps
     - unnecessary_const

ios/Classes/InstabugFlutterPlugin.h

@@ -428,7 +428,7 @@
   *
   * @param isEnabled whether chat notification is reburied or not
   */
-- (void)setChatNotificationEnabled:(NSNumber *)isEnabled;
++ (void)setChatNotificationEnabled:(NSNumber *)isEnabled;
 
 + (void)networkLog:(NSDictionary *)networkData;
 

ios/Classes/InstabugFlutterPlugin.m

@@ -20,36 +20,40 @@ + (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar>*)registrar {
 
 - (void)handleMethodCall:(FlutterMethodCall*)call result:(FlutterResult)result {
     BOOL isImplemented = NO;
-      SEL method = NSSelectorFromString(call.method);
-      if([[InstabugFlutterPlugin class] respondsToSelector:method]) {
+    SEL method = NSSelectorFromString(call.method);
+    if ([[InstabugFlutterPlugin class] respondsToSelector:method]) {
         isImplemented = YES;
         NSInvocation *inv = [NSInvocation invocationWithMethodSignature:[[InstabugFlutterPlugin class] methodSignatureForSelector:method]];
         [inv setSelector:method];
         [inv setTarget:[InstabugFlutterPlugin class]];
         /*
          * Indices 0 and 1 indicate the hidden arguments self and _cmd,
-         * respectively; you should set these values directly with the target and selector properties. 
+         * respectively; you should set these values directly with the target and selector properties.
          * Use indices 2 and greater for the arguments normally passed in a message.
          */
         NSInteger index = 2;
         NSArray* argumentsArray = call.arguments;
         for (NSObject * argument in argumentsArray) {
-          [inv setArgument:&(argument) atIndex:index];
-          index++;
-        }      
+            [inv setArgument:&argument atIndex:index];
+            index++;
+        }
         [inv invoke];
-          NSMethodSignature *signature = [inv methodSignature];
-          const char *type = [signature methodReturnType];
-
-          if (strcmp(type, "v") != 0) {
-            void *returnVal;
-            [inv getReturnValue:&returnVal];
-            NSObject *resultSet = (__bridge NSObject *)returnVal;
-            result(resultSet);
-          }
-      }
+        NSMethodSignature *signature = [inv methodSignature];
+        const char *type = [signature methodReturnType];
+
+        if (result != nil) {
+            if (strcmp(type, "v") != 0) {
+                void *returnVal;
+                [inv getReturnValue:&returnVal];
+                NSObject *resultSet = (__bridge NSObject *)returnVal;
+                result(resultSet);
+            } else {
+                result(nil);
+            }
+        }
+    }
     if (!isImplemented) {
-      result(FlutterMethodNotImplemented);
+        result(FlutterMethodNotImplemented);
     }
 }
 

lib/APM.dart

@@ -2,6 +2,7 @@
 
 import 'dart:async';
 import 'dart:io';
+
 import 'package:flutter/services.dart';
 import 'package:instabug_flutter/models/network_data.dart';
 import 'package:instabug_flutter/models/trace.dart';
@@ -32,21 +33,21 @@ class APM {
 
   /// Enables or disables APM feature.
   /// [boolean] isEnabled
-  static void setEnabled(bool isEnabled) async {
+  static Future<void> setEnabled(bool isEnabled) async {
     final List<dynamic> params = <dynamic>[isEnabled];
     await _channel.invokeMethod<Object>('setAPMEnabled:', params);
   }
 
   /// Sets log Level to determine level of details in a log
   /// [logLevel] Enum value to determine the level
-  static void setLogLevel(LogLevel logLevel) async {
+  static Future<void> setLogLevel(LogLevel logLevel) async {
     final List<dynamic> params = <dynamic>[logLevel.toString()];
     await _channel.invokeMethod<Object>('setAPMLogLevel:', params);
   }
 
   /// Enables or disables cold app launch tracking.
   /// [boolean] isEnabled
-  static void setColdAppLaunchEnabled(bool isEnabled) async {
+  static Future<void> setColdAppLaunchEnabled(bool isEnabled) async {
     final List<dynamic> params = <dynamic>[isEnabled];
     await _channel.invokeMethod<Object>('setColdAppLaunchEnabled:', params);
   }
@@ -69,15 +70,15 @@ class APM {
       }
     };
     _startExecutionTraceCallback = callback;
-    _channel.invokeMethod<Object>('startExecutionTrace:id:', params);
+    await _channel.invokeMethod<Object>('startExecutionTrace:id:', params);
     return completer.future;
   }
 
   /// Sets attribute of an execution trace.
   /// [String] id of the trace.
   /// [String] key of attribute.
   /// [String] value of attribute.
-  static void setExecutionTraceAttribute(
+  static Future<void> setExecutionTraceAttribute(
       String id, String key, String value) async {
     final List<dynamic> params = <dynamic>[
       id.toString(),
@@ -90,27 +91,27 @@ class APM {
 
   /// Ends an execution trace.
   /// [String] id of the trace.
-  static void endExecutionTrace(String id) async {
+  static Future<void> endExecutionTrace(String id) async {
     final List<dynamic> params = <dynamic>[id];
     await _channel.invokeMethod<Object>('endExecutionTrace:', params);
   }
 
   /// Enables or disables auto UI tracing.
   /// [boolean] isEnabled
-  static void setAutoUITraceEnabled(bool isEnabled) async {
+  static Future<void> setAutoUITraceEnabled(bool isEnabled) async {
     final List<dynamic> params = <dynamic>[isEnabled];
     await _channel.invokeMethod<Object>('setAutoUITraceEnabled:', params);
   }
 
   /// Starts UI trace.
   /// [String] name
-  static void startUITrace(String name) async {
+  static Future<void> startUITrace(String name) async {
     final List<dynamic> params = <dynamic>[name];
     await _channel.invokeMethod<Object>('startUITrace:', params);
   }
 
   /// Ends UI trace.
-  static void endUITrace() async {
+  static Future<void> endUITrace() async {
     await _channel.invokeMethod<Object>('endUITrace');
   }
   /// Ends UI trace.

lib/CrashReporting.dart

@@ -26,7 +26,7 @@ class CrashReporting {
 
   static Future<void> reportCrash(dynamic exception, StackTrace stack) async {
     if (kReleaseMode && enabled) {
-      _reportUnhandledCrash(exception, stack);
+      await _reportUnhandledCrash(exception, stack);
     } else {
       FlutterError.dumpErrorToConsole(
           FlutterErrorDetails(stack: stack, exception: exception));
@@ -38,12 +38,12 @@ class CrashReporting {
   /// [StackTrace] stack
   static Future<void> reportHandledCrash(dynamic exception,
       [StackTrace? stack]) async {
-    _sendCrash(exception, stack ?? StackTrace.current, true);
+    await _sendCrash(exception, stack ?? StackTrace.current, true);
   }
 
   static Future<void> _reportUnhandledCrash(
       dynamic exception, StackTrace stack) async {
-    _sendCrash(exception, stack, false);
+    await _sendCrash(exception, stack, false);
   }
 
   static Future<void> _sendCrash(

lib/Instabug.dart

@@ -148,7 +148,7 @@ class Instabug {
 
   /// Sets the verbosity level of logs used to debug The SDK. The defualt value in debug
   /// mode is sdkDebugLogsLevelVerbose and in production is sdkDebugLogsLevelError.
-  static void setSdkDebugLogsLevel(
+  static Future<void> setSdkDebugLogsLevel(
       IBGSDKDebugLogsLevel sdkDebugLogsLevel) async {
     final List<dynamic> params = <dynamic>[sdkDebugLogsLevel.toString()];
     await _channel.invokeMethod<Object>('setSdkDebugLogsLevel:', params);
@@ -238,7 +238,7 @@ class Instabug {
   /// Android only
   /// Enable/disable SDK logs
   /// [debugEnabled] desired state of debug mode.
-  static void setDebugEnabled(bool debugEnabled) async {
+  static Future<void> setDebugEnabled(bool debugEnabled) async {
     if (PlatformManager.instance.isAndroid()) {
       final List<dynamic> params = <dynamic>[debugEnabled];
       await _channel.invokeMethod<Object>('setDebugEnabled:', params);