Skip to content

Commit 9bcc31c

Browse files
DavidMina96HeshamMegid
authored andcommitted
[MOB-10650] Support more Locales (#325)
Adds hungarian and finnish locales support and adds missing mapping for norwegian and slovak locales on iOS
1 parent f22c3ac commit 9bcc31c

File tree

6 files changed

+27
-8
lines changed

6 files changed

+27
-8
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## Unreleased
2+
3+
* Adds `hungarian` and `finnish` locales support
4+
* Adds missing mapping for `norwegian` and `slovak` locales on iOS
5+
16
## 11.6.0 (2022-12-29)
27

38
* Bumps Instabug Android SDK to v11.7.0

android/src/main/java/com/instabug/flutter/util/ArgsRegistry.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,10 @@ public T get(Object key) {
115115
put("IBGLocale.danish", InstabugLocale.DANISH);
116116
put("IBGLocale.dutch", InstabugLocale.NETHERLANDS);
117117
put("IBGLocale.english", InstabugLocale.ENGLISH);
118+
put("IBGLocale.finnish", InstabugLocale.FINNISH);
118119
put("IBGLocale.french", InstabugLocale.FRENCH);
119120
put("IBGLocale.german", InstabugLocale.GERMAN);
121+
put("IBGLocale.hungarian", InstabugLocale.HUNGARIAN);
120122
put("IBGLocale.indonesian", InstabugLocale.INDONESIAN);
121123
put("IBGLocale.italian", InstabugLocale.ITALIAN);
122124
put("IBGLocale.japanese", InstabugLocale.JAPANESE);
@@ -127,8 +129,8 @@ public T get(Object key) {
127129
put("IBGLocale.portuguesePortugal", InstabugLocale.PORTUGUESE_PORTUGAL);
128130
put("IBGLocale.romanian", InstabugLocale.ROMANIAN);
129131
put("IBGLocale.russian", InstabugLocale.RUSSIAN);
130-
put("IBGLocale.spanish", InstabugLocale.SPANISH);
131132
put("IBGLocale.slovak", InstabugLocale.SLOVAK);
133+
put("IBGLocale.spanish", InstabugLocale.SPANISH);
132134
put("IBGLocale.swedish", InstabugLocale.SWEDISH);
133135
put("IBGLocale.turkish", InstabugLocale.TURKISH);
134136
}};

android/src/test/java/com/instabug/flutter/ArgsRegistryTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,8 +195,10 @@ public void testLocales() {
195195
InstabugLocale.DANISH,
196196
InstabugLocale.NETHERLANDS,
197197
InstabugLocale.ENGLISH,
198+
InstabugLocale.FINNISH,
198199
InstabugLocale.FRENCH,
199200
InstabugLocale.GERMAN,
201+
InstabugLocale.HUNGARIAN,
200202
InstabugLocale.INDONESIAN,
201203
InstabugLocale.ITALIAN,
202204
InstabugLocale.JAPANESE,
@@ -207,8 +209,8 @@ public void testLocales() {
207209
InstabugLocale.PORTUGUESE_PORTUGAL,
208210
InstabugLocale.ROMANIAN,
209211
InstabugLocale.RUSSIAN,
210-
InstabugLocale.SPANISH,
211212
InstabugLocale.SLOVAK,
213+
InstabugLocale.SPANISH,
212214
InstabugLocale.SWEDISH,
213215
InstabugLocale.TURKISH,
214216
};

example/ios/InstabugSampleTests/ArgsRegistryTests.m

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,19 +179,23 @@ - (void)testLocales {
179179
@(IBGLocaleDanish),
180180
@(IBGLocaleDutch),
181181
@(IBGLocaleEnglish),
182+
@(IBGLocaleFinnish),
182183
@(IBGLocaleFrench),
183184
@(IBGLocaleGerman),
185+
@(IBGLocaleHungarian),
184186
@(IBGLocaleItalian),
185187
@(IBGLocaleJapanese),
186188
@(IBGLocaleKorean),
189+
@(IBGLocaleNorwegian),
187190
@(IBGLocalePolish),
188191
@(IBGLocalePortugueseBrazil),
189192
@(IBGLocalePortuguese),
193+
@(IBGLocaleRomanian),
190194
@(IBGLocaleRussian),
195+
@(IBGLocaleSlovak),
191196
@(IBGLocaleSpanish),
192197
@(IBGLocaleSwedish),
193198
@(IBGLocaleTurkish),
194-
@(IBGLocaleRomanian)
195199
];
196200

197201
for (NSNumber *value in values) {

ios/Classes/Util/ArgsRegistry.m

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,19 +123,23 @@ + (ArgsDictionary *)locales {
123123
@"IBGLocale.danish" : @(IBGLocaleDanish),
124124
@"IBGLocale.dutch" : @(IBGLocaleDutch),
125125
@"IBGLocale.english" : @(IBGLocaleEnglish),
126+
@"IBGLocale.finnish" : @(IBGLocaleFinnish),
126127
@"IBGLocale.french" : @(IBGLocaleFrench),
127128
@"IBGLocale.german" : @(IBGLocaleGerman),
129+
@"IBGLocale.hungarian" : @(IBGLocaleHungarian),
128130
@"IBGLocale.italian" : @(IBGLocaleItalian),
129131
@"IBGLocale.japanese" : @(IBGLocaleJapanese),
130132
@"IBGLocale.korean" : @(IBGLocaleKorean),
133+
@"IBGLocale.norwegian" : @(IBGLocaleNorwegian),
131134
@"IBGLocale.polish" : @(IBGLocalePolish),
132135
@"IBGLocale.portugueseBrazil" : @(IBGLocalePortugueseBrazil),
133136
@"IBGLocale.portuguesePortugal" : @(IBGLocalePortuguese),
137+
@"IBGLocale.romanian" : @(IBGLocaleRomanian),
134138
@"IBGLocale.russian" : @(IBGLocaleRussian),
139+
@"IBGLocale.slovak" : @(IBGLocaleSlovak),
135140
@"IBGLocale.spanish" : @(IBGLocaleSpanish),
136141
@"IBGLocale.swedish" : @(IBGLocaleSwedish),
137142
@"IBGLocale.turkish" : @(IBGLocaleTurkish),
138-
@"IBGLocale.romanian" : @(IBGLocaleRomanian),
139143
};
140144
}
141145

lib/src/modules/instabug.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,22 +35,24 @@ enum IBGLocale {
3535
danish,
3636
dutch,
3737
english,
38+
finnish,
3839
french,
3940
german,
41+
hungarian,
42+
indonesian,
4043
italian,
4144
japanese,
4245
korean,
46+
norwegian,
4347
polish,
4448
portugueseBrazil,
4549
portuguesePortugal,
50+
romanian,
4651
russian,
52+
slovak,
4753
spanish,
4854
swedish,
4955
turkish,
50-
indonesian,
51-
slovak,
52-
norwegian,
53-
romanian,
5456
}
5557

5658
enum IBGSDKDebugLogsLevel { verbose, debug, error, none }

0 commit comments

Comments
 (0)