Skip to content

Commit a39ea76

Browse files
chore: remove logs
1 parent 5c1551b commit a39ea76

File tree

3 files changed

+1
-84
lines changed

3 files changed

+1
-84
lines changed

lib/src/utils/instabug_navigator_observer.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'dart:async';
2-
import 'dart:developer';
32

43
import 'package:flutter/material.dart';
54
import 'package:instabug_flutter/instabug_flutter.dart';
@@ -68,7 +67,6 @@ class InstabugNavigatorObserver extends NavigatorObserver {
6867

6968
FutureOr<void> _startScreenRenderCollector(int? uiTraceId) async {
7069
final isScreenRender = await FlagsConfig.screenRendering.isEnabled();
71-
log("isScreenRender: $isScreenRender", name: 'Andrew');
7270
_checkForScreenRenderInitialization(isScreenRender);
7371
if (uiTraceId != null && isScreenRender) {
7472
InstabugScreenRenderManager.I

lib/src/utils/screen_rendering/instabug_screen_render_manager.dart

Lines changed: 0 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
import 'dart:async';
2-
import 'dart:developer';
32
import 'dart:ui';
43

54
import 'package:flutter/widgets.dart';
@@ -10,8 +9,6 @@ import 'package:instabug_flutter/src/utils/instabug_logger.dart';
109
import 'package:instabug_flutter/src/utils/screen_rendering/instabug_widget_binding_observer.dart';
1110
import 'package:meta/meta.dart';
1211

13-
//todo: remove logs
14-
1512
@internal
1613
enum UiTraceType {
1714
auto,
@@ -65,7 +62,6 @@ class InstabugScreenRenderManager {
6562
try {
6663
// passing WidgetsBinding? (nullable) for flutter versions prior than 3.x
6764
if (!screenRenderEnabled && widgetBinding != null) {
68-
log("$tag: init", name: 'andrew');
6965
_widgetsBinding = widgetBinding;
7066
_addWidgetBindingObserver();
7167
await _initStaticValues();
@@ -84,7 +80,6 @@ class InstabugScreenRenderManager {
8480
_rasterTime = frameTiming.rasterDuration.inMilliseconds;
8581
_totalTime = frameTiming.totalSpan.inMilliseconds;
8682

87-
_displayFrameTimingDetails(frameTiming);
8883
if (_isUiFrozen) {
8984
_frozenFramesTotalDurationMs += _buildTime;
9085
} else if (_isRasterFrozen) {
@@ -126,16 +121,8 @@ class InstabugScreenRenderManager {
126121
try {
127122
// Return if frameTimingListener not attached
128123
if (!screenRenderEnabled || !_isTimingsListenerAttached) {
129-
log(
130-
"$tag: startScreenRenderCollectorForTraceId returned",
131-
name: 'andrew',
132-
);
133124
return;
134125
}
135-
log(
136-
"$tag: startScreenRenderCollectorForTraceId $traceId (${type.name})",
137-
name: 'andrew',
138-
);
139126

140127
//Save the memory cached data to be sent to native side
141128
if (_delayedFrames.isNotEmpty) {
@@ -188,8 +175,6 @@ class InstabugScreenRenderManager {
188175
_screenRenderForAutoUiTrace.isNotEmpty) {
189176
_reportScreenRenderForAutoUiTrace(_screenRenderForAutoUiTrace);
190177
}
191-
192-
log("$tag: stopScreenRenderCollector", name: 'andrew');
193178
} catch (error, stackTrace) {
194179
_logExceptionErrorAndStackTrace(error, stackTrace);
195180
}
@@ -210,7 +195,6 @@ class InstabugScreenRenderManager {
210195
_reportScreenRenderForCustomUiTrace(_screenRenderForCustomUiTrace);
211196

212197
_screenRenderForCustomUiTrace.clear();
213-
log("$tag: endCustom", name: 'andrew');
214198
} catch (error, stackTrace) {
215199
_logExceptionErrorAndStackTrace(error, stackTrace);
216200
}
@@ -222,13 +206,10 @@ class InstabugScreenRenderManager {
222206
_removeFrameTimings();
223207
_widgetsBinding = null;
224208
screenRenderEnabled = false;
225-
log("$tag: dispose", name: 'andrew');
226209
}
227210

228211
/// --------------------------- private methods ---------------------
229212
230-
bool get _isSlow => _isUiSlow || _isRasterSlow;
231-
232213
bool get _isUiDelayed => _isUiSlow || _isUiFrozen;
233214

234215
bool get _isRasterDelayed => _isRasterSlow || _isRasterFrozen;
@@ -241,8 +222,6 @@ class InstabugScreenRenderManager {
241222
_rasterTime > _slowFrameThresholdMs &&
242223
_rasterTime < _frozenFrameThresholdMs;
243224

244-
bool get _isFrozen => _isUiFrozen || _isRasterFrozen || _isTotalTimeLarge;
245-
246225
bool get _isTotalTimeLarge => _totalTime >= _frozenFrameThresholdMs;
247226

248227
bool get _isUiFrozen => _buildTime >= _frozenFrameThresholdMs;
@@ -272,7 +251,6 @@ class InstabugScreenRenderManager {
272251
_slowFrameThresholdMs = _targetMsPerFrame(_deviceRefreshRate);
273252
_screenRenderForAutoUiTrace = InstabugScreenRenderData(frameData: []);
274253
_screenRenderForCustomUiTrace = InstabugScreenRenderData(frameData: []);
275-
log("$tag: _initStaticValues ", name: 'andrew');
276254
}
277255

278256
/// Add a frame observer by calling [WidgetsBinding.instance.addTimingsCallback]
@@ -282,29 +260,20 @@ class InstabugScreenRenderManager {
282260
}
283261
_widgetsBinding?.addTimingsCallback(_timingsCallback);
284262
_isTimingsListenerAttached = true;
285-
log("$tag: _initFrameTimings ", name: 'andrew');
286263
}
287264

288265
/// Remove the running frame observer by calling [_widgetsBinding.removeTimingsCallback]
289266
void _removeFrameTimings() {
290267
if (!_isTimingsListenerAttached) return; // No timings callback attached.
291268
_widgetsBinding?.removeTimingsCallback(_timingsCallback);
292269
_isTimingsListenerAttached = false;
293-
log(
294-
"$tag: _removeFrameTimings ",
295-
name: 'andrew',
296-
);
297270
}
298271

299272
/// Reset the memory cashed data
300273
void _resetCachedFrameData() {
301274
_slowFramesTotalDurationMs = 0;
302275
_frozenFramesTotalDurationMs = 0;
303276
_delayedFrames.clear();
304-
log(
305-
"$tag: _resetCachedFrameData ",
306-
name: 'andrew',
307-
);
308277
}
309278

310279
/// Save Slow/Frozen Frames data
@@ -318,45 +287,6 @@ class InstabugScreenRenderManager {
318287
);
319288
}
320289

321-
//todo: will be removed (is used for debugging)
322-
void _displayFrameTimingDetails(FrameTiming frameTiming) {
323-
if (_isSlow) {
324-
debugPrint(
325-
'========================= Slow frame detected ⚠️ =========================',
326-
);
327-
}
328-
if (_isFrozen) {
329-
debugPrint(
330-
'========================= Frozen frame detected 🚨 =========================',
331-
);
332-
}
333-
334-
if (_isFrozen || _isSlow) {
335-
debugPrint(
336-
"{\n\t$frameTiming\n\t"
337-
"Timestamps(${frameTiming.timestampInMicroseconds(
338-
FramePhase.buildStart,
339-
)}, ${frameTiming.timestampInMicroseconds(
340-
FramePhase.buildFinish,
341-
)}, ${frameTiming.timestampInMicroseconds(
342-
FramePhase.rasterStart,
343-
)}, ${frameTiming.timestampInMicroseconds(
344-
FramePhase.rasterFinish,
345-
)}, ${frameTiming.timestampInMicroseconds(
346-
FramePhase.vsyncStart,
347-
)}, ${frameTiming.timestampInMicroseconds(
348-
FramePhase.rasterFinishWallTime,
349-
)}"
350-
")\n}\n",
351-
);
352-
debugPrint("Device refresh rate: $_deviceRefreshRate FPS");
353-
debugPrint(
354-
"Threshold: $_slowFrameThresholdMs ms\n"
355-
"===============================================================================",
356-
);
357-
}
358-
}
359-
360290
/// Ends custom ui trace with the screen render data that has been collected for it.
361291
/// params:
362292
/// [InstabugScreenRenderData] screenRenderData.
@@ -398,10 +328,6 @@ class InstabugScreenRenderManager {
398328
if (_screenRenderForCustomUiTrace.isActive) {
399329
_updateCustomUiData();
400330
}
401-
log(
402-
"$tag: Captured data is saved ",
403-
name: 'andrew',
404-
);
405331
}
406332

407333
/// Updates the custom UI trace screen render data with the currently collected

lib/src/utils/screen_rendering/instabug_widget_binding_observer.dart

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
import 'dart:developer';
2-
31
import 'package:flutter/widgets.dart';
42
import 'package:instabug_flutter/src/utils/screen_loading/screen_loading_manager.dart';
53
import 'package:instabug_flutter/src/utils/screen_name_masker.dart';
64
import 'package:instabug_flutter/src/utils/screen_rendering/instabug_screen_render_manager.dart';
75
import 'package:meta/meta.dart';
86

9-
//todo: remove logs
107
class InstabugWidgetsBindingObserver extends WidgetsBindingObserver {
118
InstabugWidgetsBindingObserver._();
129

@@ -30,7 +27,6 @@ class InstabugWidgetsBindingObserver extends WidgetsBindingObserver {
3027
}
3128

3229
void _handleResumedState() {
33-
log('Performing resume actions...', name: 'andrew');
3430
final lastUiTrace = ScreenLoadingManager.I.currentUiTrace;
3531
if (lastUiTrace == null) {
3632
return;
@@ -48,23 +44,20 @@ class InstabugWidgetsBindingObserver extends WidgetsBindingObserver {
4844
}
4945

5046
void _handlePausedState() {
51-
log('Performing pause actions...', name: 'andrew');
52-
5347
if (InstabugScreenRenderManager.I.screenRenderEnabled) {
5448
InstabugScreenRenderManager.I.stopScreenRenderCollector();
5549
}
5650
}
5751

5852
void _handleDetachedState() {
59-
log('Performing detached actions...', name: 'andrew');
6053
if (InstabugScreenRenderManager.I.screenRenderEnabled) {
6154
InstabugScreenRenderManager.I.stopScreenRenderCollector();
6255
}
6356
dispose();
6457
}
6558

6659
void _handleDefaultState() {
67-
log("handle default state", name: 'andrew');
60+
// Added for lint warnings
6861
}
6962

7063
@override

0 commit comments

Comments
 (0)