Skip to content

Commit df1ba40

Browse files
authored
[Mob 3192] - Flutter API: welcomeMessageMode (#56)
Android API Mapping iOS API Mapping Flutter API Mapping Adds tests for new API updates Readme updated Changelog
1 parent b02faf7 commit df1ba40

File tree

7 files changed

+47
-4
lines changed

7 files changed

+47
-4
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
## Master
22

3+
* Adds setWelcomeMessageMode API mapping.
34
* Adds addFileAttachmentWithURL, addFileAttachmentWithData, clearFileAttachments API mapping.
45
* Adds setUserData API mapping.
56
* Adds setPrimaryColor API mapping.

README.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,14 @@ The section below contains the APIs we're planning to implement for our 1.0 rele
4242
| `getUserAttributes()` | `getAllUserAttributes()`<br>`+ userAttributes:` |
4343
| `logUserEventWithName(String name)` | `logUserEvent(String name)`<br>`+ logUserEventWithName:` |
4444
| `show()` | `show()`<br>`+ show` |
45-
| `setSessionProfilerEnabled(bool sessionProfilerEnabled)` | `setSessionProfilerState(Feature.State state)`<br>`sessionProfilerEnabled` |
46-
|`setPrimaryColor(Color color)` | `setPrimaryColor(@ColorInt int primaryColorValue)`<br>`tintColor` |
45+
| `setSessionProfilerEnabled(bool sessionProfilerEnabled)` | `setSessionProfilerState(Feature.State state)`<br>`sessionProfilerEnabled` |
46+
| `setPrimaryColor(Color color)` | `setPrimaryColor(@ColorInt int primaryColorValue)`<br>`tintColor` |
4747
| | `onReportSubmitHandler(Report.OnReportCreatedListener listener)`<br>`willSendReportHandler`. |
48-
|`setUserData(String userData)` | `setUserData(String userData)`<br>`userData` |
48+
| `setUserData(String userData)` | `setUserData(String userData)`<br>`userData` |
4949
| `addFileAttachmentWithURL(String filePath, String fileName)` | `addFileAttachment(Uri fileUri, String fileNameWithExtension)`<br>`+ addFileAttachmentWithURL:` |
5050
| `addFileAttachmentWithData(Uint8List data, String fileName)` | `addFileAttachment(byte[] data, String fileNameWithExtension)` `+ addFileAttachmentWithData:` |
5151
| `clearFileAttachments()` | `clearFileAttachment()`<br>`+ clearFileAttachments` |
52-
| | `setWelcomeMessageState(WelcomeMessage.State welcomeMessageState)`<br>`welcomeMessageMode` |
52+
| `setWelcomeMessageMode(WelcomeMessageMode welcomeMessageMode)` | `setWelcomeMessageState(WelcomeMessage.State welcomeMessageState)`<br>`welcomeMessageMode` |
5353

5454
#### `BugReporting`
5555

android/src/main/java/com/instabug/instabugflutter/InstabugFlutterPlugin.java

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -459,4 +459,17 @@ public void addFileAttachmentWithData(byte[] data, String fileNameWithExtension)
459459
public void clearFileAttachments() {
460460
Instabug.clearFileAttachment();
461461
}
462+
463+
/**
464+
* Sets the welcome message mode to live, beta or disabled.
465+
*
466+
* @param welcomeMessageMode An enum to set the welcome message mode to
467+
* live, beta or disabled.
468+
*/
469+
public void setWelcomeMessageMode(String welcomeMessageMode) {
470+
WelcomeMessage.State resolvedWelcomeMessageMode = ArgsRegistry.getDeserializedValue(
471+
welcomeMessageMode, WelcomeMessage.State.class);
472+
Instabug.setWelcomeMessageState(resolvedWelcomeMessageMode);
473+
}
474+
462475
}

example/lib/main.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ class _MyAppState extends State<MyApp> {
3232
Instabug.start('9582e6cfe34e2b8897f48cfa3b617adb', <InvocationEvent>[InvocationEvent.floatingButton, InvocationEvent.shake]);
3333
}
3434
Instabug.showWelcomeMessageWithMode(WelcomeMessageMode.beta);
35+
Instabug.setWelcomeMessageMode(WelcomeMessageMode.beta);
3536
Instabug.identifyUserWithEmail('[email protected]', 'Aly Ezz');
3637
InstabugLog.logInfo('Test Log Info Message from Flutter!');
3738
InstabugLog.logDebug('Test Debug Message from Flutter!');

ios/Classes/InstabugFlutterPlugin.m

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,17 @@ + (void)clearFileAttachments {
347347
[Instabug clearFileAttachments];
348348
}
349349

350+
/**
351+
* Sets the welcome message mode to live, beta or disabled.
352+
*
353+
* @param welcomeMessageMode An enum to set the welcome message mode to
354+
* live, beta or disabled.
355+
*/
356+
+ (void)setWelcomeMessageMode:(NSString *)welcomeMessageMode {
357+
NSDictionary *constants = [self constants];
358+
NSInteger welcomeMode = ((NSNumber *) constants[welcomeMessageMode]).integerValue;
359+
[Instabug setWelcomeMessageMode:welcomeMode];
360+
}
350361

351362
+ (NSDictionary *)constants {
352363
return @{

lib/Instabug.dart

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,13 @@ class Instabug {
261261
await _channel.invokeMethod<Object>('clearFileAttachments');
262262
}
263263

264+
///Sets the welcome message mode to live, beta or disabled.
265+
///[welcomeMessageMode] An enum to set the welcome message mode to live, beta or disabled.
266+
static void setWelcomeMessageMode(WelcomeMessageMode welcomeMessageMode) async {
267+
final List<dynamic> params = <dynamic>[welcomeMessageMode.toString()];
268+
await _channel.invokeMethod<Object>('setWelcomeMessageMode:', params);
269+
}
270+
264271
}
265272

266273

test/instabug_flutter_test.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -351,6 +351,16 @@ test('startWithToken:invocationEvents: Test', () async {
351351
]);
352352
});
353353

354+
test('setWelcomeMessageMode Test', () async {
355+
final List<dynamic> args = <dynamic>[WelcomeMessageMode.live.toString()];
356+
Instabug.setWelcomeMessageMode(WelcomeMessageMode.live);
357+
expect(log, <Matcher>[
358+
isMethodCall('setWelcomeMessageMode:',
359+
arguments: args,
360+
)
361+
]);
362+
});
363+
354364
}
355365

356366

0 commit comments

Comments
 (0)