Skip to content

Commit 24b3714

Browse files
committed
🎨 Improve the format of the unlink, and linking scripts.
1 parent 7f1254b commit 24b3714

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

link.rb

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,19 @@
3030

3131
# Add new "Embed Frameworks" build phase to target
3232
embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Frameworks'}
33+
is_linked = true
3334
if embed_frameworks_build_phase == nil
35+
is_linked = false
3436
embed_frameworks_build_phase = project.new(Xcodeproj::Project::Object::PBXCopyFilesBuildPhase)
3537
embed_frameworks_build_phase.name = 'Embed Frameworks'
3638
embed_frameworks_build_phase.symbol_dst_subfolder_spec = :frameworks
3739
target.build_phases << embed_frameworks_build_phase
3840
end
3941

42+
Kernel.exit(0) if is_linked
43+
4044
# Add framework search path to target
4145
['Debug', 'Release'].each do |config|
42-
paths = ['$(inherited)', framework_root]
4346
framework_search_paths = target.build_settings(config)['FRAMEWORK_SEARCH_PATHS']
4447

4548
framework_search_paths ||= ['$(inherited)']
@@ -51,9 +54,8 @@
5154

5255
# Add framework to target as "Embedded Frameworks"
5356
framework_ref = frameworks_group.files.find { |file_reference| file_reference.path == "#{framework_root}/#{framework_name}"}
54-
is_linked = true
57+
5558
if framework_ref == nil
56-
is_linked = false
5759
framework_ref = frameworks_group.new_file("#{framework_root}/#{framework_name}")
5860
build_file = embed_frameworks_build_phase.add_file_reference(framework_ref)
5961
frameworks_build_phase.add_file_reference(framework_ref)
@@ -68,4 +70,4 @@
6870
end
6971

7072
# Save Xcode project
71-
project.save unless is_linked
73+
project.save

unlink.rb

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,13 @@
2525

2626
# Remove "Embed Frameworks" build phase to target
2727
embed_frameworks_build_phase = target.build_phases.find { |build_phase| build_phase.to_s == 'Embed Frameworks'}
28+
Kernel.exit(0) unless embed_frameworks_build_phase
2829
target.build_phases.delete(embed_frameworks_build_phase) if embed_frameworks_build_phase
2930

30-
is_string = false;
31-
3231
# Remove framework search path from target
3332
['Debug', 'Release'].each do |config|
34-
is_string ||= target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'].is_a? String
35-
target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'].delete(framework_root)
33+
# is_string ||= target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'].is_a? String
34+
target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'].delete(framework_root) if target.build_settings(config)['FRAMEWORK_SEARCH_PATHS'].is_a? Array
3635
end
3736

3837
# Remove framework from target from "Embedded Frameworks"
@@ -45,4 +44,4 @@
4544
target.build_phases.delete(shell_script_build_phase) if shell_script_build_phase
4645

4746
# Save Xcode project
48-
project.save unless is_string
47+
project.save

0 commit comments

Comments
 (0)