Skip to content

Commit 3f4a65f

Browse files
committed
📝 Update setPostInvocationHandler implementation accounting for the new Android native API
1 parent 66e5f69 commit 3f4a65f

File tree

2 files changed

+28
-18
lines changed

2 files changed

+28
-18
lines changed

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ android {
2121

2222
dependencies {
2323
compile 'com.facebook.react:react-native:0.20.+'
24-
compile ('com.instabug.library:instabug:5.0.0.6.2-SNAPSHOT'){
24+
compile ('com.instabug.library:instabug:5.0.0.6.12-SNAPSHOT'){
2525
exclude group: 'com.android.support:appcompat-v7'
2626
}
2727

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

Lines changed: 27 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import com.instabug.library.InstabugColorTheme;
3535
import com.instabug.library.invocation.OnInvokeCallback;
3636
import com.instabug.library.invocation.util.InstabugVideoRecordingButtonCorner;
37+
import com.instabug.library.invocation.util.InstabugVideoRecordingButtonPosition;
3738
import com.instabug.library.logging.InstabugLog;
3839
import com.instabug.library.bugreporting.model.ReportCategory;
3940
import com.instabug.library.InstabugCustomTextPlaceHolder;
@@ -372,7 +373,7 @@ public void setViewHierarchyEnabled(boolean enabled) {
372373
@ReactMethod
373374
public void setVideoRecordingFloatingButtonPosition(String corner) {
374375
try {
375-
BugReporting.setVideoRecordingFloatingButtonCorner(getVideoRecordingButtonCorner(corner));
376+
BugReporting.setVideoRecordingFloatingButtonPosition(getVideoRecordingButtonCorner(corner));
376377
} catch (Exception e) {
377378
e.printStackTrace();
378379
}
@@ -1302,16 +1303,25 @@ public void onReportCreated(Report report) {
13021303
@ReactMethod
13031304
public void setPostInvocationHandler(final Callback postInvocationHandler) {
13041305
try {
1305-
BugReporting.setOnDismissCallback(new OnSdkDismissCallback() {
1306-
@Override
1307-
public void call() {
1308-
// WritableMap params = Arguments.createMap();
1309-
// params.putString("issueState", issueState.toString());
1310-
// params.putString("bugType", bugType.toString());
1311-
sendEvent(getReactApplicationContext(), "IBGpostInvocationHandler", null);
1312-
}
1313-
});
1314-
1306+
// BugReporting.setOnDismissCallback(new OnSdkDismissCallback() {
1307+
// @Override
1308+
// public void call() {
1309+
//// WritableMap params = Arguments.createMap();
1310+
//// params.putString("issueState", issueState.toString());
1311+
//// params.putString("bugType", bugType.toString());
1312+
// sendEvent(getReactApplicationContext(), "IBGpostInvocationHandler", null);
1313+
// }
1314+
// });
1315+
1316+
BugReporting.setOnDismissCallback(new OnSdkDismissCallback() {
1317+
@Override
1318+
public void call(DismissType dismissType, ReportType reportType) {
1319+
WritableMap params = Arguments.createMap();
1320+
params.putString("issueState", dismissType.toString());
1321+
params.putString("bugType", reportType.toString());
1322+
sendEvent(getReactApplicationContext(), "IBGpostInvocationHandler", null);
1323+
}
1324+
});
13151325
} catch (java.lang.Exception exception) {
13161326
exception.printStackTrace();
13171327
}
@@ -1762,17 +1772,17 @@ private InstabugCustomTextPlaceHolder.Key getStringToKeyConstant(String key) {
17621772
}
17631773
}
17641774

1765-
private InstabugVideoRecordingButtonCorner getVideoRecordingButtonCorner(String cornerValue) {
1766-
InstabugVideoRecordingButtonCorner corner = InstabugVideoRecordingButtonCorner.BOTTOM_RIGHT;
1775+
private InstabugVideoRecordingButtonPosition getVideoRecordingButtonCorner(String cornerValue) {
1776+
InstabugVideoRecordingButtonPosition corner = InstabugVideoRecordingButtonPosition.BOTTOM_RIGHT;
17671777
try {
17681778
if (cornerValue.equals(BOTTOM_RIGHT)) {
1769-
corner = InstabugVideoRecordingButtonCorner.BOTTOM_RIGHT;
1779+
corner = InstabugVideoRecordingButtonPosition.BOTTOM_RIGHT;
17701780
} else if (cornerValue.equals(BOTTOM_LEFT)) {
1771-
corner = InstabugVideoRecordingButtonCorner.BOTTOM_LEFT;
1781+
corner = InstabugVideoRecordingButtonPosition.BOTTOM_LEFT;
17721782
} else if (cornerValue.equals(TOP_LEFT)) {
1773-
corner = InstabugVideoRecordingButtonCorner.TOP_LEFT;
1783+
corner = InstabugVideoRecordingButtonPosition.TOP_LEFT;
17741784
} else if (cornerValue.equals(TOP_RIGHT)) {
1775-
corner = InstabugVideoRecordingButtonCorner.TOP_RIGHT;
1785+
corner = InstabugVideoRecordingButtonPosition.TOP_RIGHT;
17761786
}
17771787

17781788
} catch (Exception e) {

0 commit comments

Comments
 (0)