Skip to content

Commit 50219f6

Browse files
author
Ali Abdelfattah
authored
Merge pull request #614 from Instabug/fix/parseErrorStack-HermesSupport
Fix/parse error stack hermes support
2 parents 13af816 + 9d407b1 commit 50219f6

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed

modules/CrashReporting.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,8 @@ export default {
2424
* @param errorObject Error object to be sent to Instabug's servers
2525
*/
2626
reportJSException: function(errorObject) {
27-
let jsStackTrace = InstabugUtils.parseErrorStack(errorObject);
27+
let jsStackTrace = InstabugUtils.getStackTrace(errorObject);
28+
2829
var jsonObject = {
2930
message: errorObject.name + ' - ' + errorObject.message,
3031
os: Platform.OS,

utils/InstabugUtils.js

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,21 @@ function getFullRoute(state) {
4040
}
4141
}
4242

43+
export const getStackTrace = (e) => {
44+
let jsStackTrace;
45+
if (Platform.hasOwnProperty("constants")) {
46+
// RN version >= 0.63
47+
if (Platform.constants.reactNativeVersion.minor >= 64)
48+
// RN version >= 0.64 -> Stacktrace as string
49+
jsStackTrace = parseErrorStackLib(e.stack);
50+
// RN version == 0.63 -> Stacktrace as string
51+
else jsStackTrace = parseErrorStackLib(e);
52+
}
53+
// RN version < 0.63 -> Stacktrace as string
54+
else jsStackTrace = parseErrorStackLib(e);
55+
return jsStackTrace;
56+
};
57+
4358
export const isOnReportHandlerSet = () => {
4459
return _isOnReportHandlerSet;
4560
};
@@ -52,7 +67,7 @@ export const captureJsErrors = () => {
5267
}
5368

5469
function errorHandler(e, isFatal) {
55-
let jsStackTrace = parseErrorStackLib(e);
70+
let jsStackTrace = getStackTrace(e);
5671

5772
//JSON object to be sent to the native SDK
5873
var jsonObject = {
@@ -91,5 +106,6 @@ export default {
91106
setOnReportHandler,
92107
isOnReportHandlerSet,
93108
getActiveRouteName,
94-
getFullRoute
109+
getFullRoute,
110+
getStackTrace,
95111
};

0 commit comments

Comments
 (0)