Skip to content

Commit 5e9084a

Browse files
Merge pull request #532 from Instabug/fix/setSdkDebugLogsLevel
Fix setSdkDebugLogsLevel crashing on Android
2 parents 475d8ba + 57eb79a commit 5e9084a

File tree

3 files changed

+16
-18
lines changed

3 files changed

+16
-18
lines changed

.circleci/config.yml

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -14,24 +14,8 @@ jobs:
1414
- checkout:
1515
path: ~/project
1616

17-
- restore_cache:
18-
key: yarn-v1-{{ checksum "yarn.lock" }}-{{ arch }}
19-
20-
- restore_cache:
21-
key: node-v1-{{ checksum "package.json" }}-{{ arch }}
22-
2317
- run: yarn
2418

25-
- save_cache:
26-
key: yarn-v1-{{ checksum "yarn.lock" }}-{{ arch }}
27-
paths:
28-
- ~/.cache/yarn
29-
30-
- save_cache:
31-
key: node-v1-{{ checksum "package.json" }}-{{ arch }}
32-
paths:
33-
- node_modules
34-
3519
- run:
3620
name: jest tests
3721
command: |

__tests__/index.spec.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ describe('Instabug Module', () => {
7474
setIBGLogPrintsToConsole.resetHistory();
7575
setPushNotificationsEnabled.resetHistory();
7676
log.resetHistory();
77+
setSdkDebugLogsLevel.resetHistory();
7778
setDebugEnabled.resetHistory();
7879
enable.resetHistory();
7980
disable.resetHistory();
@@ -367,13 +368,24 @@ describe('Instabug Module', () => {
367368

368369
});
369370

370-
it('should call the native method setSdkDebugLogsLevel', () => {
371+
it('should call the native method setSdkDebugLogsLevel on iOS', () => {
371372
const debugLevel = Instabug.sdkDebugLogsLevel.sdkDebugLogsLevelVerbose;
373+
374+
Platform.OS = 'ios';
372375
Instabug.setSdkDebugLogsLevel(debugLevel);
373376

374377
expect(setSdkDebugLogsLevel.calledOnceWithExactly(debugLevel)).toBe(true);
375378
});
376379

380+
it('should not call the native method setSdkDebugLogsLevel on Android', () => {
381+
const debugLevel = Instabug.sdkDebugLogsLevel.sdkDebugLogsLevelVerbose;
382+
383+
Platform.OS = 'android';
384+
Instabug.setSdkDebugLogsLevel(debugLevel);
385+
386+
expect(setSdkDebugLogsLevel.notCalled).toBe(true);
387+
});
388+
377389
it('should call the native method setUserAttribute', () => {
378390

379391
const key = 'age';

index.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,9 @@ const InstabugModule = {
165165
*
166166
*/
167167
setSdkDebugLogsLevel(sdkDebugLogsLevel) {
168-
Instabug.setSdkDebugLogsLevel(sdkDebugLogsLevel);
168+
if (Platform.OS === 'ios') {
169+
Instabug.setSdkDebugLogsLevel(sdkDebugLogsLevel);
170+
}
169171
},
170172

171173
/* istanbul ignore next */

0 commit comments

Comments
 (0)