Return a Promise from APM.startExecutionTrace

Author: AliAbdelfattah

android/src/main/java/com/instabug/reactlibrary/RNInstabugAPMModule.java

@@ -112,13 +112,18 @@ public void run() {
      * @param name string name of the trace.
      */
     @ReactMethod
-    public void startExecutionTrace(final String name, final String id) {
+    public void startExecutionTrace(final String name, final String id, final Callback callback) {
         MainThreadHandler.runOnMainThread(new Runnable() {
             @Override
             public void run() {
                 try {
+                    String result = "";
                     ExecutionTrace trace = APM.startExecutionTrace(name);
-                    traces.put(id,trace);
+                    if (trace == null) {
+                        result = id;
+                        traces.put(id, trace);
+                    }
+                    callback.invoke(result);
                 } catch (Exception e) {
                     e.printStackTrace();
                 }

ios/RNInstabug/InstabugAPMBridge.m

@@ -62,10 +62,13 @@ - (id) init
     IBGAPM.autoUITraceEnabled = isEnabled;
 }
 
-RCT_EXPORT_METHOD(startExecutionTrace:(NSString *)name :(NSString *)id) {
+RCT_EXPORT_METHOD(startExecutionTrace:(NSString *)name :(NSString *)id:(RCTResponseSenderBlock)callBack) {
     IBGExecutionTrace *trace = [IBGAPM startExecutionTraceWithName:name];
     if (trace != nil) {
         [traces setObject: trace forKey: id];
+        callBack(@[id]);
+    } else {
+        callBack(@[[NSNull null]]);
     }
 }
 

modules/APM.js

@@ -77,12 +77,22 @@ export default {
 
     /**
      * Starts a custom trace
+     * Returns a promise, the promise delivers the trace reference if APM is enabled, otherwise it gets rejected
      * @param {string} name 
      */
     startExecutionTrace(name) {
-        const id = Date.now() + '';
-        IBGAPM.startExecutionTrace(name, id);
-        return new Trace(id, name);
+        const TRACE_NOT_STARTED_APM_NOT_ENABLED = `Execution trace "${name}" wasn't created. Please make sure to enable APM first by following the instructions at this link: https://docs.instabug.com/reference#enable-or-disable-apm`;
+        const timestamp = Date.now() + '';
+
+        return new Promise((resolve, reject) => {
+            IBGAPM.startExecutionTrace(name, timestamp, (id) => {
+                if (id) {
+                    resolve(new Trace(id, name));
+                } else {
+                    reject(new Error(TRACE_NOT_STARTED_APM_NOT_ENABLED));
+                }
+            });
+        });
     },
 
     /**