[INSD-7130] Change eval to Function for expression evaluation (#705)

* Change eval to Function for expression evaluation

This change was needed for setRequestFilterExpression API to work with
Hermes enabled as Hermes doesn't support eval.

* Update CHANGELOG.md

* Use let instead of var

Co-authored-by: Ali Abdelfattah <[email protected]>

Author: DavidMina96

CHANGELOG.md

@@ -2,6 +2,7 @@
 
 * Adds the ability to opt out of iOS source maps auto upload through the INSTABUG_SOURCEMAPS_UPLOAD_DISABLE env variable
 * Adds dynamic entry file support through the INSTABUG_ENTRY_FILE env variable
+* Fixes an issue with setRequestFilterExpression API not working with Hermes
 * Fixes an issue with swipe invocation event not working on Android
 * Breaking: Removes the deprecated APIs. For the full list, check PR #703
 

modules/NetworkLogger.js

@@ -21,7 +21,8 @@ export default {
     if (isEnabled) {
       xhr.enableInterception();
       xhr.setOnDoneCallback(network => {
-        if (!eval(_requestFilterExpression)) {
+        let predicate = Function('network', 'return ' + _requestFilterExpression);
+        if (!predicate(network)) {
           if (_networkDataObfuscationHandlerSet) {
             IBGEventEmitter.emit(
               InstabugConstants.NETWORK_DATA_OBFUSCATION_HANDLER_EVENT,