[MOB-8853] Dynamic Package Path (#678)

* Pass base dir from Gradle to upload_sourcemap.sh

* Use absolute module import for parseErrorStackLib

* Use absolute path for iOS upload_sourcemap.sh

* Pass Android rootDir to upload_sourcemap as an arg

* Use `rootDir` instead of `System.getProperty('user.dir')`.
* Pass the path to user's Android directory (`rootDir`) as an argument to `upload_sourcemap.sh` instead of using environment variables
* Remove the check for the user's Android directory path in `upload_sourcemap.sh` as it's passed from Gradle

* Get `link_bridge.js` path dynamically on linking

* Fix manual linking paths

* Import `package.json` from relative file path instead of a module import
* Dynamically get `link.rb` file path

Author: a7medev

android/build.gradle

@@ -45,7 +45,7 @@ task upload_sourcemap(type: Exec) {
         commandLine 'cmd', '/c', 'echo Automatic Upload of sourcemap files is currently not available on windows, please generate the sourcemapfiles and upload them to the dashboard'
         project.logger.lifecycle('Automatic Upload of sourcemap files is currently not available on windows, please generate the sourcemapfiles and upload them to the dashboard')
     } else {
-        commandLine 'sh', './upload_sourcemap.sh'
+        commandLine 'sh', './upload_sourcemap.sh', rootDir
     }
 }
 

android/upload_sourcemap.sh

@@ -1,7 +1,7 @@
 #!/bin/sh
-cd ..
-cd ..
-cd ..
+USER_ANDROID_DIR=$1
+cd "${USER_ANDROID_DIR}/.."
+
 if [ -s "$HOME/.nvm/nvm.sh" ]; then
 . "$HOME/.nvm/nvm.sh"
 elif [[ -x "$(command -v brew)" && -s "$(brew --prefix nvm)/nvm.sh" ]]; then

link.rb

@@ -10,18 +10,19 @@
 end
 
 # Replace these with your values
+sdk_path = File.dirname(File.realpath(__FILE__))
 current_path = Dir.pwd
 project_path = Dir.glob("#{current_path}/ios/*.xcodeproj").first
 file_name = File.basename(project_path, ".xcodeproj")
 project_location = "./ios/#{file_name}.xcodeproj"
 default_target_name = file_name
-framework_root = "../node_modules/#{package["name"]}/ios"
+framework_root = "#{sdk_path}/ios"
 framework_name = 'Instabug.xcframework'
 
 INSTABUG_UPLOAD_NAME = "Upload Sourcemap"
 
 INSTABUG_UPLOAD_SCRIPT = <<-SCRIPTEND
-bash "../node_modules/#{package["name"]}/ios/upload_sourcemap.sh"
+bash "#{sdk_path}/ios/upload_sourcemap.sh"
 SCRIPTEND
 
 # Get useful variables

link_bridge.js

@@ -1,4 +1,5 @@
-const package = require('package.json');
+const package = require('./package.json');
+const path = require('path');
 const exec = require('child_process').exec;
 require('./link_gradle');
-exec(`ruby ./node_modules/${package.name}/link.rb || echo \"Ruby doesn't exist, if you're building this for Android only, then feel free to ignore this error, otherwise please install Ruby and run 'react-native link ${package.name}' again\"`);
+exec(`ruby ${path.resolve(__dirname, 'link.rb')} || echo \"Ruby doesn't exist, if you're building this for Android only, then feel free to ignore this error, otherwise please install Ruby and run 'react-native link ${package.name}' again\"`);

react-native.config.js

@@ -1,34 +1,35 @@
+const path = require('path');
+
 module.exports = {
   dependency: {
     platforms: {
       ios: {
         scriptPhases: [
           {
             name: '[instabug-reactnative] Upload Sourcemap',
-            script: 'bash "../node_modules/instabug-reactnative/ios/upload_sourcemap.sh"',
+            script: `bash "${path.resolve(__dirname, 'ios/upload_sourcemap.sh')}"`,
             execution_position: 'after_compile',
           },
         ],
       },
-      android: {
-      },
+      android: {},
     },
     hooks: {
-      postlink: 'node node_modules/instabug-reactnative/link_bridge.js'
+      postlink: `node ${path.resolve(__dirname, 'link_bridge.js')}`,
     },
   },
   commands: [
     {
       name: 'add-instabug',
       func: () => {
-                    require('./link_gradle');
-                  },
+        require('./link_gradle');
+      },
     },
     {
       name: 'remove-instabug',
       func: () => {
-                    require('./unlink_gradle');
-                  },
+        require('./unlink_gradle');
+      },
     },
   ],
-};
+};

utils/InstabugUtils.js

@@ -3,7 +3,7 @@ import { NativeModules, Platform } from 'react-native';
 let { Instabug } = NativeModules;
 import IBGEventEmitter from './IBGEventEmitter';
 import InstabugConstants from './InstabugConstants';
-import parseErrorStackLib from '../../react-native/Libraries/Core/Devtools/parseErrorStack.js';
+import parseErrorStackLib from 'react-native/Libraries/Core/Devtools/parseErrorStack';
 
 export const parseErrorStack = (error) => {
   return parseErrorStackLib(error);