Skip to content

Commit efae20d

Browse files
chore: fix request filtering handler in iOS
1 parent f0cf691 commit efae20d

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

ios/RNInstabug/InstabugNetworkLoggerBridge.m

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -227,18 +227,12 @@ -(void)stopObserving {
227227

228228
RCT_EXPORT_METHOD(setNetworkLoggingRequestFilterPredicateIOS: (NSString * _Nonnull) callbackID : (BOOL)value ){
229229

230-
// NSPredicate *requestPredicate = [NSPredicate predicateWithValue:(value) ? YES : NO];
231-
232-
233230
if ([callbackID isKindOfClass:[NSString class]] && self.requestFilteringCompletionDictionary[callbackID] != nil) {
234231
// ⬇️ YES == Request will be saved, NO == will be ignored
235-
((IBGURLRequestResponseAsyncFilteringCompletedHandler)self.requestFilteringCompletionDictionary[callbackID])(YES);
232+
((IBGURLRequestResponseAsyncFilteringCompletedHandler)self.requestFilteringCompletionDictionary[callbackID])(value);
236233
} else {
237234
NSLog(@"Not Available Completion");
238235
}
239-
240-
241-
// [IBGNetworkLogger setNetworkLoggingRequetFilterPredicate:requestPredicate responseFilterPredicate:nil];
242236
}
243237

244238

src/modules/NetworkLogger.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,9 +112,10 @@ export const setRequestFilterExpression = (expression: string) => {
112112
const predicate = Function('network', 'return ' + _requestFilterExpression);
113113
const value = predicate(networkSnapshot);
114114
if (Platform.OS === 'ios') {
115-
NativeNetworkLogger.setNetworkLoggingRequestFilterPredicateIOS(networkSnapshot.id, value);
115+
// For iOS True == Request will be saved, False == will be ignored
116+
NativeNetworkLogger.setNetworkLoggingRequestFilterPredicateIOS(networkSnapshot.id, !value);
116117
} else {
117-
// set android request url to null ;
118+
// For Android Setting the passed data to empty string will ignore the request;
118119
if (value) {
119120
NativeNetworkLogger.updateNetworkLogSnapshot('');
120121
}

0 commit comments

Comments
 (0)