feat: handle remaining rubocop offenses

Author: Yousif-Ahmed

fastlane-plugin-instabug-stores-upload.gemspec

@@ -17,12 +17,12 @@ Gem::Specification.new do |spec|
   spec.metadata['rubygems_mfa_required'] = 'true'
   spec.required_ruby_version = '>= 3.2.2'
 
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'rubocop', '1.50.2'
-  spec.add_development_dependency 'rubocop-performance'
-  spec.add_development_dependency 'rubocop-require_tools'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'fastlane', '~> 2.228.0'
+  spec.add_development_dependency('bundler')
+  spec.add_development_dependency('fastlane', '~> 2.228.0')
+  spec.add_development_dependency('rake')
+  spec.add_development_dependency('rspec')
+  spec.add_development_dependency('rubocop', '1.50.2')
+  spec.add_development_dependency('rubocop-performance')
+  spec.add_development_dependency('rubocop-require_tools')
+  spec.add_development_dependency('simplecov')
 end

lib/fastlane/plugin/instabug_stores_upload/actions/instabug_upload_to_app_store_action.rb

@@ -6,20 +6,20 @@ module Actions
     class InstabugUploadToAppStoreAction < Action
       def self.run(params)
         UI.message("Starting Instabug App Store upload...")
-        
+
         # Extract Instabug-specific parameters
         branch_name = params.delete(:branch_name)
         instabug_api_key = params.delete(:instabug_api_key)
-        
+
         # Validate required parameters
         if branch_name.nil? || branch_name.empty?
           UI.user_error!("branch_name is required for Instabug reporting")
         end
-        
+
         begin
           # Report upload start to Instabug
           Helper::InstabugStoresUploadHelper.report_status(
-            branch_name: branch_name,
+            branch_name:,
             api_key: instabug_api_key,
             status: "inprogress",
             step: "upload_to_the_store"
@@ -30,23 +30,24 @@ def self.run(params)
 
           # Report upload success to Instabug
           Helper::InstabugStoresUploadHelper.report_status(
-            branch_name: branch_name,
+            branch_name:,
             api_key: instabug_api_key,
             status: "success",
             step: "upload_to_the_store"
           )
 
           UI.success("App Store upload completed successfully!")
           result
-        rescue => e
+        rescue StandardError => e
           UI.error("App Store upload failed: #{e.message}")
 
           # Report upload failure to Instabug
           Helper::InstabugStoresUploadHelper.report_status(
-            branch_name: branch_name,
+            branch_name:,
             api_key: instabug_api_key,
             status: "failure",
-            step: "upload_to_the_store"
+            step: "upload_to_the_store",
+            error_message: e.message
           )
           raise e
         end
@@ -71,7 +72,7 @@ def self.details
       def self.available_options
         # Start with the original upload_to_app_store options
         options = Actions::UploadToAppStoreAction.available_options
-        
+
         # Add Instabug-specific options
         instabug_options = [
           FastlaneCore::ConfigItem.new(
@@ -88,9 +89,9 @@ def self.available_options
             optional: false,
             type: String,
             sensitive: true
-          ) 
+          )
         ]
-        
+
         # Combine both sets of options
         options + instabug_options
       end
@@ -116,4 +117,4 @@ def self.category
       end
     end
   end
-end 
+end

lib/fastlane/plugin/instabug_stores_upload/actions/instabug_upload_to_play_store_action.rb

@@ -6,7 +6,7 @@ module Actions
     class InstabugUploadToPlayStoreAction < Action
       def self.run(params)
         UI.message("Starting Instabug Play Store upload...")
-        
+
         # Extract Instabug-specific parameters
         branch_name = params.delete(:branch_name)
         instabug_api_key = params.delete(:instabug_api_key)
@@ -19,35 +19,35 @@ def self.run(params)
         begin
           # Report upload start to Instabug
           Helper::InstabugStoresUploadHelper.report_status(
-            branch_name: branch_name,
+            branch_name:,
             api_key: instabug_api_key,
             status: "inprogress",
             step: "upload_to_the_store"
           )
 
           # Execute the actual upload to Play Store
           result = Actions::UploadToPlayStoreAction.run(params)
-          
+
           # Report upload success to Instabug
           Helper::InstabugStoresUploadHelper.report_status(
-            branch_name: branch_name,
+            branch_name:,
             api_key: instabug_api_key,
             status: "success",
             step: "upload_to_the_store"
           )
-          
+
           UI.success("Play Store upload completed successfully!")
           result
-          
-        rescue => e
+        rescue StandardError => e
           UI.error("Play Store upload failed: #{e.message}")
 
           # Report upload failure to Instabug
           Helper::InstabugStoresUploadHelper.report_status(
-            branch_name: branch_name,
+            branch_name:,
             api_key: instabug_api_key,
             status: "failure",
-            step: "upload_to_the_store"
+            step: "upload_to_the_store",
+            error_message: e.message
           )
           raise e
         end
@@ -72,7 +72,7 @@ def self.details
       def self.available_options
         # Start with the original upload_to_play_store options
         options = Actions::UploadToPlayStoreAction.available_options
-        
+
         # Add Instabug-specific options
         instabug_options = [
           FastlaneCore::ConfigItem.new(
@@ -91,7 +91,7 @@ def self.available_options
             sensitive: true
           )
         ]
-        
+
         # Combine both sets of options
         options + instabug_options
       end
@@ -118,4 +118,4 @@ def self.category
       end
     end
   end
-end 
+end

spec/instabug_upload_to_app_store_action_spec.rb

@@ -32,7 +32,9 @@
             body: {
               branch_name: 'crash-fix/instabug-crash-123',
               status: 'inprogress',
-              step: 'upload_to_the_store'
+              step: 'upload_to_the_store',
+              extras: {},
+              error_message: nil
             }.to_json,
             headers: {
               'Content-Type' => 'application/json',
@@ -46,7 +48,9 @@
             body: {
               branch_name: 'crash-fix/instabug-crash-123',
               status: 'success',
-              step: 'upload_to_the_store'
+              step: 'upload_to_the_store',
+              extras: {},
+              error_message: nil
             }.to_json,
             headers: {
               'Content-Type' => 'application/json',
@@ -63,16 +67,18 @@
         expect(Fastlane::Actions::UploadToAppStoreAction).to receive(:run)
           .and_raise(error)
 
-        expect {
+        expect do
           described_class.run(valid_params)
-        }.to raise_error(StandardError, 'Upload failed')
+        end.to raise_error(StandardError, 'Upload failed')
 
         expect(WebMock).to have_requested(:patch, api_endpoint)
           .with(
             body: {
               branch_name: 'crash-fix/instabug-crash-123',
               status: 'failure',
-              step: 'upload_to_the_store'
+              step: 'upload_to_the_store',
+              extras: {},
+              error_message: 'Upload failed'
             }.to_json
           )
       end
@@ -82,26 +88,26 @@
       it 'raises user error' do
         params = valid_params.merge(branch_name: nil)
 
-        expect {
+        expect do
           described_class.run(params)
-        }.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
+        end.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
       end
     end
 
     context 'when branch_name is empty' do
       it 'raises user error' do
         params = valid_params.merge(branch_name: '')
 
-        expect {
+        expect do
           described_class.run(params)
-        }.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
+        end.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
       end
     end
 
     context 'when branch name does not match instabug pattern' do
       it 'does not make API calls but still runs upload' do
         params = valid_params.merge(branch_name: 'feature/new-feature')
-        
+
         expect(Fastlane::Actions::UploadToAppStoreAction).to receive(:run)
           .and_return('upload_result')
 
@@ -128,4 +134,4 @@
       expect(described_class.category).to eq(:app_store_connect)
     end
   end
-end 
+end

spec/instabug_upload_to_play_store_action_spec.rb

@@ -33,7 +33,9 @@
             body: {
               branch_name: 'crash-fix/instabug-crash-456',
               status: 'inprogress',
-              step: 'upload_to_the_store'
+              step: 'upload_to_the_store',
+              extras: {},
+              error_message: nil
             }.to_json,
             headers: {
               'Content-Type' => 'application/json',
@@ -47,7 +49,9 @@
             body: {
               branch_name: 'crash-fix/instabug-crash-456',
               status: 'success',
-              step: 'upload_to_the_store'
+              step: 'upload_to_the_store',
+              extras: {},
+              error_message: nil
             }.to_json,
             headers: {
               'Content-Type' => 'application/json',
@@ -64,16 +68,18 @@
         expect(Fastlane::Actions::UploadToPlayStoreAction).to receive(:run)
           .and_raise(error)
 
-        expect {
+        expect do
           described_class.run(valid_params)
-        }.to raise_error(StandardError, 'Upload failed')
+        end.to raise_error(StandardError, 'Upload failed')
 
         expect(WebMock).to have_requested(:patch, api_endpoint)
           .with(
             body: {
               branch_name: 'crash-fix/instabug-crash-456',
               status: 'failure',
-              step: 'upload_to_the_store'
+              step: 'upload_to_the_store',
+              extras: {},
+              error_message: 'Upload failed'
             }.to_json
           )
       end
@@ -83,26 +89,26 @@
       it 'raises user error' do
         params = valid_params.merge(branch_name: nil)
 
-        expect {
+        expect do
           described_class.run(params)
-        }.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
+        end.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
       end
     end
 
     context 'when branch_name is empty' do
       it 'raises user error' do
         params = valid_params.merge(branch_name: '')
 
-        expect {
+        expect do
           described_class.run(params)
-        }.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
+        end.to raise_error(FastlaneCore::Interface::FastlaneError, 'branch_name is required for Instabug reporting')
       end
     end
 
     context 'when branch name does not match instabug pattern' do
       it 'does not make API calls but still runs upload' do
         params = valid_params.merge(branch_name: 'feature/new-feature')
-        
+
         expect(Fastlane::Actions::UploadToPlayStoreAction).to receive(:run)
           .and_return('upload_result')
 
@@ -129,4 +135,4 @@
       expect(described_class.category).to eq(:google_play_console)
     end
   end
-end 
+end