Skip to content

Commit d1690fe

Browse files
committed
feat: Handling rubcop to be used normally for formatting out plugin
1 parent a475122 commit d1690fe

File tree

3 files changed

+24
-19
lines changed

3 files changed

+24
-19
lines changed

.rubocop.yml

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ require:
33
- rubocop/require_tools
44
- rubocop-performance
55
AllCops:
6-
TargetRubyVersion: 2.6
6+
TargetRubyVersion: 3.2.2
77
NewCops: enable
88
Include:
99
- "**/*.rb"
@@ -70,6 +70,7 @@ Require/MissingRequireStatement:
7070
- "**/Rakefile"
7171
- fastlane/**/*
7272
- supply/**/*
73+
- "lib/fastlane/plugin/**/*.rb"
7374
Layout/FirstHashElementIndentation:
7475
Enabled: false
7576
Layout/HashAlignment:
@@ -87,6 +88,8 @@ Style/MixinGrouping:
8788
- "**/spec/**/*"
8889
Lint/SuppressedException:
8990
Enabled: false
91+
Lint/IneffectiveAccessModifier:
92+
Enabled: false
9093
Lint/UnusedBlockArgument:
9194
Enabled: false
9295
Lint/AmbiguousBlockAssociation:
@@ -120,6 +123,8 @@ Layout/LineLength:
120123
Max: 370
121124
Metrics/ParameterLists:
122125
Max: 17
126+
Metrics/PerceivedComplexity:
127+
Max: 10
123128
Style/GuardClause:
124129
Enabled: false
125130
Style/StringLiterals:
@@ -192,5 +197,4 @@ Bundler/OrderedGems:
192197
Enabled: true
193198
TreatCommentsAsGroupSeparators: false
194199
Gemspec/DevelopmentDependencies:
195-
Enabled: true
196-
EnforcedStyle: Gemfile
200+
Enabled: false

fastlane-plugin-instabug-stores-upload.gemspec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
2121
spec.add_development_dependency 'rspec'
2222
spec.add_development_dependency 'rake'
2323
spec.add_development_dependency 'rubocop', '1.50.2'
24+
spec.add_development_dependency 'rubocop-performance'
2425
spec.add_development_dependency 'rubocop-require_tools'
2526
spec.add_development_dependency 'simplecov'
2627
spec.add_development_dependency 'fastlane', '~> 2.228.0'

fastlane/Fastfile

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,10 @@
33
# Example lane for building iOS app with Instabug reporting
44
lane :build_ios_app do |options|
55
branch_name = options[:branch_name]
6-
6+
77
instabug_build_ios_app(
8-
branch_name: branch_name,
9-
instabug_api_key: ENV["INSTABUG_API_KEY"],
8+
branch_name:,
9+
instabug_api_key: ENV.fetch("INSTABUG_API_KEY", nil),
1010
# All standard build_ios_app parameters are supported
1111
workspace: "MyApp.xcworkspace",
1212
scheme: "MyApp",
@@ -18,42 +18,42 @@ end
1818
# Example lane for building Android app with Instabug reporting
1919
lane :build_android_app do |options|
2020
branch_name = options[:branch_name]
21-
21+
2222
instabug_build_android_app(
23-
branch_name: branch_name,
24-
instabug_api_key: ENV["INSTABUG_API_KEY"],
23+
branch_name:,
24+
instabug_api_key: ENV.fetch("INSTABUG_API_KEY", nil),
2525
# All standard gradle parameters are supported
2626
task: "assembleRelease",
2727
project_dir: "android/",
2828
properties: {
2929
"android.injected.signing.store.file" => "keystore.jks",
30-
"android.injected.signing.store.password" => ENV["KEYSTORE_PASSWORD"],
30+
"android.injected.signing.store.password" => ENV.fetch("KEYSTORE_PASSWORD", nil),
3131
"android.injected.signing.key.alias" => "key0",
32-
"android.injected.signing.key.password" => ENV["KEY_PASSWORD"]
32+
"android.injected.signing.key.password" => ENV.fetch("KEY_PASSWORD", nil)
3333
}
3434
)
3535
end
3636

3737
# Example lane for uploading to App Store with Instabug reporting
3838
lane :upload_to_app_store do |options|
3939
branch_name = options[:branch_name]
40-
40+
4141
instabug_upload_to_app_store(
42-
branch_name: branch_name,
43-
instabug_api_key: ENV["INSTABUG_API_KEY"],
42+
branch_name:,
43+
instabug_api_key: ENV.fetch("INSTABUG_API_KEY", nil),
4444
# All standard upload_to_app_store parameters are supported
4545
ipa: "path/to/your/app.ipa",
4646
skip_waiting_for_build_processing: true
4747
)
4848
end
4949

50-
# Example lane for uploading to Play Store with Instabug reporting
50+
# Example lane for uploading to Play Store with Instabug reporting
5151
lane :upload_to_play_store do |options|
52-
branch_name = options[:branch_name]
53-
52+
branch_name = options[:branch_name]
53+
5454
instabug_upload_to_play_store(
55-
branch_name: branch_name,
56-
instabug_api_key: ENV["INSTABUG_API_KEY"],
55+
branch_name:,
56+
instabug_api_key: ENV.fetch("INSTABUG_API_KEY", nil),
5757
# All standard upload_to_play_store parameters are supported
5858
aab: "path/to/your/app.aab",
5959
track: "internal"

0 commit comments

Comments
 (0)