Merge branch 'seuros-more'

sqrrrl · sqrrrl · commit d6d8ec788463 · 2014-12-15T11:54:03.000-08:00
diff --git a/.travis.yml b/.travis.yml
@@ -1,14 +1,10 @@
 language: ruby
 rvm:
-  - 1.8.7
-  - 1.9.2
   - 1.9.3
   - 2.0.0
   - 2.1.0
   - rbx-2
-  - jruby-18mode
   - jruby-19mode
-  - ree
 script: "bundle exec rake spec:all"
 before_install:
  - sudo apt-get update
diff --git a/google-api-client.gemspec b/google-api-client.gemspec
@@ -26,12 +26,12 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'signet', '~> 0.6'
   s.add_runtime_dependency 'faraday', '~> 0.9'
   s.add_runtime_dependency 'multi_json', '~> 1.10'
-  s.add_runtime_dependency 'uuidtools', "~> 2.1"
   s.add_runtime_dependency 'autoparse', "~> 0.3"
   s.add_runtime_dependency 'extlib', '~> 0.9'
   s.add_runtime_dependency 'launchy', '~> 2.4'
   s.add_runtime_dependency 'retriable', '~> 1.4'
-
+  s.add_runtime_dependency 'activesupport', '~> 3.2'
+  
   s.add_development_dependency 'rake', '~> 10.0'
   s.add_development_dependency 'yard', '~> 0.8'
   s.add_development_dependency 'rspec', '~> 3.1'
diff --git a/lib/google/api_client.rb b/lib/google/api_client.rb
@@ -32,7 +32,7 @@
 require 'google/api_client/batch'
 require 'google/api_client/gzip'
 require 'google/api_client/client_secrets'
-require 'google/api_client/railtie' if defined?(Rails::Railtie)
+require 'google/api_client/railtie' if defined?(Rails)
 
 module Google
 
@@ -692,5 +692,3 @@ def client_error_handler(authorization)
   end
 
 end
-
-require 'google/api_client/version'
diff --git a/lib/google/api_client/auth/file_storage.rb b/lib/google/api_client/auth/file_storage.rb
@@ -42,7 +42,7 @@ def initialize(path)
       ##
       # Attempt to read in credentials from the specified file.
       def load_credentials
-        if File.exist? self.path
+        if File.exists? self.path
           File.open(self.path, 'r') do |file|
             cached_credentials = JSON.load(file)
             @authorization = Signet::OAuth2::Client.new(cached_credentials)
diff --git a/lib/google/api_client/batch.rb b/lib/google/api_client/batch.rb
@@ -14,7 +14,7 @@
 
 require 'addressable/uri'
 require 'google/api_client/reference'
-require 'uuidtools'
+require 'securerandom'
 
 module Google
   class APIClient
@@ -90,8 +90,7 @@ def initialize(options = {}, &block)
         @global_callback = block if block_given?
         @last_auto_id = 0
         
-        # TODO(sgomes): Use SecureRandom.uuid, drop UUIDTools when we drop 1.8
-        @base_id = UUIDTools::UUID.random_create.to_s
+        @base_id = SecureRandom.uuid
 
         options[:uri] ||= 'https://www.googleapis.com/batch'
         options[:http_method] ||= 'POST'
diff --git a/lib/google/api_client/client_secrets.rb b/lib/google/api_client/client_secrets.rb
@@ -13,7 +13,6 @@
 # limitations under the License.
 
 
-require 'multi_json'
 require 'compat/multi_json'
 
 
@@ -63,7 +62,7 @@ def self.load(filename=nil)
         end
         while filename == nil
           search_path ||= File.expand_path('.')
-          if File.exist?(File.join(search_path, 'client_secrets.json'))
+          if File.exists?(File.join(search_path, 'client_secrets.json'))
             filename = File.join(search_path, 'client_secrets.json')
           elsif search_path == '/' || search_path =~ /[a-zA-Z]:[\/\\]/
             raise ArgumentError,
diff --git a/lib/google/api_client/discovery/api.rb b/lib/google/api_client/discovery/api.rb
@@ -15,7 +15,7 @@
 
 require 'addressable/uri'
 require 'multi_json'
-require 'google/inflection'
+require 'active_support/inflector'
 require 'google/api_client/discovery/resource'
 require 'google/api_client/discovery/method'
 require 'google/api_client/discovery/media'
@@ -41,13 +41,13 @@ def initialize(document_base, discovery_document)
         @discovery_document = discovery_document
         metaclass = (class << self; self; end)
         self.discovered_resources.each do |resource|
-          method_name = Google::INFLECTOR.underscore(resource.name).to_sym
+          method_name = ActiveSupport::Inflector.underscore(resource.name).to_sym
           if !self.respond_to?(method_name)
             metaclass.send(:define_method, method_name) { resource }
           end
         end
         self.discovered_methods.each do |method|
-          method_name = Google::INFLECTOR.underscore(method.name).to_sym
+          method_name = ActiveSupport::Inflector.underscore(method.name).to_sym
           if !self.respond_to?(method_name)
             metaclass.send(:define_method, method_name) { method }
           end
diff --git a/lib/google/api_client/discovery/resource.rb b/lib/google/api_client/discovery/resource.rb
@@ -15,7 +15,7 @@
 
 require 'addressable/uri'
 
-require 'google/inflection'
+require 'active_support/inflector'
 require 'google/api_client/discovery/method'
 
 
@@ -45,13 +45,13 @@ def initialize(api, method_base, resource_name, discovery_document)
         @discovery_document = discovery_document
         metaclass = (class <<self; self; end)
         self.discovered_resources.each do |resource|
-          method_name = Google::INFLECTOR.underscore(resource.name).to_sym
+          method_name = ActiveSupport::Inflector.underscore(resource.name).to_sym
           if !self.respond_to?(method_name)
             metaclass.send(:define_method, method_name) { resource }
           end
         end
         self.discovered_methods.each do |method|
-          method_name = Google::INFLECTOR.underscore(method.name).to_sym
+          method_name = ActiveSupport::Inflector.underscore(method.name).to_sym
           if !self.respond_to?(method_name)
             metaclass.send(:define_method, method_name) { method }
           end
diff --git a/lib/google/api_client/discovery/schema.rb b/lib/google/api_client/discovery/schema.rb
@@ -21,7 +21,7 @@
 require 'addressable/uri'
 require 'addressable/template'
 
-require 'google/inflection'
+require 'active_support/inflector'
 require 'google/api_client/errors'
 
 
@@ -78,10 +78,8 @@ def self.parse(api, schema_data)
         # puts schema_data.inspect
 
         if schema_name
-          api_name_string =
-            Google::INFLECTOR.camelize(api.name)
-          api_version_string =
-            Google::INFLECTOR.camelize(api.version).gsub('.', '_')
+          api_name_string = ActiveSupport::Inflector.camelize(api.name)
+          api_version_string = ActiveSupport::Inflector.camelize(api.version).gsub('.', '_')
           # This is for compatibility with Ruby 1.8.7.
           # TODO(bobaman) Remove this when we eventually stop supporting 1.8.7.
           args = []
diff --git a/lib/google/api_client/railtie.rb b/lib/google/api_client/railtie.rb
@@ -1,3 +1,4 @@
+require 'rails/railtie'
 require 'google/api_client/logging'
 
 module Google
@@ -9,7 +10,7 @@ class APIClient
     #
     class Railtie < Rails::Railtie
       initializer 'google-api-client' do |app|
-        Google::APIClient.logger = Rails.logger
+        Google::APIClient.logger = app.logger
       end
     end
   end
diff --git a/lib/google/api_client/request.rb b/lib/google/api_client/request.rb
@@ -14,7 +14,6 @@
 
 require 'faraday'
 require 'faraday/request/multipart'
-require 'multi_json'
 require 'compat/multi_json'
 require 'addressable/uri'
 require 'stringio'
diff --git a/lib/google/api_client/service.rb b/lib/google/api_client/service.rb
@@ -120,7 +120,7 @@ def initialize(api_name, api_version, options = {})
         if options.include? :cache_store
           @cache_store = options[:cache_store]
         else
-          cache_exists = File.exist?(DEFAULT_CACHE_FILE)
+          cache_exists = File.exists?(DEFAULT_CACHE_FILE)
           if (cache_exists && File.writable?(DEFAULT_CACHE_FILE)) ||
              (!cache_exists && File.writable?(Dir.pwd))
             @cache_store = Google::APIClient::Service::SimpleFileStore.new(
diff --git a/lib/google/api_client/service/stub_generator.rb b/lib/google/api_client/service/stub_generator.rb
@@ -12,6 +12,8 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+require 'active_support/inflector'
+
 module Google
   class APIClient
     class Service
@@ -25,7 +27,7 @@ def generate_call_stubs(service, root)
 
           # Handle resources.
           root.discovered_resources.each do |resource|
-            method_name = Google::INFLECTOR.underscore(resource.name).to_sym
+            method_name = ActiveSupport::Inflector.underscore(resource.name).to_sym
             if !self.respond_to?(method_name)
               metaclass.send(:define_method, method_name) do
                 Google::APIClient::Service::Resource.new(service, resource)
@@ -35,7 +37,7 @@ def generate_call_stubs(service, root)
 
           # Handle methods.
           root.discovered_methods.each do |method|
-            method_name = Google::INFLECTOR.underscore(method.name).to_sym
+            method_name = ActiveSupport::Inflector.underscore(method.name).to_sym
             if !self.respond_to?(method_name)
               metaclass.send(:define_method, method_name) do |*args|
                 if args.length > 1
diff --git a/lib/google/api_client/version.rb b/lib/google/api_client/version.rb
@@ -13,19 +13,14 @@
 # limitations under the License.
 
 
-# Used to prevent the class/module from being loaded more than once
-if !defined?(::Google::APIClient::VERSION)
-
-
-  module Google
-    class APIClient
-      module VERSION
-        MAJOR = 0
-        MINOR = 7
-        TINY  = 1
-        PATCH = nil
-        STRING = [MAJOR, MINOR, TINY, PATCH].compact.join('.')
-      end
+module Google
+  class APIClient
+    module VERSION
+      MAJOR = 0
+      MINOR = 7
+      TINY  = 1
+      PATCH = nil
+      STRING = [MAJOR, MINOR, TINY, PATCH].compact.join('.')
     end
   end
 end
diff --git a/lib/google/inflection.rb b/lib/google/inflection.rb
diff --git a/rakelib/wiki.rake b/rakelib/wiki.rake
@@ -38,7 +38,7 @@ WIKI
     output.gsub!(/-32\./, "-16.")
     wiki_path = File.expand_path(
       File.join(File.dirname(__FILE__), '../wiki/'))
-    Dir.mkdir(wiki_path) if !File.exist?(wiki_path)
+    Dir.mkdir(wiki_path) unless File.exists?(wiki_path)
     File.open(File.join(wiki_path, 'SupportedAPIs.wiki'), 'w') do |file|
       file.write(output)
     end
diff --git a/spec/google/api_client/batch_spec.rb b/spec/google/api_client/batch_spec.rb
@@ -14,9 +14,8 @@
 
 require 'spec_helper'
 require 'google/api_client'
-require 'google/api_client/version'
 
-describe Google::APIClient::BatchRequest do
+RSpec.describe Google::APIClient::BatchRequest do
   CLIENT = Google::APIClient.new(:application_name => 'API Client Tests') unless defined?(CLIENT)
 
   after do
diff --git a/spec/google/api_client/discovery_spec.rb b/spec/google/api_client/discovery_spec.rb
@@ -22,9 +22,8 @@
 require 'compat/multi_json'
 require 'signet/oauth_1/client'
 require 'google/api_client'
-require 'google/api_client/version'
 
-describe Google::APIClient do
+RSpec.describe Google::APIClient do
   include ConnectionHelpers
   CLIENT = Google::APIClient.new(:application_name => 'API Client Tests') unless defined?(CLIENT)
 
diff --git a/spec/google/api_client/gzip_spec.rb b/spec/google/api_client/gzip_spec.rb
@@ -15,9 +15,8 @@
 require 'spec_helper'
 
 require 'google/api_client'
-require 'google/api_client/version'
 
-describe Google::APIClient::Gzip do
+RSpec.describe Google::APIClient::Gzip do
 
   def create_connection(&block)
     Faraday.new do |b|
diff --git a/spec/google/api_client/media_spec.rb b/spec/google/api_client/media_spec.rb
@@ -15,11 +15,10 @@
 require 'spec_helper'
 
 require 'google/api_client'
-require 'google/api_client/version'
 
 fixtures_path = File.expand_path('../../../fixtures', __FILE__)
 
-describe Google::APIClient::UploadIO do
+RSpec.describe Google::APIClient::UploadIO do
   it 'should reject invalid file paths' do
     expect(lambda do
       media = Google::APIClient::UploadIO.new('doesnotexist', 'text/plain')
@@ -57,7 +56,7 @@
   end
 end
 
-describe Google::APIClient::RangedIO do
+RSpec.describe Google::APIClient::RangedIO do
   before do
     @source = StringIO.new("1234567890abcdef")
     @io = Google::APIClient::RangedIO.new(@source, 1, 5)
@@ -105,7 +104,7 @@
     
 end
 
-describe Google::APIClient::ResumableUpload do
+RSpec.describe Google::APIClient::ResumableUpload do
   CLIENT = Google::APIClient.new(:application_name => 'API Client Tests') unless defined?(CLIENT)
 
   after do
diff --git a/spec/google/api_client/request_spec.rb b/spec/google/api_client/request_spec.rb
@@ -15,9 +15,8 @@
 require 'spec_helper'
 
 require 'google/api_client'
-require 'google/api_client/version'
 
-describe Google::APIClient::Request do
+RSpec.describe Google::APIClient::Request do
   CLIENT = Google::APIClient.new(:application_name => 'API Client Tests') unless defined?(CLIENT)
 
   it 'should normalize parameter names to strings' do
diff --git a/spec/google/api_client/result_spec.rb b/spec/google/api_client/result_spec.rb
@@ -15,9 +15,8 @@
 require 'spec_helper'
 
 require 'google/api_client'
-require 'google/api_client/version'
 
-describe Google::APIClient::Result do
+RSpec.describe Google::APIClient::Result do
   CLIENT = Google::APIClient.new(:application_name => 'API Client Tests') unless defined?(CLIENT)
 
   describe 'with the plus API' do
diff --git a/spec/google/api_client/service_account_spec.rb b/spec/google/api_client/service_account_spec.rb
@@ -18,7 +18,7 @@
 
 fixtures_path = File.expand_path('../../../fixtures', __FILE__)
 
-describe Google::APIClient::KeyUtils do
+RSpec.describe Google::APIClient::KeyUtils do
   it 'should read PKCS12 files from the filesystem' do
     if RUBY_PLATFORM == 'java' && RUBY_VERSION.start_with?('1.8')
       pending "Reading from PKCS12 not supported on jruby 1.8.x"
@@ -53,7 +53,7 @@
 
 end
 
-describe Google::APIClient::JWTAsserter do
+RSpec.describe Google::APIClient::JWTAsserter do
   include ConnectionHelpers
 
   before do
@@ -146,7 +146,7 @@
   end
 end
 
-describe Google::APIClient::ComputeServiceAccount do
+RSpec.describe Google::APIClient::ComputeServiceAccount do
   include ConnectionHelpers
 
   it 'should query metadata server' do
diff --git a/spec/google/api_client/service_spec.rb b/spec/google/api_client/service_spec.rb
diff --git a/spec/google/api_client/simple_file_store_spec.rb b/spec/google/api_client/simple_file_store_spec.rb
diff --git a/spec/google/api_client_spec.rb b/spec/google/api_client_spec.rb
