Unsigned arithmetic in vn function

George Tavares · George Tavares · commit 3e4d35a1db25 · 2015-04-10T16:54:41.000-03:00
diff --git a/src/com/iwebpp/crypto/TweetNacl.java b/src/com/iwebpp/crypto/TweetNacl.java
@@ -826,7 +826,7 @@ private static int vn(
 			int n)
 	{
 		int i,d = 0;
-		for (i = 0; i < n; i ++) d |= x[i+xoff]^y[i+yoff];
+		for (i = 0; i < n; i ++) d |= (x[i+xoff]&0xff) ^ (y[i+yoff]&0xff);
 		return (1 & ((d - 1) >>> 8)) - 1;
 	}
 
diff --git a/src/com/iwebpp/crypto/TweetNaclFast.java b/src/com/iwebpp/crypto/TweetNaclFast.java
@@ -840,7 +840,7 @@ private static int vn(
 			int n)
 	{
 		int i,d = 0;
-		for (i = 0; i < n; i ++) d |= x[i+xoff]^y[i+yoff];
+		for (i = 0; i < n; i ++) d |= (x[i+xoff]&0xff) ^ (y[i+yoff]&0xff);
 		return (1 & ((d - 1) >>> 8)) - 1;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -826,7 +826,7 @@ private static int vn(`
`826`	`826`	`int n)`
`827`	`827`	`{`
`828`	`828`	`int i,d = 0;`
`829`		`- for (i = 0; i < n; i ++) d \|= x[i+xoff]^y[i+yoff];`
	`829`	`+ for (i = 0; i < n; i ++) d \|= (x[i+xoff]&0xff) ^ (y[i+yoff]&0xff);`
`830`	`830`	`return (1 & ((d - 1) >>> 8)) - 1;`
`831`	`831`	`}`
`832`	`832`
Original file line number	Diff line number	Diff line change
`@@ -840,7 +840,7 @@ private static int vn(`
`840`	`840`	`int n)`
`841`	`841`	`{`
`842`	`842`	`int i,d = 0;`
`843`		`- for (i = 0; i < n; i ++) d \|= x[i+xoff]^y[i+yoff];`
	`843`	`+ for (i = 0; i < n; i ++) d \|= (x[i+xoff]&0xff) ^ (y[i+yoff]&0xff);`
`844`	`844`	`return (1 & ((d - 1) >>> 8)) - 1;`
`845`	`845`	`}`
`846`	`846`