refactor: create courseUnitType constans

Author: semrosin

HwProj.APIGateway/HwProj.APIGateway.API/Filters/FilesCountLimit.cs

@@ -2,7 +2,7 @@
 using System.Threading.Tasks;
 using HwProj.ContentService.Client;
 using HwProj.Models.ContentService.DTO;
-using HwProj.Models.Result;
+using HwProj.Models.CourseUnitType;
 
 namespace HwProj.APIGateway.API.Filters;
 
@@ -18,10 +18,10 @@ public FilesCountLimit(IContentServiceClient contentServiceClient)
 
     public async Task<bool> CheckCountLimit(ProcessFilesDTO processFilesDto)
     {
-        if(processFilesDto.FilesScope.CourseUnitType == "Homework") return true;
+        if (processFilesDto.FilesScope.CourseUnitType == CourseUnitType.Homework) return true;
 
         var existingStatuses = await _contentServiceClient.GetFilesStatuses(processFilesDto.FilesScope);
-        if(!existingStatuses.Succeeded) return false;
+        if (!existingStatuses.Succeeded) return false;
 
         var existingIds = existingStatuses.Value.Select(f => f.Id);
         if (processFilesDto.DeletingFileIds.Any(id => !existingIds.Contains(id)))

HwProj.APIGateway/HwProj.APIGateway.API/Filters/FilesPrivacyFilter.cs

@@ -3,6 +3,7 @@
 using System.Threading.Tasks;
 using HwProj.CoursesService.Client;
 using HwProj.Models.ContentService.DTO;
+using HwProj.Models.CourseUnitType;
 using HwProj.SolutionsService.Client;
 
 namespace HwProj.APIGateway.API.Filters;
@@ -20,10 +21,10 @@ public FilesPrivacyFilter(ICoursesServiceClient coursesServiceClient, ISolutions
 
     public async Task<bool> CheckDownloadRights(string? userId, ScopeDTO fileScope)
     {
-        if (fileScope.CourseUnitType == "Homework") return true;
-        if (fileScope.CourseUnitType == "Solution")
+        if (fileScope.CourseUnitType == CourseUnitType.Homework) return true;
+        if (fileScope.CourseUnitType == CourseUnitType.Solution)
         {
-            if(userId == null) return false;
+            if (userId == null) return false;
             var studentIds = new HashSet<string>();
             var solution = await _solutionsServiceClient.GetSolutionById(fileScope.CourseUnitId);
             studentIds.Add(solution.StudentId);
@@ -40,17 +41,17 @@ public async Task<bool> CheckDownloadRights(string? userId, ScopeDTO fileScope)
 
         return false;
     }
-    
+
     public async Task<bool> CheckUploadRights(string? userId, ScopeDTO fileScope)
     {
-        if(userId == null) return false;
-        if (fileScope.CourseUnitType == "Homework")
+        if (userId == null) return false;
+        if (fileScope.CourseUnitType == CourseUnitType.Homework)
         {
             var mentorIds = await _coursesServiceClient.GetCourseLecturersIds(fileScope.CourseId);
             if (!mentorIds.Contains(userId)) return false;
             return true;
-        } 
-        if (fileScope.CourseUnitType == "Solution")
+        }
+        if (fileScope.CourseUnitType == CourseUnitType.Solution)
         {
             var studentIds = new HashSet<string>();
             var solution = await _solutionsServiceClient.GetSolutionById(fileScope.CourseUnitId);

HwProj.Common/HwProj.Models/ContentService/CourseUnitType/CourseUnitType.cs

@@ -0,0 +1,9 @@
+namespace HwProj.Models.CourseUnitType
+{
+    public static class CourseUnitType
+    {
+        public const string Homework = "Homework";
+        public const string Solution = "Solution";
+        public const string Task = "Task";
+    };
+};