Fix some strict undefined equality checks (#481)

Author: YuriUfimtsev

hwproj.front/package.json

@@ -60,7 +60,10 @@
     "eject": "react-scripts eject"
   },
   "eslintConfig": {
-    "extends": "react-app"
+    "extends": "react-app",
+    "rules": {
+      "eqeqeq": [1, "always", { "null": "ignore" }]
+    }
   },
   "browserslist": [
     ">0.2%",

hwproj.front/src/components/Common/HomeworkTags.tsx

@@ -14,7 +14,7 @@ const BonusTip: FC = () => <sup style={{color: "green"}}> бонус</sup>
 
 export const getTip = (tagsOwner: { tags?: string[] }) => {
     const tags = tagsOwner.tags
-    if (tags === undefined) return null
+    if (tags == null) return null
     if (tags.includes(TestTag)) return <TestTip/>
     if (tags.includes(BonusTag)) return <BonusTip/>
     return null

hwproj.front/src/components/Common/MarkdownEditor.tsx

@@ -61,10 +61,11 @@ const MarkdownEditor: FC<MarkdownEditorProps> = (props) => {
                     className: "markdown-preview"
                 }}
                 maxHeight={props.maxHeight ?? 400}
-                height={props.height ?? 200}
+                height={props.height ?? 230}
                 textareaProps={{
                     placeholder: props.label
                 }}
+                preview="edit"
             />
         </div>
     );

hwproj.front/src/components/Common/PublicationAndDeadlineDates.tsx

@@ -2,7 +2,6 @@ import React, {useState, useEffect} from 'react';
 import Utils from "../../services/Utils";
 import {Tooltip, Checkbox, TextField, Grid, FormControlLabel} from '@mui/material/'
 
-
 interface IDateFieldsProps {
     publicationDate: Date | undefined;
     hasDeadline: boolean;
@@ -58,7 +57,7 @@ const PublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
         props.autoCalculatedDeadline && state.deadlineDate === props.autoCalculatedDeadline
 
     const isDeadlineSoonerThanPublication = (publicationDate: Date, deadlineDate: Date | undefined) =>
-        deadlineDate !== undefined && deadlineDate < publicationDate;
+        deadlineDate != null && deadlineDate < publicationDate;
 
     const deadlineSoonerThatHomework = isDeadlineSoonerThanPublication(state.publicationDate, state.deadlineDate)
 

hwproj.front/src/components/Common/TaskPublicationAndDeadlineDates.tsx

@@ -26,7 +26,7 @@ interface IDateFieldsState {
 const TaskPublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
     const {homework} = props
     const homeworkPublicationDate = new Date(homework.publicationDate!)
-    const homeworkDeadlineDate = homework.deadlineDate === undefined ? undefined : new Date(homework.deadlineDate)
+    const homeworkDeadlineDate = homework.deadlineDate == null ? undefined : new Date(homework.deadlineDate)
 
     const [state, setState] = useState<IDateFieldsState>({
         hasDeadline: props.hasDeadline,
@@ -36,10 +36,10 @@ const TaskPublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
     });
 
     const [showDates, setShowDates] = useState<boolean>(
-        props.deadlineDate !== undefined
-        || props.hasDeadline !== undefined
-        || props.isDeadlineStrict !== undefined
-        || props.publicationDate !== undefined)
+        props.deadlineDate != null
+        || props.hasDeadline != null
+        || props.isDeadlineStrict != null
+        || props.publicationDate != null)
 
     const {publicationDate, isDeadlineStrict, deadlineDate, hasDeadline} = state
 
@@ -48,15 +48,16 @@ const TaskPublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
 
     const isDeadlineSoonerThanPublication = (taskPublicationDate: Date | undefined, taskDeadlineDate: Date | undefined) =>
     {
-        if ((taskDeadlineDate || homeworkDeadlineDate) === undefined) return false
+        const deadlineDate = taskDeadlineDate || homeworkDeadlineDate
+        if (deadlineDate == null) return false
 
-        return (taskDeadlineDate || homeworkDeadlineDate)! < (taskPublicationDate || homeworkPublicationDate)
+        return deadlineDate < (taskPublicationDate || homeworkPublicationDate)
     }
 
     const taskSoonerThanHomework = !!state.publicationDate && isTaskSoonerThanHomework(state.publicationDate)
     const deadlineSoonerThanPublication = (!!state.deadlineDate || !!homeworkDeadlineDate) && isDeadlineSoonerThanPublication(state.publicationDate, state.deadlineDate)
 
-    const showDeadlineEdit = hasDeadline === undefined ? homework.hasDeadline : hasDeadline
+    const showDeadlineEdit = hasDeadline == null ? homework.hasDeadline : hasDeadline
 
     useEffect(() => {
         const validationResult =
@@ -143,13 +144,13 @@ const TaskPublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
                                         ...prevState,
                                         deadlineDate: undefined,
                                         isDeadlineStrict: undefined,
-                                        hasDeadline: hasDeadline === undefined ? !homework.hasDeadline : undefined,
+                                        hasDeadline: hasDeadline == null ? !homework.hasDeadline : undefined,
                                     }))
                                 }}
                             />}
                         />
                     <FormHelperText style={{ marginTop: '-1px' }}>
-                        {hasDeadline !== undefined 
+                        {hasDeadline != null
                             ? hasDeadline
                                 ? 'Было без дедлайна'
                                 : 'Был c дедлайном'
@@ -174,7 +175,7 @@ const TaskPublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
                             variant="standard"
                             error={deadlineSoonerThanPublication}
                             helperText={deadlineSoonerThanPublication ? `Дедлайн задачи раньше ее публикации: ${Utils.renderDateWithoutSeconds(state.publicationDate!)}` :
-                                deadlineDate !== undefined 
+                                deadlineDate != null
                                     ? props.homework.hasDeadline
                                         ? `Было ${Utils.renderDateWithoutSeconds(props.homework.deadlineDate!)}`
                                         : `Было без дедлайна`
@@ -200,7 +201,7 @@ const TaskPublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
                             <FormControlLabel
                                 label="Строгий"
                                 control={<Checkbox
-                                    checked={isDeadlineStrict === undefined ? homework.isDeadlineStrict : isDeadlineStrict}
+                                    checked={isDeadlineStrict == null ? homework.isDeadlineStrict : isDeadlineStrict}
                                     onChange={(_) => {
                                         setState(prevState => ({
                                             ...prevState,
@@ -210,7 +211,7 @@ const TaskPublicationAndDeadlineDates: React.FC<IDateFieldsProps> = (props) => {
                                 />}
                             />
                             <FormHelperText style={{ marginTop: '-1px' }}>
-                                {isDeadlineStrict !== undefined
+                                {isDeadlineStrict != null
                                     ? isDeadlineStrict
                                         ? 'Был нестрогий'
                                         : 'Был строгий'

hwproj.front/src/components/Courses/CourseExperimental.tsx

@@ -149,13 +149,13 @@ const CourseExperimental: FC<ICourseExperimentalProps> = (props) => {
                 color,
                 solutionsDescription
             } = StudentStatsUtils.calculateLastRatedSolutionInfo(solutions!, taskMaxRating)
-            return lastSolution === undefined
+            return lastSolution == null
                 ? <TimelineDot variant={"outlined"}/>
                 : <Tooltip arrow disableInteractive enterDelay={1000}
                            title={<span style={{whiteSpace: 'pre-line'}}>{solutionsDescription}</span>}>
                     <Chip style={{backgroundColor: color, marginTop: '11.5px'}}
                           size={"small"}
-                          label={lastRatedSolution === undefined ? "?" : lastRatedSolution.rating}/>
+                          label={lastRatedSolution == null ? "?" : lastRatedSolution.rating}/>
                 </Tooltip>
         }
         return <TimelineDot variant={"outlined"}/>

hwproj.front/src/components/Homeworks/EditHomework.tsx

@@ -70,7 +70,7 @@ const EditHomework: FC = () => {
 
         const course = await ApiSingleton.coursesApi.apiCoursesByCourseIdGet(homework.courseId!)
 
-        const deadline = homework.deadlineDate === undefined
+        const deadline = homework.deadlineDate == null
             ? undefined
             : new Date(homework.deadlineDate)
 
@@ -90,7 +90,7 @@ const EditHomework: FC = () => {
             hasErrors: false,
             tags: homework.tags!,
             changedTaskPublicationDates: homework.tasks!
-                .filter(t => t.publicationDate !== undefined)
+                .filter(t => t.publicationDate != null)
                 .map(t => new Date(t.publicationDate!))
         }))
     }

hwproj.front/src/components/Tasks/EditTask.tsx

@@ -69,11 +69,11 @@ const EditTask: FC = () => {
         const task = taskForEditing.task!
         const course = await ApiSingleton.coursesApi.apiCoursesByCourseIdGet(homework.courseId!)
 
-        const publication = task.publicationDate === undefined
+        const publication = task.publicationDate == null
             ? undefined
             : new Date(task.publicationDate)
 
-        const deadline = task.deadlineDate === undefined
+        const deadline = task.deadlineDate == null
             ? undefined
             : new Date(task.deadlineDate)
 

hwproj.front/src/components/Tasks/TaskDeadlines.tsx

@@ -89,7 +89,7 @@ const TaskDeadlines: FC<ITaskDeadlinesProps> = ({taskDeadlines, onGiveUpClick})
                     <Stack direction={"row"} spacing={10} alignItems={"baseline"} justifyContent={"space-between"}
                            style={{height: 27}}>
                         {Utils.renderReadableDate(deadline!.deadlineDate!)}
-                        {hoveredElement === i && solutionState === undefined && (
+                        {hoveredElement === i && solutionState == null && (
                             <Typography variant={"caption"}>
                                 <LinkText
                                     style={{textDecoration: "none", cursor: "pointer"}}

hwproj.front/src/services/Utils.ts

@@ -9,7 +9,7 @@ export default class Utils {
     }
 
     static toISOString(date: Date | undefined) {
-        if (date === undefined) return undefined
+        if (date == null) return undefined
 
         const pad = (num: number) => (num < 10 ? '0' : '') + num