Skip to content

Commit 68c5e81

Browse files
committed
improve readability of description completeness check
1 parent 61b40cd commit 68c5e81

1 file changed

Lines changed: 15 additions & 7 deletions

File tree

plugins/SkyCultureMaker/src/types/Description.hpp

Lines changed: 15 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,13 +63,21 @@ struct Description
6363
*/
6464
bool isComplete() const
6565
{
66-
return !name.trimmed().isEmpty() && !sky.trimmed().isEmpty() &&
67-
!moonAndSun.trimmed().isEmpty() && !zodiac.trimmed().isEmpty() && !planets.trimmed().isEmpty() &&
68-
!constellations.trimmed().isEmpty() && !milkyWay.trimmed().isEmpty() &&
69-
!otherObjects.trimmed().isEmpty() && !about.trimmed().isEmpty() &&
70-
!authors.trimmed().isEmpty() && !acknowledgements.trimmed().isEmpty() &&
71-
!references.trimmed().isEmpty() && classification != scm::ClassificationType::NONE &&
72-
license != scm::LicenseType::NONE;
66+
return !name.trimmed().isEmpty() &&
67+
!authors.trimmed().isEmpty() &&
68+
license != scm::LicenseType::NONE &&
69+
!cultureDescription.trimmed().isEmpty() &&
70+
!about.trimmed().isEmpty() &&
71+
!sky.trimmed().isEmpty() &&
72+
!moonAndSun.trimmed().isEmpty() &&
73+
!planets.trimmed().isEmpty() &&
74+
!zodiac.trimmed().isEmpty() &&
75+
!milkyWay.trimmed().isEmpty() &&
76+
!otherObjects.trimmed().isEmpty() &&
77+
!constellations.trimmed().isEmpty() &&
78+
!references.trimmed().isEmpty() &&
79+
!acknowledgements.trimmed().isEmpty() &&
80+
classification != scm::ClassificationType::NONE;
7381
}
7482
};
7583
} // namespace scm

0 commit comments

Comments
 (0)