appveyor: attempt to fix the building of Qt6-based package

Author: alex-w

.appveyor.yml

@@ -35,7 +35,7 @@ environment:
     CMAKE_ARGS: -A x64 -DSCM_SHOULD_ENABLE_CONVERTER=ON
     exiv2url: https://github.com/Exiv2/exiv2/releases/download/v0.28.0/exiv2-0.28.0-2019msvc64.zip
     exiv2baseName: exiv2-0.28.0-2019msvc64
-    scConverterEnabled: 1
+    scConverterEnabled: true
   - BUILD_NAME: Win64 Qt5.12
     APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017
     VSPATH: C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\SDK\ScopeCppSDK\VC\bin
@@ -45,7 +45,7 @@ environment:
     CMAKE_ARGS:
     exiv2url: https://github.com/10110111/exiv2/releases/download/ver0.28.0-final/exiv2-0.28.0-2017msvc64.zip
     exiv2baseName: exiv2-0.28.0-2017msvc64
-    scConverterEnabled: 0
+    scConverterEnabled: false
   - BUILD_NAME: Win64 Qt5.15
     APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
     VSPATH: C:\Program Files\Microsoft Visual Studio\2022\Community\SDK\ScopeCppSDK\vc15\VC\bin
@@ -55,23 +55,23 @@ environment:
     CMAKE_ARGS: -A x64
     exiv2url: https://github.com/Exiv2/exiv2/releases/download/v0.28.0/exiv2-0.28.0-2019msvc64.zip
     exiv2baseName: exiv2-0.28.0-2019msvc64
-    scConverterEnabled: 0
+    scConverterEnabled: false
   - BUILD_NAME: Arm64 Qt6.5
     APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
     VSPATH: C:\Program Files\Microsoft Visual Studio\2022\Community\SDK\ScopeCppSDK\vc15\VC\bin
     QT_VERSION_MAJOR: 6
     QT_BASEDIR: C:\Qt\6.5\msvc2019_arm64
     CMAKE_GENERATOR: Visual Studio 17 2022
     CMAKE_ARGS: -A ARM64 -DSTELLARIUM_BUILD_ARM64=ON -DQT_HOST_PATH=C:\Qt\6.5\msvc2019_64 -DQt6LinguistTools_DIR=C:\Qt\6.5\msvc2019_64\lib\cmake\Qt6LinguistTools -DENABLE_QTWEBENGINE=OFF
-    scConverterEnabled: 0
+    scConverterEnabled: false
 #  - BUILD_NAME: Arm64 Qt6.8
 #    APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2022
 #    VSPATH: C:\Program Files\Microsoft Visual Studio\2022\Community\SDK\ScopeCppSDK\vc15\VC\bin
 #    QT_VERSION_MAJOR: 6
 #    QT_BASEDIR: C:\Qt\6.8\msvc2022_arm64
 #    CMAKE_GENERATOR: Visual Studio 17 2022
 #    CMAKE_ARGS: -A ARM64 -DSTELLARIUM_BUILD_ARM64=ON -DQT_HOST_PATH=C:\Qt\6.8\msvc2022_64 -DQt6LinguistTools_DIR=C:\Qt\6.8\msvc2022_64\lib\cmake\Qt6LinguistTools -DENABLE_QTWEBENGINE=OFF
-#    scConverterEnabled: 0
+#    scConverterEnabled: false
 before_build:
   - set DEBUG_WINDEPLOYQT=false
   - set PUBLISH_BINARY=false
@@ -80,6 +80,7 @@ before_build:
   - set USE_EXT_LIBSSL=false
   - set USE_EXT_LIBGLES=false
   - set SIGNING=false
+  - set INSTALL_CONVERTER=false
   - set INSTALL_CONVERTER_DEPS=false
   - set INNSPATH=C:\Program Files (x86)\Inno Setup 5;C:\Program Files (x86)\Inno Setup 6
   - set PATH=%VSPATH%;%QT_BASEDIR%\bin;c:\%exiv2baseName%\bin;%INNSPATH%;c:\%gettextBaseName%\bin;c:\%tidyBaseName%\bin;c:\skyculture-converter;%PATH%
@@ -99,10 +100,8 @@ before_build:
   - ps: if($env:PUBLISH_BINARY -eq "true" -and $env:BUILD_NAME.contains('Win')) { $env:USE_MESA = 'true' }
   - ps: if($env:APPVEYOR_REPO_BRANCH -eq "stellarium-stable" -and $env:QT_VERSION_MAJOR -eq "6") { $env:SIGNING = 'true' }
   - ps: if($env:APPVEYOR_REPO_BRANCH -eq "stellarium-oldstable" -and $env:QT_VERSION_MAJOR -eq "5") { $env:SIGNING = 'true' }
-  - ps: if($env:CMAKE_ARGS -imatch 'SCM_SHOULD_ENABLE_CONVERTER=ON' -or $env:scConverterEnabled -eq "1") { $env:INSTALL_CONVERTER_DEPS = 'true' }
-  - ps: 'Write-Host "INSTALL_CONVERTER_DEPS is set to: $env:INSTALL_CONVERTER_DEPS"'
-  - ps: 'Write-Host "CMAKE_ARGS contains: $env:CMAKE_ARGS"'
-  - ps: 'Write-Host "scConverterEnabled is: $env:scConverterEnabled"'
+  - ps: if($env:CMAKE_ARGS.contains('SCM_SHOULD_ENABLE_CONVERTER') -or $env:scConverterEnabled -eq 'true') { $env:INSTALL_CONVERTER_DEPS = 'true' }
+  - ps: if($env:PUBLISH_BINARY -eq 'true' -and $env:scConverterEnabled -eq 'true') { $env:INSTALL_CONVERTER = 'true' }
 
   - ps: if($env:exiv2url -ne $null) { appveyor DownloadFile $env:exiv2url -FileName c:\$env:exiv2baseName.zip }
   - ps: if($env:exiv2url -ne $null) { 7z e c:\$env:exiv2baseName.zip -spf -oc:\ }
@@ -126,12 +125,12 @@ before_build:
   - if [%INSTALL_CONVERTER_DEPS%]==[true] ps: appveyor DownloadFile $env:tidyURL -FileName c:\$env:tidyBaseName.zip
   - if [%INSTALL_CONVERTER_DEPS%]==[true] ps: 7z e c:\$env:tidyBaseName.zip -spf -oc:\
 
-  - if [1]==[%scConverterEnabled%] git clone -q --depth=2 https://github.com/Stellarium/stellarium-skyculture-converter c:\skyculture-converter
-  - if [1]==[%scConverterEnabled%] mkdir c:\skyculture-converter\build
-  - if [1]==[%scConverterEnabled%] cd c:\skyculture-converter\build
-  - if [1]==[%scConverterEnabled%] git show --summary
-  - if [1]==[%scConverterEnabled%] cmake -DCMAKE_PREFIX_PATH=c:\%gettextBaseName%;c:\%tidyBaseName% -DCMAKE_INSTALL_PREFIX=c:\sc-converter -G "%CMAKE_GENERATOR%" %CMAKE_ARGS% ..
-  - if [1]==[%scConverterEnabled%] if [%PUBLISH_BINARY%]==[true] cmake --build . --config %configuration% --target install -- /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
+  - if [%INSTALL_CONVERTER%]==[true] git clone -q --depth=2 https://github.com/Stellarium/stellarium-skyculture-converter c:\skyculture-converter
+  - if [%INSTALL_CONVERTER%]==[true] mkdir c:\skyculture-converter\build
+  - if [%INSTALL_CONVERTER%]==[true] cd c:\skyculture-converter\build
+  - if [%INSTALL_CONVERTER%]==[true] git show --summary
+  - if [%INSTALL_CONVERTER%]==[true] cmake -DCMAKE_PREFIX_PATH=c:\%gettextBaseName%;c:\%tidyBaseName% -DCMAKE_INSTALL_PREFIX=c:\sc-converter -G "%CMAKE_GENERATOR%" %CMAKE_ARGS% ..
+  - if [%INSTALL_CONVERTER%]==[true] cmake --build . --config %configuration% --target install -- /logger:"C:\Program Files\AppVeyor\BuildAgent\Appveyor.MSBuildLogger.dll"
 
   - cd c:\stellarium
   - mkdir build && cd build