Skip to content
This repository was archived by the owner on Sep 26, 2025. It is now read-only.

Commit 03cc6b3

Browse files
committed
fix handling of build number, better documentation
1 parent 7c64980 commit 03cc6b3

File tree

8 files changed

+25
-15
lines changed

8 files changed

+25
-15
lines changed

README.md

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,13 @@
11
# container-images
2-
Dockerfiles for building docker images
32

4-
There is 1 subdirectory for every image to build.
3+
Dockerfiles and build contexts for building docker images
4+
5+
There is 1 subdirectory for every image to build. Dockerfiles and build
6+
contexts are generated from jinja2 templates in tpls directory. The images.py
7+
script generates the files, and can also be used to build docker images and to
8+
test them. To see more info do:
9+
10+
python images.py --help
511

612
## testing
713

@@ -17,22 +23,26 @@ Will build every image. Look at the test for example command lines.
1723

1824
## Publishing a new release
1925

20-
* Change release name in images.py, and add it to tpls/tpl.README.md
21-
* Update the READMEs and Dockerfiles for the individual images
26+
If we are publishing 2017.0.0 build number 2, then the docker image will have 3
27+
tags: 2017.0.0-2, 2017.0.0, latest. An automated build on docker hub is
28+
triggered by pushing a tag to this repo. The tag has the form 2017.0.0-2.
29+
30+
* Change update_number & build_number in images.py, and add it to tpls/tpl.README.md
31+
* Regenerate the READMEs and Dockerfiles for the individual images
2232

2333
python images.py --gen all
2434

2535
* Commit changes
2636
* Tag with the release name
2737

28-
git tag -a 2017.0.0 -m 'new release'
38+
git tag -a 2017.0.0-2 -m '2017.0.0-2 release'
2939

3040
* Push changes, this will trigger testing on travis-ci
3141

3242
git push
3343

3444
* When travis-ci testing completes, push the tag
3545

36-
git push origin 2017.0.0
46+
git push origin 2017.0.0-2
3747

3848
* Check later that all builds have completed on docker hub

configs/intelpython2_core/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ MAINTAINER Robert Cohn <[email protected]>
66
ENV ACCEPT_INTEL_PYTHON_EULA=yes
77

88
RUN conda config --add channels intel \
9-
&& conda install -y -q intelpython2_core=2017.0.0-2 python=2
9+
&& conda install -y -q intelpython2_core=2017.0.0=2 python=2

configs/intelpython2_full/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ MAINTAINER Robert Cohn <[email protected]>
66
ENV ACCEPT_INTEL_PYTHON_EULA=yes
77

88
RUN conda config --add channels intel \
9-
&& conda install -y -q intelpython2_full=2017.0.0-2 python=2
9+
&& conda install -y -q intelpython2_full=2017.0.0=2 python=2

configs/intelpython3_core/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ MAINTAINER Robert Cohn <[email protected]>
66
ENV ACCEPT_INTEL_PYTHON_EULA=yes
77

88
RUN conda config --add channels intel \
9-
&& conda install -y -q intelpython3_core=2017.0.0-2 python=3
9+
&& conda install -y -q intelpython3_core=2017.0.0=2 python=3

configs/intelpython3_full/Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ MAINTAINER Robert Cohn <[email protected]>
66
ENV ACCEPT_INTEL_PYTHON_EULA=yes
77

88
RUN conda config --add channels intel \
9-
&& conda install -y -q intelpython3_full=2017.0.0-2 python=3
9+
&& conda install -y -q intelpython3_full=2017.0.0=2 python=3

images.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ def __init__(self,pyver=None,package=None,name=None):
5050
(pyver,package) = parse_name(name)
5151
self['pyver'] = pyver
5252
self['package'] = package
53-
self['release'] = '2017.0.0-2'
54-
self['update_version'] = '2017.0.0'
53+
self['update_number'] = '2017.0.0'
54+
self['build_number'] = '2'
5555

5656
def name(self):
5757
return 'intelpython%d_%s' % (self['pyver'],self['package'])

tpls/tpl.Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ MAINTAINER Robert Cohn <[email protected]>
66
ENV ACCEPT_INTEL_PYTHON_EULA=yes
77

88
RUN conda config --add channels intel \
9-
&& conda install -y -q intelpython{{pyver}}_{{package}}={{release}} python={{pyver}}
9+
&& conda install -y -q intelpython{{pyver}}_{{package}}={{update_number}}={{build_number}} python={{pyver}}
1010

tpls/tpl.post_push

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
#! /bin/bash
22

3-
docker tag $DOCKER_REPO:$DOCKER_TAG $DOCKER_REPO:{{update_version}}
4-
docker push $DOCKER_REPO:{{update_version}}
3+
docker tag $DOCKER_REPO:$DOCKER_TAG $DOCKER_REPO:{{update_number}}
4+
docker push $DOCKER_REPO:{{update_number}}
55

66
docker tag $DOCKER_REPO:$DOCKER_TAG $DOCKER_REPO:latest
77
docker push $DOCKER_REPO:latest

0 commit comments

Comments
 (0)