Add --log-level argument

Author: ZzEeKkAa

dpbench/console/_namespace.py

@@ -31,6 +31,7 @@ class Namespace(argparse.Namespace):
     program: str
     color: str
     comparisons: list[str]
+    log_level: str
     skip_expected_failures: bool
 
 

dpbench/console/entry.py

@@ -5,6 +5,7 @@
 """Entry point for dpbench cli tool."""
 
 import argparse
+import logging
 from importlib.metadata import version
 
 from ._namespace import (
@@ -74,6 +75,14 @@ def parse_args() -> Namespace:
         default="results.db",
         help="Path to a database to store results.",
     )
+    parser.add_argument(
+        "--log-level",
+        type=str,
+        choices=["critical", "fatal", "error", "warning", "info", "debug"],
+        nargs="?",
+        default="warning",
+        help="Log level.",
+    )
 
     subparsers = parser.add_subparsers(dest="program")
 
@@ -104,6 +113,8 @@ def main():
     """Main function to run on dpbench console tool."""
     args = parse_args()
 
+    logging.root.setLevel(args.log_level.upper())
+
     conn = None
     if args.program == "report" or args.program == "run" and args.save:
         import dpbench.infrastructure as dpbi

dpbench/infrastructure/benchmark.py

@@ -371,7 +371,8 @@ def _set_reference_implementation(self) -> BenchmarkImplFn:
         ]
 
         if len(reference_implementations) == 0:
-            raise RuntimeError("No reference implementation")
+            logging.warn("No reference implementation")
+            return None
 
         return reference_implementations[0]
 
@@ -435,7 +436,8 @@ def _validate_results(self, preset, frmwrk, frmwrk_out, precision):
                         ).format(key, ref_out[key], frmwrk_out[key])
                     )
             return valid
-        except Exception:
+        except Exception as e:
+            logging.error(f"Exception during validation {e.args}")
             return False
 
     def __init__(

dpbench/infrastructure/reporter.py

@@ -319,4 +319,10 @@ def get_unexpected_failures(
 
     failures = {f for f in get_failures_from_results(results_db, run_id)}
 
+    fixed_failures = expected_failures.difference(failures)
+    if len(fixed_failures):
+        logging.warn(
+            f"these benchmarks does not fail anymore: {fixed_failures}"
+        )
+
     return failures.difference(expected_failures)

dpbench/migrations/env.py

@@ -2,8 +2,6 @@
 #
 # SPDX-License-Identifier: Apache-2.0
 
-from logging.config import fileConfig
-
 from alembic import context
 from sqlalchemy import engine_from_config, pool
 
@@ -14,11 +12,6 @@
 # access to the values within the .ini file in use.
 config = context.config
 
-# Interpret the config file for Python logging.
-# This line sets up loggers basically.
-if config.config_file_name is not None:
-    fileConfig(config.config_file_name)
-
 # add your model's MetaData object here
 # for 'autogenerate' support
 # from myapp import mymodel