Try replacing std::isnan with sycl::isnan

oleksandr-pavlyk · oleksandr-pavlyk · commit 185c46041ef0 · 2024-10-26T17:44:43.000-05:00
diff --git a/dpctl/tensor/libtensor/include/kernels/elementwise_functions/maximum.hpp b/dpctl/tensor/libtensor/include/kernels/elementwise_functions/maximum.hpp
@@ -74,7 +74,7 @@ template <typename argT1, typename argT2, typename resT> struct MaximumFunctor
         }
         else if constexpr (std::is_floating_point_v<argT1> ||
                            std::is_same_v<argT1, sycl::half>)
-            return (std::isnan(in1) || in1 > in2) ? in1 : in2;
+            return (sycl::isnan(in1) || in1 > in2) ? in1 : in2;
         else
             return (in1 > in2) ? in1 : in2;
     }
diff --git a/dpctl/tensor/libtensor/include/kernels/elementwise_functions/minimum.hpp b/dpctl/tensor/libtensor/include/kernels/elementwise_functions/minimum.hpp
@@ -74,7 +74,7 @@ template <typename argT1, typename argT2, typename resT> struct MinimumFunctor
         }
         else if constexpr (std::is_floating_point_v<argT1> ||
                            std::is_same_v<argT1, sycl::half>)
-            return (std::isnan(in1) || in1 < in2) ? in1 : in2;
+            return (sycl::isnan(in1) || in1 < in2) ? in1 : in2;
         else
             return (in1 < in2) ? in1 : in2;
     }

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ template <typename argT1, typename argT2, typename resT> struct MaximumFunctor`
`74`	`74`	`}`
`75`	`75`	`else if constexpr (std::is_floating_point_v<argT1> \|\|`
`76`	`76`	`std::is_same_v<argT1, sycl::half>)`
`77`		`- return (std::isnan(in1) \|\| in1 > in2) ? in1 : in2;`
	`77`	`+ return (sycl::isnan(in1) \|\| in1 > in2) ? in1 : in2;`
`78`	`78`	`else`
`79`	`79`	`return (in1 > in2) ? in1 : in2;`
`80`	`80`	`}`