Skip to content

Commit 219115d

Browse files
authored
Fix using dppl.has_sycl_platforms() and dppl.has_gpu_queues() functions in skipIf() (#56)
* Fix using dppl.has_sycl_platforms() and dppl.has_gpu_queues() functions in skipIf() * Add skipIf for cases when CPU platforn is not available
1 parent c9bc3fe commit 219115d

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

dppl/tests/dppl_tests/test_sycl_queue_manager.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@
2727
import unittest
2828

2929
class TestGetNumPlatforms (unittest.TestCase):
30-
@unittest.skipIf(not dppl.has_sycl_platforms, "No SYCL platforms available")
30+
@unittest.skipIf(not dppl.has_sycl_platforms(), "No SYCL platforms available")
3131
def test_dppl_get_num_platforms (self):
3232
if(dppl.has_sycl_platforms):
3333
self.assertGreaterEqual(dppl.get_num_platforms(), 1)
3434

35-
@unittest.skipIf(not dppl.has_sycl_platforms, "No SYCL platforms available")
35+
@unittest.skipIf(not dppl.has_sycl_platforms(), "No SYCL platforms available")
3636
class TestDumpMethods (unittest.TestCase):
3737
def test_dppl_dump (self):
3838
try:
@@ -47,7 +47,7 @@ def test_dppl_dump_device_info (self):
4747
except Exception:
4848
self.fail("Encountered an exception inside dump_device_info().")
4949

50-
@unittest.skipIf(not dppl.has_sycl_platforms, "No SYCL platforms available")
50+
@unittest.skipIf(not dppl.has_sycl_platforms(), "No SYCL platforms available")
5151
class TestDPPLIsInDPPLCtxt (unittest.TestCase):
5252

5353
def test_is_in_dppl_ctxt_outside_device_ctxt (self):
@@ -57,28 +57,31 @@ def test_is_in_dppl_ctxt_inside_device_ctxt (self):
5757
with dppl.device_context(dppl.device_type.gpu):
5858
self.assertTrue(dppl.is_in_dppl_ctxt())
5959

60+
@unittest.skipIf(not dppl.has_cpu_queues(), "No CPU platforms available")
6061
def test_is_in_dppl_ctxt_inside_nested_device_ctxt (self):
6162
with dppl.device_context(dppl.device_type.cpu):
6263
with dppl.device_context(dppl.device_type.gpu):
6364
self.assertTrue(dppl.is_in_dppl_ctxt())
6465
self.assertTrue(dppl.is_in_dppl_ctxt())
6566
self.assertFalse(dppl.is_in_dppl_ctxt())
6667

67-
@unittest.skipIf(not dppl.has_sycl_platforms, "No SYCL platforms available")
68+
@unittest.skipIf(not dppl.has_sycl_platforms(), "No SYCL platforms available")
6869
class TestGetCurrentQueueInMultipleThreads (unittest.TestCase):
6970

7071
def test_num_current_queues_outside_with_clause (self):
7172
self.assertEqual(dppl.get_num_activated_queues(), 0)
7273

73-
@unittest.skipIf(not dppl.has_gpu_queues, "No GPU platforms available")
74+
@unittest.skipIf(not dppl.has_gpu_queues(), "No GPU platforms available")
75+
@unittest.skipIf(not dppl.has_cpu_queues(), "No CPU platforms available")
7476
def test_num_current_queues_inside_with_clause (self):
7577
with dppl.device_context(dppl.device_type.cpu):
7678
self.assertEqual(dppl.get_num_activated_queues(), 1)
7779
with dppl.device_context(dppl.device_type.gpu):
7880
self.assertEqual(dppl.get_num_activated_queues(), 2)
7981
self.assertEqual(dppl.get_num_activated_queues(), 0)
8082

81-
@unittest.skipIf(not dppl.has_gpu_queues, "No GPU platforms available")
83+
@unittest.skipIf(not dppl.has_gpu_queues(), "No GPU platforms available")
84+
@unittest.skipIf(not dppl.has_cpu_queues(), "No CPU platforms available")
8285
def test_num_current_queues_inside_threads (self):
8386
from threading import Thread, local
8487
def SessionThread (self):

dppl/tests/dppl_tests/test_sycl_usm.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ def test_memory_without_context (self):
4343
# Without context
4444
self.assertEqual(mobj._usm_type(), 'shared')
4545

46+
@unittest.skipIf(not dppl.has_cpu_queues(), "No CPU platforms available")
4647
def test_memory_cpu_context (self):
4748
mobj = self._create_memory()
4849

@@ -60,6 +61,7 @@ def test_memory_cpu_context (self):
6061
# not in the same SYCL context
6162
self.assertTrue(usm_type in ['unknown', 'shared'])
6263

64+
@unittest.skipIf(not dppl.has_gpu_queues(), "No GPU platforms available")
6365
def test_memory_gpu_context (self):
6466
mobj = self._create_memory()
6567

0 commit comments

Comments
 (0)