Handle unknown device type in DPCTLPlatform_GetDevices

Author: ndgrigorian

dpctl/_sycl_platform.pyx

@@ -398,8 +398,6 @@ cdef class SyclPlatform(_SyclPlatform):
                 If `device_type` is not a str or :class:`dpctl.device_type`
                 enum.
             ValueError:
-                If the value of `device_type` is not supported.
-
                 If the ``DPCTLPlatform_GetDevices`` call returned
                 ``NULL`` instead of a ``DPCTLDeviceVectorRef`` object.
         """
@@ -424,9 +422,7 @@ cdef class SyclPlatform(_SyclPlatform):
             elif dty_str == "gpu":
                 DTy = _device_type._GPU
             else:
-                raise ValueError(
-                    "Unexpected value of `device_type`."
-                )
+                DTy = _device_type._UNKNOWN_DEVICE
         elif isinstance(device_type, device_type_t):
             if device_type == device_type_t.all:
                 DTy = _device_type._ALL_DEVICES
@@ -441,9 +437,7 @@ cdef class SyclPlatform(_SyclPlatform):
             elif device_type == device_type_t.gpu:
                 DTy = _device_type._GPU
             else:
-                raise ValueError(
-                    "Unexpected value of `device_type`."
-                )
+                DTy = _device_type._UNKNOWN_DEVICE
         else:
             raise TypeError(
                 "device type should be specified as a str or an "

libsyclinterface/source/dpctl_sycl_platform_interface.cpp

@@ -282,6 +282,7 @@ DPCTLPlatform_GetDevices(__dpctl_keep const DPCTLSyclPlatformRef PRef,
                       __FILE__, __func__, __LINE__);
         return nullptr;
     }
+
     using vecTy = std::vector<DPCTLSyclDeviceRef>;
     vecTy *DevicesVectorPtr = nullptr;
     try {
@@ -291,6 +292,12 @@ DPCTLPlatform_GetDevices(__dpctl_keep const DPCTLSyclPlatformRef PRef,
         error_handler(e, __FILE__, __func__, __LINE__);
         return nullptr;
     }
+
+    // handle unknown device
+    if (!DTy) {
+        return wrap<vecTy>(DevicesVectorPtr);
+    }
+
     try {
         auto SyclDTy = DPCTL_DPCTLDeviceTypeToSyclDeviceType(DTy);
         auto Devices = P->get_devices(SyclDTy);