Fix division by zero exception found by array API tests suite

oleksandr-pavlyk · oleksandr-pavlyk · commit 6054b1f74875 · 2024-10-18T15:19:46.000-05:00
diff --git a/dpctl/tensor/_manipulation_functions.py b/dpctl/tensor/_manipulation_functions.py
@@ -353,10 +353,12 @@ def roll(X, /, shift, *, axis=None):
         res = dpt.empty(
             X.shape, dtype=X.dtype, usm_type=X.usm_type, sycl_queue=exec_q
         )
+        sz = X.size
+        shift = (shift % sz) if sz > 0 else 0
         hev, roll_ev = ti._copy_usm_ndarray_for_roll_1d(
             src=X,
             dst=res,
-            shift=(shift % X.size),
+            shift=shift,
             sycl_queue=exec_q,
             depends=dep_evs,
         )

Original file line number	Diff line number	Diff line change
`@@ -353,10 +353,12 @@ def roll(X, /, shift, *, axis=None):`
`353`	`353`	`res = dpt.empty(`
`354`	`354`	`X.shape, dtype=X.dtype, usm_type=X.usm_type, sycl_queue=exec_q`
`355`	`355`	`)`
	`356`	`+ sz = X.size`
	`357`	`+ shift = (shift % sz) if sz > 0 else 0`
`356`	`358`	`hev, roll_ev = ti._copy_usm_ndarray_for_roll_1d(`
`357`	`359`	`src=X,`
`358`	`360`	`dst=res,`
`359`		`- shift=(shift % X.size),`
	`361`	`+ shift=shift,`
`360`	`362`	`sycl_queue=exec_q,`
`361`	`363`	`depends=dep_evs,`
`362`	`364`	`)`