Add assertion that index type is integral to indexing utilities

ndgrigorian · ndgrigorian · commit 739fe7606056 · 2024-11-15T10:13:02.000-08:00
diff --git a/dpctl/tensor/libtensor/include/utils/indexing_utils.hpp b/dpctl/tensor/libtensor/include/utils/indexing_utils.hpp
@@ -28,6 +28,7 @@
 #include <cstdint>
 #include <limits>
 #include <sycl/sycl.hpp>
+#include <type_traits>
 
 #include "kernels/dpctl_tensor_types.hpp"
 
@@ -46,6 +47,8 @@ namespace indexing_utils
 
 template <typename IndT> struct WrapIndex
 {
+    static_assert(std::is_integral_v<IndT>);
+
     ssize_t operator()(ssize_t max_item, IndT ind) const
     {
         ssize_t projected;
@@ -91,6 +94,8 @@ template <typename IndT> struct WrapIndex
 
 template <typename IndT> struct ClipIndex
 {
+    static_assert(std::is_integral_v<IndT>);
+
     ssize_t operator()(ssize_t max_item, IndT ind) const
     {
         ssize_t projected;

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`	`#include <cstdint>`
`29`	`29`	`#include <limits>`
`30`	`30`	`#include <sycl/sycl.hpp>`
	`31`	`+#include <type_traits>`
`31`	`32`
`32`	`33`	`#include "kernels/dpctl_tensor_types.hpp"`
`33`	`34`
`@@ -46,6 +47,8 @@ namespace indexing_utils`
`46`	`47`
`47`	`48`	`template <typename IndT> struct WrapIndex`
`48`	`49`	`{`
	`50`	`+ static_assert(std::is_integral_v<IndT>);`
	`51`	`+`
`49`	`52`	`ssize_t operator()(ssize_t max_item, IndT ind) const`
`50`	`53`	`{`
`51`	`54`	`ssize_t projected;`
`@@ -91,6 +94,8 @@ template <typename IndT> struct WrapIndex`
`91`	`94`
`92`	`95`	`template <typename IndT> struct ClipIndex`
`93`	`96`	`{`
	`97`	`+ static_assert(std::is_integral_v<IndT>);`
	`98`	`+`
`94`	`99`	`ssize_t operator()(ssize_t max_item, IndT ind) const`
`95`	`100`	`{`
`96`	`101`	`ssize_t projected;`