Added dpt.eye test, type error for k keyword

Author: ndgrigorian

dpctl/tensor/_ctors.py

@@ -1083,11 +1083,16 @@ def eye(
         if n_cols is None:
             n_cols = n_rows
         #allocate a 1D array of zeros, length equal to n_cols * n_rows
+        k_dt = type(k)
+        if not np.issubdtype(k_dt, np.integer):
+            raise TypeError(
+                "k keyword must be an integer, got {type}".format(type=k_dt)
+            )
         x = zeros((n_rows * n_cols,), dtype=dtype, order=order, device=device, usm_type=usm_type, sycl_queue=sycl_queue)
         if k > -n_rows and k < n_cols:
-            #find the length of an arbitrary diagonal
+            #find the length of the diagonal
             l = min(n_cols, n_rows, n_cols-k, n_rows+k)
-            #i is the first element of the diagonal, j is the last, s is the step size
+            #i is the first index of the diagonal in 1D index space, j is the last, s is the step size
             if order == "C":
                 s = n_cols+1
                 i = k if k >= 0 else n_cols*-k

dpctl/tests/test_usm_ndarray_ctor.py

@@ -16,6 +16,7 @@
 
 import ctypes
 import numbers
+from typing import Type
 
 import numpy as np
 import pytest
@@ -1276,6 +1277,8 @@ def test_common_arg_validation():
         dpt.ones_like(X, order=order)
     with pytest.raises(ValueError):
         dpt.full_like(X, 1, order=order)
+    with pytest.raises(ValueError):
+        dpt.eye(4, order=order)
     X = dict()
     # test for type validation
     with pytest.raises(TypeError):
@@ -1286,3 +1289,23 @@ def test_common_arg_validation():
         dpt.ones_like(X)
     with pytest.raises(TypeError):
         dpt.full_like(X, 1)
+    with pytest.raises(TypeError):
+        dpt.eye(4, k=1.2)
+
+@pytest.mark.parametrize("shapes", [(0,), (1,), (7,), (6, 1), (3, 9), (10,5)])
+@pytest.mark.parametrize("k", np.arange(-4, 5, 1))
+@pytest.mark.parametrize("orders", ["C", "F"])
+def test_eye(shapes, k, orders):
+    try:
+        q = dpctl.SyclQueue()
+    except dpctl.SyclQueueCreationError:
+        pytest.skip("Queue could not be created")
+
+    shape=shapes
+    k=k
+    order=orders
+
+    Xnp = np.eye(*shape, k=k, order=order)
+    X = dpt.eye(*shape, k=k, order=order, sycl_queue=q)
+
+    np.testing.assert_array_equal(Xnp, dpt.asnumpy(X))