Skip to content

Commit 9a06999

Browse files
committed
Vector implementation for floor_divide() function has been changed.
1 parent 9bb5fa7 commit 9a06999

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

dpctl/tensor/libtensor/include/kernels/elementwise_functions/floor_divide.hpp

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -81,24 +81,24 @@ struct FloorDivideFunctor
8181
{
8282
return tmp;
8383
}
84-
if constexpr (std::is_integral_v<typename decltype(tmp)::element_type>)
85-
{
84+
else if constexpr (std::is_integral_v<typename decltype(
85+
tmp)::element_type>) {
8686
using dpctl::tensor::type_utils::vec_cast;
8787
return vec_cast<resT, typename decltype(tmp)::element_type, vec_sz>(
8888
tmp);
8989
}
9090
else {
91-
sycl::vec<resT, vec_sz> res;
92-
for (int i = 0; i < vec_sz; i++) {
93-
auto tmp2 = sycl::floor(tmp[i]);
94-
if constexpr (std::is_same_v<resT, decltype(tmp2)>) {
95-
res[i] = tmp2;
96-
}
97-
else {
98-
res[i] = static_cast<resT>(tmp2);
99-
}
91+
sycl::vec<resT, vec_sz> res = sycl::floor(tmp);
92+
if constexpr (std::is_same_v<resT,
93+
typename decltype(res)::element_type>)
94+
{
95+
return res;
96+
}
97+
else {
98+
using dpctl::tensor::type_utils::vec_cast;
99+
return vec_cast<resT, typename decltype(res)::element_type,
100+
vec_sz>(res);
100101
}
101-
return res;
102102
}
103103
}
104104
};

dpctl/tensor/libtensor/include/utils/offset_utils.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ template <class V, class U> sink_t __appender(V &lhs, U &&rhs)
6464
}
6565

6666
template <typename T, typename A, typename... Vs>
67-
std::vector<T, A> concat(std::vector<T, A> lhs, Vs &&... vs)
67+
std::vector<T, A> concat(std::vector<T, A> lhs, Vs &&...vs)
6868
{
6969
std::size_t s = lhs.size();
7070
{
@@ -87,7 +87,7 @@ template <typename indT, typename... Vs>
8787
std::tuple<indT *, size_t, sycl::event>
8888
device_allocate_and_pack(sycl::queue q,
8989
std::vector<sycl::event> &host_task_events,
90-
Vs &&... vs)
90+
Vs &&...vs)
9191
{
9292

9393
// memory transfer optimization, use USM-host for temporary speeds up

0 commit comments

Comments
 (0)