Skip to content

Commit a8e316e

Browse files
Changes to delete DPCTLKernel_GetFunctionName
1 parent 3340f33 commit a8e316e

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

dpctl/_backend.pxd

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -250,7 +250,6 @@ cdef extern from "syclinterface/dpctl_sycl_event_interface.h":
250250

251251

252252
cdef extern from "syclinterface/dpctl_sycl_kernel_interface.h":
253-
cdef const char* DPCTLKernel_GetFunctionName(const DPCTLSyclKernelRef KRef)
254253
cdef size_t DPCTLKernel_GetNumArgs(const DPCTLSyclKernelRef KRef)
255254
cdef void DPCTLKernel_Delete(DPCTLSyclKernelRef KRef)
256255

dpctl/program/_program.pxd

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,11 +33,11 @@ cdef class SyclKernel:
3333
kernel.
3434
'''
3535
cdef DPCTLSyclKernelRef _kernel_ref
36-
cdef const char *_function_name
36+
cdef str _function_name
3737
cdef DPCTLSyclKernelRef get_kernel_ref (self)
3838

3939
@staticmethod
40-
cdef SyclKernel _create (DPCTLSyclKernelRef kref)
40+
cdef SyclKernel _create (DPCTLSyclKernelRef kref, str name)
4141

4242

4343
cdef class SyclProgram:

dpctl/program/_program.pyx

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ cimport cython.array
3030
from dpctl._backend cimport ( # noqa: E211, E402
3131
DPCTLCString_Delete,
3232
DPCTLKernel_Delete,
33-
DPCTLKernel_GetFunctionName,
3433
DPCTLKernel_GetNumArgs,
3534
DPCTLProgram_CreateFromOCLSource,
3635
DPCTLProgram_CreateFromSpirv,
@@ -61,20 +60,19 @@ cdef class SyclKernel:
6160
"""
6261
"""
6362
@staticmethod
64-
cdef SyclKernel _create(DPCTLSyclKernelRef kref):
63+
cdef SyclKernel _create(DPCTLSyclKernelRef kref, str name):
6564
cdef SyclKernel ret = SyclKernel.__new__(SyclKernel)
6665
ret._kernel_ref = kref
67-
ret._function_name = DPCTLKernel_GetFunctionName(kref)
66+
ret._function_name = name
6867
return ret
6968

7069
def __dealloc__(self):
7170
DPCTLKernel_Delete(self._kernel_ref)
72-
DPCTLCString_Delete(self._function_name)
7371

7472
def get_function_name(self):
7573
""" Returns the name of the ``sycl::kernel`` function.
7674
"""
77-
return self._function_name.decode()
75+
return self._function_name
7876

7977
def get_num_args(self):
8078
""" Returns the number of arguments for this kernel function.
@@ -121,7 +119,7 @@ cdef class SyclProgram:
121119
cpdef SyclKernel get_sycl_kernel(self, str kernel_name):
122120
name = kernel_name.encode('utf8')
123121
return SyclKernel._create(DPCTLProgram_GetKernel(self._program_ref,
124-
name))
122+
name), kernel_name)
125123

126124
def has_sycl_kernel(self, str kernel_name):
127125
name = kernel_name.encode('utf8')

0 commit comments

Comments
 (0)