Skip to content

Commit bd9bc5f

Browse files
Make comments in solve.py more readable
1 parent d768c9b commit bd9bc5f

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

examples/pybind11/onemkl_gemv/solve.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -146,24 +146,27 @@ def cg_solve(A, b):
146146
e_p = dpctl.SyclEvent()
147147
e_x = dpctl.SyclEvent()
148148
for i in range(max_iters):
149-
he_dot, e_dot = sycl_gemm.gemv(
150-
exec_queue, A, p, Ap, depends=[e_p]
151-
) # Ap = A @ p
149+
# Ap = A @ p
150+
he_dot, e_dot = sycl_gemm.gemv(exec_queue, A, p, Ap, depends=[e_p])
152151
all_host_tasks.append(he_dot)
153-
alpha = rsold / sycl_gemm.dot_blocking( # alpha = rsold / dot(p, Ap)
152+
# alpha = rsold / dot(p, Ap)
153+
alpha = rsold / sycl_gemm.dot_blocking(
154154
exec_queue, p, Ap, depends=[e_dot]
155155
)
156+
# x = x + alpha * p
156157
he1_axpby, e1_axpby = sycl_gemm.axpby_inplace(
157158
exec_queue, alpha, p, 1, x, depends=[e_p, e_x]
158-
) # x = x + alpha * p
159+
)
159160
all_host_tasks.append(he1_axpby)
160161
e_x = e1_axpby
161162

163+
# r = r - alpha * Ap
162164
he2_axpby, e2_axpby = sycl_gemm.axpby_inplace(
163165
exec_queue, -alpha, Ap, 1, r, depends=[e_p]
164-
) # r = r - alpha * Ap
166+
)
165167
all_host_tasks.append(he2_axpby)
166168

169+
# rsnew = dot(r, r)
167170
rsnew = sycl_gemm.norm_squared_blocking(
168171
exec_queue, r, depends=[e2_axpby]
169172
)
@@ -173,9 +176,10 @@ def cg_solve(A, b):
173176
break
174177
beta = rsnew / rsold
175178

179+
# p = r + beta * p
176180
he3_axpby, e3_axpby = sycl_gemm.axpby_inplace(
177181
exec_queue, 1, r, beta, p, depends=[e1_axpby, e2_axpby]
178-
) # p = r + beta * p
182+
)
179183

180184
rsold = rsnew
181185
all_host_tasks.append(he3_axpby)

0 commit comments

Comments
 (0)