Use sycl::isinf for vec, but std::inf for scalars

oleksandr-pavlyk · oleksandr-pavlyk · commit d2c9aa4e7cb9 · 2023-05-15T05:25:26.000-05:00
diff --git a/dpctl/tensor/libtensor/include/kernels/elementwise_functions/isinf.hpp b/dpctl/tensor/libtensor/include/kernels/elementwise_functions/isinf.hpp
@@ -32,7 +32,9 @@ template <typename argT, typename resT> struct IsInfFunctor
     using is_constant = typename std::disjunction<std::is_same<argT, bool>,
                                                   std::is_integral<argT>>;
     static constexpr resT constant_value = false;
-    using supports_vec = typename std::false_type;
+    using supports_vec =
+        typename std::disjunction<std::is_same<argT, sycl::half>,
+                                  std::is_floating_point<argT>>;
     using supports_sg_loadstore = typename std::negation<
         std::disjunction<is_complex<resT>, is_complex<argT>>>;
 
@@ -56,8 +58,6 @@ template <typename argT, typename resT> struct IsInfFunctor
         }
     }
 
-    // unused (since support_vec is set to false_type) due to bug in sycl::isinf
-    // implementation in OpenCL CPU RT
     template <int vec_sz>
     sycl::vec<resT, vec_sz> operator()(const sycl::vec<argT, vec_sz> &in)
     {

Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,9 @@ template <typename argT, typename resT> struct IsInfFunctor`
`32`	`32`	`using is_constant = typename std::disjunction<std::is_same<argT, bool>,`
`33`	`33`	`std::is_integral<argT>>;`
`34`	`34`	`static constexpr resT constant_value = false;`
`35`		`- using supports_vec = typename std::false_type;`
	`35`	`+ using supports_vec =`
	`36`	`+ typename std::disjunction<std::is_same<argT, sycl::half>,`
	`37`	`+ std::is_floating_point<argT>>;`
`36`	`38`	`using supports_sg_loadstore = typename std::negation<`
`37`	`39`	`std::disjunction<is_complex<resT>, is_complex<argT>>>;`
`38`	`40`
`@@ -56,8 +58,6 @@ template <typename argT, typename resT> struct IsInfFunctor`
`56`	`58`	`}`
`57`	`59`	`}`
`58`	`60`
`59`		`- // unused (since support_vec is set to false_type) due to bug in sycl::isinf`
`60`		`- // implementation in OpenCL CPU RT`
`61`	`61`	`template <int vec_sz>`
`62`	`62`	`sycl::vec<resT, vec_sz> operator()(const sycl::vec<argT, vec_sz> &in)`
`63`	`63`	`{`