dptcl.tensor.eye dtype test and order validation

Author: ndgrigorian

dpctl/tensor/_ctors.py

@@ -1087,11 +1087,15 @@ def eye(
     if n_cols is None:
         n_cols = n_rows
     # allocate a 1D array of zeros, length equal to n_cols * n_rows
-    k_dt = type(k)
-    if not np.issubdtype(k_dt, np.integer):
-        raise TypeError(
-            "k keyword must be an integer, got {type}".format(type=k_dt)
+    if not isinstance(order, str) or len(order) == 0 or order[0] not in "CcFf":
+        raise ValueError(
+            "Unrecognized order keyword value, expecting 'F' or 'C'."
         )
+    else:
+        order = order[0].upper()
+    n_rows = operator.index(n_rows)
+    n_cols = operator.index(n_cols)
+    k = operator.index(k)
     x = zeros(
         (n_rows * n_cols,),
         dtype=dtype,

dpctl/tests/test_usm_ndarray_ctor.py

@@ -1288,24 +1288,25 @@ def test_common_arg_validation():
         dpt.ones_like(X)
     with pytest.raises(TypeError):
         dpt.full_like(X, 1)
-    with pytest.raises(TypeError):
-        dpt.eye(4, k=1.2)
 
 
-@pytest.mark.parametrize("shapes", [(0,), (1,), (7,), (6, 1), (3, 9), (10, 5)])
-@pytest.mark.parametrize("k", np.arange(-4, 5, 1))
-@pytest.mark.parametrize("orders", ["C", "F"])
-def test_eye(shapes, k, orders):
+@pytest.mark.parametrize("dtype", _all_dtypes)
+def test_eye(dtype):
+    X = dpt.eye(4, 5, dtype=dtype)
+    Xnp = np.eye(4, 5, dtype=dtype)
+    assert X.dtype == Xnp.dtype
+    assert np.array_equal(Xnp, dpt.asnumpy(X))
+
+
+@pytest.mark.parametrize("shape", [(7,), (6, 1), (10, 5), (3, 9)])
+@pytest.mark.parametrize("k", np.arange(-2, 2, 1))
+@pytest.mark.parametrize("order", ["C", "F"])
+def test_eye_shapes(shape, k, order):
     try:
         q = dpctl.SyclQueue()
     except dpctl.SyclQueueCreationError:
         pytest.skip("Queue could not be created")
-
-    shape = shapes
-    k = k
-    order = orders
-
     Xnp = np.eye(*shape, k=k, order=order)
     X = dpt.eye(*shape, k=k, order=order, sycl_queue=q)
 
-    np.testing.assert_array_equal(Xnp, dpt.asnumpy(X))
+    assert np.array_equal(Xnp, dpt.asnumpy(X))