Skip to content

task: add more env var documentation #2137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 3, 2025
Merged

task: add more env var documentation #2137

merged 1 commit into from
Sep 3, 2025

Conversation

@jharlow-intel
Copy link
Contributor

@jharlow-intel jharlow-intel commented Aug 19, 2025 •
edited
Loading

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

This PR adds some needed environment variable documentation to the git pages.

@jharlow-intel jharlow-intel self-assigned this Aug 19, 2025
ndgrigorian
ndgrigorian reviewed Aug 19, 2025
View reviewed changes
ndgrigorian
ndgrigorian reviewed Aug 19, 2025
View reviewed changes
ndgrigorian
ndgrigorian reviewed Aug 19, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Aug 19, 2025 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_105 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Aug 19, 2025 •
edited
Loading

Coverage Status

coverage: 85.897% (-0.01%) from 85.908%
when pulling 2368947 on task/SAT-7838
into 55b961d on master.

@jharlow-intel jharlow-intel force-pushed the task/SAT-7838 branch 2 times, most recently from e346c8f to 6ad1f1b Compare August 20, 2025 15:21
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_105 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_107 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_105 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

1 similar comment
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_105 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_105 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_105 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@jharlow-intel
Copy link
Contributor Author

@ndgrigorian ready for another review

@ndgrigorian
Copy link
Collaborator

Noting:
Closes #2037

ndgrigorian
ndgrigorian reviewed Aug 26, 2025
View reviewed changes
@github-actions
Copy link

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_111 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

antonwolfy
antonwolfy reviewed Sep 1, 2025
View reviewed changes
@jharlow-intel jharlow-intel force-pushed the task/SAT-7838 branch 2 times, most recently from e3245f4 to 5621f69 Compare September 2, 2025 14:17
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_113 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

1 similar comment
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_113 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_113 ran successfully.
Passed: 1115
Failed: 6
Skipped: 119

@github-actions
Copy link

github-actions bot commented Sep 2, 2025

Array API standard conformance tests for dpctl=0.21.0dev0=py310h93fe807_113 ran successfully.
Passed: 1114
Failed: 7
Skipped: 119

ndgrigorian
ndgrigorian approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this LGTM, thank you @jharlow-intel

antonwolfy
antonwolfy approved these changes Sep 3, 2025
View reviewed changes
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jharlow-intel, LGTM

@jharlow-intel
Copy link
Contributor Author

Thanks for the review team!~

@jharlow-intel jharlow-intel merged commit 0574c6c into master Sep 3, 2025
56 of 68 checks passed
@jharlow-intel jharlow-intel deleted the task/SAT-7838 branch September 3, 2025 14:12
@ndgrigorian ndgrigorian mentioned this pull request Sep 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@antonwolfy antonwolfy antonwolfy approved these changes

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

@vtavana vtavana Awaiting requested review from vtavana

Assignees

@jharlow-intel jharlow-intel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jharlow-intel @coveralls @ndgrigorian @antonwolfy