Applied review comments

Author: npolina4

dpnp/dpnp_iface.py

@@ -760,14 +760,14 @@ def get_usm_ndarray_or_scalar(a):
 
 def is_cuda_backend(obj=None):
     """
-    Checks that object has a cuda backend.
+    Checks that object has a CUDA backend.
 
     Parameters
     ----------
     obj : {Device, SyclDevice, SyclQueue, dpnp.ndarray, usm_ndarray, None},
           optional
         An input object with sycl_device property to check device backend.
-        If obj is  ``None``, device backend will be checked for the default
+        If `obj` is ``None``, device backend will be checked for the default
         queue.
         Default: ``None``.
 
@@ -784,7 +784,10 @@ def is_cuda_backend(obj=None):
         sycl_device = obj
     else:
         sycl_device = getattr(obj, "sycl_device", None)
-    if sycl_device is not None and "cuda" in sycl_device.backend.name:
+    if (
+        sycl_device is not None
+        and sycl_device.backend == dpctl.backend_type.cuda
+    ):
         return True
     return False
 

tests/conftest.py

@@ -65,14 +65,12 @@ def pytest_collection_modifyitems(config, items):
     )
 
     # global skip file for cuda backend
-    test_exclude_file_cuda = os.path.join(
-        test_path, "skipped_tests_cuda.tbl"
-    )
+    test_exclude_file_cuda = os.path.join(test_path, "skipped_tests_cuda.tbl")
 
     dev = dpctl.select_default_device()
     is_cpu = dev.is_cpu
     is_gpu_no_fp64 = not dev.has_aspect_fp64
-    is_cuda = "cuda" in str(dev.backend.name)
+    is_cuda = dpnp.is_cuda_backend(dev)
 
     print("")
     print(f"DPNP current device is CPU: {is_cpu}")
@@ -89,9 +87,7 @@ def pytest_collection_modifyitems(config, items):
                 get_excluded_tests(test_exclude_file_gpu_no_fp64)
             )
         if is_cuda:
-            excluded_tests.extend(
-                get_excluded_tests(test_exclude_file_cuda)
-            )
+            excluded_tests.extend(get_excluded_tests(test_exclude_file_cuda))
     else:
         excluded_tests.extend(get_excluded_tests(test_exclude_file))
 

tests/skipped_tests_cuda.tbl

@@ -379,7 +379,7 @@ tests/test_random_state.py::TestNormal::test_distr[host-float32]
 tests/test_random_state.py::TestNormal::test_distr[host-float64]
 tests/test_random_state.py::TestNormal::test_distr[host-None]
 tests/test_random_state.py::TestNormal::test_distr[device-float32]
-tests/test_random_state.py::TestNormal::test_distr[device-float64] 
+tests/test_random_state.py::TestNormal::test_distr[device-float64]
 tests/test_random_state.py::TestNormal::test_distr[device-None]
 tests/test_random_state.py::TestNormal::test_distr[shared-float32]
 tests/test_random_state.py::TestNormal::test_distr[shared-float64]
@@ -391,7 +391,7 @@ tests/test_random_state.py::TestNormal::test_scale[device-float32]
 tests/test_random_state.py::TestNormal::test_scale[device-float64]
 tests/test_random_state.py::TestNormal::test_scale[device-None]
 tests/test_random_state.py::TestNormal::test_scale[shared-float32]
-tests/test_random_state.py::TestNormal::test_scale[shared-float64] 
+tests/test_random_state.py::TestNormal::test_scale[shared-float64]
 tests/test_random_state.py::TestNormal::test_scale[shared-None]
 tests/test_random_state.py::TestNormal::test_inf_loc[numpy.inf]
 tests/test_random_state.py::TestNormal::test_inf_loc[-numpy.inf]