Skip to content

Commit 15480a8

Browse files
committed
Unmuted tests where fixes are expected to be available
1 parent 3d52c97 commit 15480a8

File tree

3 files changed

+1
-23
lines changed

3 files changed

+1
-23
lines changed

tests/test_linalg.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1485,10 +1485,6 @@ def test_norm_error(self):
14851485

14861486

14871487
class TestQr:
1488-
# TODO: New packages that fix issue CMPLRLLVM-53771 are only available in internal CI.
1489-
# Skip the tests on cpu until these packages are available for the external CI.
1490-
# Specifically dpcpp_linux-64>=2024.1.0
1491-
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
14921488
@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
14931489
@pytest.mark.parametrize(
14941490
"shape",
@@ -1574,7 +1570,6 @@ def test_qr_empty(self, dtype, shape, mode):
15741570

15751571
assert_dtype_allclose(dpnp_r, np_r)
15761572

1577-
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
15781573
@pytest.mark.parametrize(
15791574
"mode",
15801575
["r", "raw", "complete", "reduced"],

tests/test_sycl_queue.py

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1786,10 +1786,7 @@ def test_array_creation_from_dpctl(copy, device):
17861786
valid_devices,
17871787
ids=[device.filter_string for device in valid_devices],
17881788
)
1789-
# TODO need to delete no_bool=True when use dlpack > 0.7 version
1790-
@pytest.mark.parametrize(
1791-
"arr_dtype", get_all_dtypes(no_float16=True, no_bool=True)
1792-
)
1789+
@pytest.mark.parametrize("arr_dtype", get_all_dtypes(no_float16=True))
17931790
@pytest.mark.parametrize("shape", [tuple(), (2,), (3, 0, 1), (2, 2, 2)])
17941791
def test_from_dlpack(arr_dtype, shape, device):
17951792
X = dpnp.empty(shape=shape, dtype=arr_dtype, device=device)

tests/third_party/cupy/linalg_tests/test_decomposition.py

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -156,14 +156,6 @@ def test_decomposition(self, dtype):
156156
)
157157
@testing.fix_random()
158158
class TestSVD(unittest.TestCase):
159-
# TODO: New packages that fix issue CMPLRLLVM-53771 are only available in internal CI.
160-
# Skip the tests on cpu until these packages are available for the external CI.
161-
# Specifically dpcpp_linux-64>=2024.1.0
162-
@classmethod
163-
def setUpClass(cls):
164-
if is_cpu_device():
165-
raise unittest.SkipTest("CMPLRLLVM-53771")
166-
167159
def setUp(self):
168160
self.seed = testing.generate_seed()
169161

@@ -410,26 +402,20 @@ def _check_result(self, result_cpu, result_gpu):
410402
assert result_cpu.dtype == result_gpu.dtype
411403
testing.assert_allclose(result_cpu, result_gpu, atol=1e-4)
412404

413-
# TODO: New packages that fix issue CMPLRLLVM-53771 are only available in internal CI.
414-
# Skip the tests on cpu until these packages are available for the external CI.
415-
# Specifically dpcpp_linux-64>=2024.1.0
416-
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
417405
@testing.fix_random()
418406
@_condition.repeat(3, 10)
419407
def test_mode(self):
420408
self.check_mode(numpy.random.randn(2, 4), mode=self.mode)
421409
self.check_mode(numpy.random.randn(3, 3), mode=self.mode)
422410
self.check_mode(numpy.random.randn(5, 4), mode=self.mode)
423411

424-
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
425412
@testing.with_requires("numpy>=1.22")
426413
@testing.fix_random()
427414
def test_mode_rank3(self):
428415
self.check_mode(numpy.random.randn(3, 2, 4), mode=self.mode)
429416
self.check_mode(numpy.random.randn(4, 3, 3), mode=self.mode)
430417
self.check_mode(numpy.random.randn(2, 5, 4), mode=self.mode)
431418

432-
@pytest.mark.skipif(is_cpu_device(), reason="CMPLRLLVM-53771")
433419
@testing.with_requires("numpy>=1.22")
434420
@testing.fix_random()
435421
def test_mode_rank4(self):

0 commit comments

Comments
 (0)