Remove constant.hpp and other review comments

Author: AlexanderKalistratov

dpnp/backend/CMakeLists.txt

@@ -31,7 +31,6 @@ set(DPNP_SRC
     kernels/dpnp_krnl_mathematical.cpp
     kernels/dpnp_krnl_random.cpp
     kernels/dpnp_krnl_sorting.cpp
-    src/constants.cpp
     src/dpnp_iface_fptr.cpp
     src/memory_sycl.cpp
     src/queue_sycl.cpp

dpnp/backend/kernels/dpnp_krnl_common.cpp

@@ -35,14 +35,6 @@
 #include "queue_sycl.hpp"
 #include <dpnp_iface.hpp>
 
-/**
- * Version of SYCL DPC++ 2025.1 compiler where support of
- * sycl::ext::oneapi::experimental::properties was added.
- */
-#ifndef __SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORT
-#define __SYCL_COMPILER_REDUCTION_PROPERTIES_SUPPORT 20241208L
-#endif
-
 template <typename _DataType>
 class dpnp_initval_c_kernel;
 

dpnp/backend/src/constants.cpp

@@ -156,12 +156,6 @@ static auto dpnp_vec_cast(const sycl::vec<srcT, N> &s)
         s, Indices{});
 }
 
-/**
- * Removes parentheses for a passed list of types separated by comma.
- * It's intended to be used in operations macro.
- */
-#define MACRO_UNPACK_TYPES(...) __VA_ARGS__
-
 /**
  * Implements std::is_same<> with variadic number of types to compare with
  * and when type T has to match only one of types Ts.

dpnp/backend/src/constants.hpp

@@ -115,37 +115,6 @@ void get_shape_offsets_inkernel(const _DataType *shape,
     return;
 }
 
-/**
- * @ingroup BACKEND_UTILS
- * @brief Calculation of indices in array
- *
- * Calculates indices of element in array with given linear position
- * for example:
- *   idx = 5, shape = (2, 3), ndim = 2,
- *   indices xyz should be [1, 1]
- *
- * @param [in]  idx     linear index of the element in multy-D array.
- * @param [in]  ndim    number of dimensions.
- * @param [in]  shape   offsets of array.
- * @param [out] xyz     indices.
- */
-template <typename _DataType>
-void get_xyz_by_id(size_t idx,
-                   size_t ndim,
-                   const _DataType *offsets,
-                   _DataType *xyz)
-{
-    size_t quotient;
-    size_t remainder = idx;
-
-    for (size_t i = 0; i < ndim; ++i) {
-        quotient = remainder / offsets[i];
-        remainder = remainder - quotient * offsets[i];
-        xyz[i] = quotient;
-    }
-    return;
-}
-
 /**
  * @ingroup BACKEND_UTILS
  * @brief Calculate xyz id for given axis from linear index

dpnp/backend/src/dpnp_fptr.hpp

@@ -95,10 +95,6 @@ cdef extern from "dpnp_iface_fptr.hpp":
 
     DPNPFuncData get_dpnp_function_ptr(DPNPFuncName name, DPNPFuncType first_type, DPNPFuncType second_type) except +
 
-
-cdef extern from "constants.hpp":
-    void dpnp_python_constants_initialize_c(void * py_none, void * py_nan)
-
 cdef extern from "dpnp_iface.hpp":
 
     char * dpnp_memory_alloc_c(size_t size_in_bytes) except +