Skip to content

Commit 313e0b7

Browse files
authored
Build conda enviroment for coverage action without intel channel (#1917)
* Create conda env without intel channel * List conda channels explicitly * Bump python version to 3.11 * Don't use intel channel * Stock numpy returns different dtypes from fft() and ifft() * Relax type check for rfft()
1 parent 001b63f commit 313e0b7

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

.github/workflows/generate_coverage.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ jobs:
2020
shell: bash -l {0}
2121

2222
env:
23-
python-ver: '3.10'
23+
python-ver: '3.11'
2424
CHANNELS: '-c dppy/label/dev -c intel -c conda-forge --override-channels'
25+
NO_INTEL_CHANNELS: '-c dppy/label/dev -c conda-forge --override-channels'
2526
# Install the latest oneAPI compiler to work around an issue
2627
INSTALL_ONE_API: 'yes'
2728

@@ -50,6 +51,7 @@ jobs:
5051
run: |
5152
sudo apt-get install intel-oneapi-compiler-dpcpp-cpp
5253
sudo apt-get install intel-oneapi-mkl-devel
54+
sudo apt-get install intel-oneapi-libdpstd-devel
5355
sudo apt-get install intel-oneapi-tbb-devel
5456
5557
- name: Install Lcov
@@ -81,7 +83,7 @@ jobs:
8183
if: env.INSTALL_ONE_API == 'yes'
8284
run: |
8385
mamba install cython llvm cmake">=3.21" scikit-build ninja pytest pytest-cov coverage[toml] \
84-
dpctl">=0.18.0dev0" onedpl-devel ${{ env.CHANNELS }}
86+
dpctl">=0.18.0dev0" ${{ env.NO_INTEL_CHANNELS }}
8587
8688
- name: Install dpnp dependencies
8789
if: env.INSTALL_ONE_API != 'yes'

tests/third_party/cupy/fft_tests/test_fft.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ class TestFft(unittest.TestCase):
2626
rtol=1e-4,
2727
atol=1e-7,
2828
accept_error=ValueError,
29-
type_check=has_support_aspect64(),
29+
type_check=False,
3030
contiguous_check=False,
3131
)
3232
def test_fft(self, xp, dtype):
@@ -40,7 +40,7 @@ def test_fft(self, xp, dtype):
4040
rtol=1e-4,
4141
atol=1e-7,
4242
accept_error=ValueError,
43-
type_check=has_support_aspect64(),
43+
type_check=False,
4444
contiguous_check=False,
4545
)
4646
def test_ifft(self, xp, dtype):
@@ -178,7 +178,7 @@ class TestRfft(unittest.TestCase):
178178
@testing.numpy_cupy_allclose(
179179
rtol=1e-4,
180180
atol=1e-7,
181-
type_check=has_support_aspect64(),
181+
type_check=False,
182182
)
183183
def test_rfft(self, xp, dtype):
184184
a = testing.shaped_random(self.shape, xp, dtype)

0 commit comments

Comments
 (0)