add a comment

Vahid Tavanashad · Vahid Tavanashad · commit 34299054a98e · 2025-03-28T12:32:47.000-07:00
diff --git a/dpnp/dpnp_algo/dpnp_elementwise_common.py b/dpnp/dpnp_algo/dpnp_elementwise_common.py
@@ -537,6 +537,7 @@ def __call__(self, x, out=None, order="K"):
         elif out is not None and not dpnp.is_supported_array_type(out):
             pass  # pass to raise error in main implementation
         elif out is not None and out.dtype != x.dtype:
+            # passing will raise an error but with incorrect needed dtype
             raise ValueError(
                 f"Output array of type {x.dtype} is needed, got {out.dtype}"
             )
diff --git a/dpnp/tests/test_mathematical.py b/dpnp/tests/test_mathematical.py
@@ -2270,6 +2270,7 @@ def test_out_float16(self, func):
         assert result is iout
         assert_array_equal(result, expected)
 
+    @testing.with_requires("numpy>=2.1.0")
     @pytest.mark.parametrize(
         "dt", get_all_dtypes(no_none=True, no_complex=True)
     )

Original file line number	Diff line number	Diff line change
`@@ -537,6 +537,7 @@ def __call__(self, x, out=None, order="K"):`
`537`	`537`	`elif out is not None and not dpnp.is_supported_array_type(out):`
`538`	`538`	`pass # pass to raise error in main implementation`
`539`	`539`	`elif out is not None and out.dtype != x.dtype:`
	`540`	`+ # passing will raise an error but with incorrect needed dtype`
`540`	`541`	`raise ValueError(`
`541`	`542`	`f"Output array of type {x.dtype} is needed, got {out.dtype}"`
`542`	`543`	`)`
Original file line number	Diff line number	Diff line change
`@@ -2270,6 +2270,7 @@ def test_out_float16(self, func):`
`2270`	`2270`	`assert result is iout`
`2271`	`2271`	`assert_array_equal(result, expected)`
`2272`	`2272`
	`2273`	`+ @testing.with_requires("numpy>=2.1.0")`
`2273`	`2274`	`@pytest.mark.parametrize(`
`2274`	`2275`	`"dt", get_all_dtypes(no_none=True, no_complex=True)`
`2275`	`2276`	`)`