Fix review comments

Author: AlexanderKalistratov

dpnp/backend/extensions/statistics/common.hpp

@@ -101,7 +101,7 @@ struct IsNan
 {
     static bool isnan(const T &v)
     {
-        if constexpr (std::is_floating_point<T>::value) {
+        if constexpr (std::is_floating_point_v<T>) {
             return sycl::isnan(v);
         }
 

dpnp/backend/extensions/statistics/histogram_common.cpp

@@ -30,7 +30,10 @@
 #include <vector>
 
 #include "dpctl4pybind11.hpp"
+#include "utils/memory_overlap.hpp"
+#include "utils/output_validation.hpp"
 #include "utils/type_dispatch.hpp"
+
 #include <pybind11/pybind11.h>
 
 #include "histogram_common.hpp"
@@ -73,6 +76,8 @@ void validate(const usm_ndarray &sample,
         return "'" + name_it->second + "'";
     };
 
+    dpctl::tensor::validation::CheckWritable::throw_if_not_writable(histogram);
+
     auto unequal_queue =
         std::find_if(arrays.cbegin(), arrays.cend(), [&](const array_ptr &arr) {
             return arr->get_queue() != exec_q;
@@ -95,6 +100,21 @@ void validate(const usm_ndarray &sample,
                               " parameter is not c-contiguos");
     }
 
+    auto check_overlaping = [&](const array_ptr &first,
+                                const array_ptr &second) {
+        const auto &overlap = dpctl::tensor::overlap::MemoryOverlap();
+
+        if (overlap(sample, histogram)) {
+            throw py::value_error(get_name(first) +
+                                  " has overlapping memory segments with " +
+                                  get_name(second));
+        }
+    };
+
+    check_overlaping(&sample, &histogram);
+    check_overlaping(&bins, &histogram);
+    check_overlaping(weights_ptr, &histogram);
+
     if (bins.get_size() < 2) {
         throw py::value_error(get_name(&bins) +
                               " parameter must have at least 2 elements");

dpnp/dpnp_iface_histograms.py

@@ -486,25 +486,25 @@ def histogram(a, bins=10, range=None, density=None, weights=None):
     )
     n_usm = dpnp.get_usm_ndarray(n_casted)
 
-    ht_ev, mem_ev = statistics_ext.histogram(
+    mem_ev, ht_ev = statistics_ext.histogram(
         a_usm,
         bins_usm,
         weights_usm,
         n_usm,
         depends=_manager.submitted_events,
     )
-    _manager.add_event_pair(ht_ev, mem_ev)
+    _manager.add_event_pair(mem_ev, ht_ev)
 
     if usm_type != n_usm_type:
         n = dpnp.asarray(n_casted, dtype=ntype, usm_type=usm_type)
     else:
         n = dpnp.astype(n_casted, ntype, copy=False)
 
     if density:
-        db = dpnp.diff(bin_edges).astype(
-            dpnp.default_float_type(sycl_queue=queue)
+        db = dpnp.astype(
+            dpnp.diff(bin_edges), dpnp.default_float_type(sycl_queue=queue)
         )
-        return n / db / n.sum(), bin_edges
+        return n / db / dpnp.sum(n), bin_edges
 
     return n, bin_edges