Skip to content

Commit 725891c

Browse files
Apply remarks
1 parent 15685e8 commit 725891c

File tree

1 file changed

+3
-6
lines changed
  • dpnp/backend/extensions/ufunc/elementwise_functions

1 file changed

+3
-6
lines changed

dpnp/backend/extensions/ufunc/elementwise_functions/isclose.cpp

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,6 @@
4545
#include "../../elementwise_functions/simplify_iteration_space.hpp"
4646

4747
// dpctl tensor headers
48-
#include "utils/memory_overlap.hpp"
4948
#include "utils/offset_utils.hpp"
5049
#include "utils/output_validation.hpp"
5150
#include "utils/sycl_alloc_utils.hpp"
@@ -58,7 +57,7 @@
5857
namespace py = pybind11;
5958
namespace td_ns = dpctl::tensor::type_dispatch;
6059

61-
using ext::common::value_type_of;
60+
using ext::common::value_type_of_t;
6261
using ext::validation::array_names;
6362

6463
using ext::common::dtype_from_typenum;
@@ -68,16 +67,14 @@ using ext::validation::check_num_dims;
6867
using ext::validation::check_queue;
6968
using ext::validation::check_same_dtype;
7069
using ext::validation::check_same_size;
70+
using ext::validation::check_writable;
7171

7272
namespace dpnp::extensions::ufunc
7373
{
7474

7575
namespace impl
7676
{
7777

78-
template <typename T>
79-
using value_type_of_t = typename value_type_of<T>::type;
80-
8178
typedef sycl::event (*isclose_strided_scalar_fn_ptr_t)(
8279
sycl::queue &,
8380
const int, // nd
@@ -181,7 +178,7 @@ std::pair<sycl::event, sycl::event>
181178

182179
check_queue({&a, &b, &res}, names, exec_q);
183180
check_no_overlap({&a, &b}, {&res}, names);
184-
dpctl::tensor::validation::CheckWritable::throw_if_not_writable(res);
181+
check_writable({&res}, names);
185182

186183
auto types = td_ns::usm_ndarray_types();
187184
// a_typeid == b_typeid (check_same_dtype(&a, &b, names))

0 commit comments

Comments
 (0)