address comments

Author: Vahid Tavanashad

dpnp/dpnp_iface_arraycreation.py

@@ -377,6 +377,11 @@ def array(
     >>> x
     array([1, 2, 3])
 
+    Upcasting:
+
+    >>> np.array([1, 2, 3.0])
+    array([ 1.,  2.,  3.])
+
     More than one dimension:
 
     >>> x2 = np.array([[1, 2], [3, 4]])
@@ -386,6 +391,16 @@ def array(
     array([[1, 2],
            [3, 4]])
 
+    Minimum dimensions 2:
+
+    >>> np.array([1, 2, 3], ndmin=2)
+    array([[1, 2, 3]])
+
+    Type provided:
+
+    >>> np.array([1, 2, 3], dtype=complex)
+    array([ 1.+0.j,  2.+0.j,  3.+0.j])
+
     Creating an array on a different device or with a specified usm_type
 
     >>> x = np.array([1, 2, 3]) # default case

tests/third_party/cupy/creation_tests/test_from_data.py

@@ -514,14 +514,14 @@ def test_copy(self, xp, dtype, order):
         a[1] = 1
         return b
 
-    @pytest.mark.skip("`device` argument isn't supported")
     @testing.for_CF_orders()
     @testing.for_all_dtypes()
     def test_copy_multigpu(self, dtype, order):
-        with cuda.Device(0):
-            src = cupy.random.uniform(-1, 1, (2, 3)).astype(dtype)
-        with cuda.Device(1):
-            dst = cupy.copy(src, order)
+        q1 = dpctl.SyclQueue()
+        q2 = dpctl.SyclQueue()
+
+        src = cupy.random.uniform(-1, 1, (2, 3), device=q1).astype(dtype)
+        dst = cupy.copy(src, order, device=q2)
         testing.assert_allclose(src, dst, rtol=0, atol=0)
 
     @testing.for_CF_orders()
@@ -804,10 +804,13 @@ def test_cupy_array(self, dtype):
         assert a.shape == shape
 
 
-# TODO: ndmin=3 is removed since it needs ndarray.base
 @testing.parameterize(
     *testing.product(
-        {"ndmin": [0, 1, 2], "copy": [True, False, None], "xp": [numpy, cupy]}
+        {
+            "ndmin": [0, 1, 2, 3],
+            "copy": [True, False, None],
+            "xp": [numpy, cupy],
+        }
     )
 )
 class TestArrayCopy(unittest.TestCase):
@@ -823,8 +826,8 @@ def test_cupy_array(self, dtype):
         # TODO(Kenta Oono): Better determination of copy.
         is_copied = not (
             (actual is a)
-            #    or (actual.base is a)
-            #    or (actual.base is a.base and a.base is not None)
+            or (self.xp is cupy)
+            and (a.get_array()._pointer == actual.get_array()._pointer)
         )
         assert should_copy == is_copied