Extend DPNPUnaryTwoOutputsFunc class with support of oneMKL VM callbacks

Author: antonwolfy

dpnp/dpnp_algo/dpnp_elementwise_common.py

@@ -92,12 +92,12 @@ class DPNPUnaryFunc(UnaryElementwiseFunc):
         corresponds to computational tasks associated with function evaluation.
     docs : {str}
         Documentation string for the unary function.
-    mkl_fn_to_call : {callable}
+    mkl_fn_to_call : {None, str}
         Check input arguments to answer if function from OneMKL VM library
         can be used.
-    mkl_impl_fn : {callable}
+    mkl_impl_fn : {None, str}
         Function from OneMKL VM library to call.
-    acceptance_fn : {callable}, optional
+    acceptance_fn : {None, callable}, optional
         Function to influence type promotion behavior of this unary
         function. The function takes 4 arguments:
             arg_dtype - Data type of the first argument
@@ -130,7 +130,9 @@ def _call_func(src, dst, sycl_queue, depends=None):
             if depends is None:
                 depends = []
 
-            if vmi._is_available() and mkl_fn_to_call is not None:
+            if vmi._is_available() and not (
+                mkl_impl_fn is None or mkl_fn_to_call is None
+            ):
                 if getattr(vmi, mkl_fn_to_call)(sycl_queue, src, dst):
                     # call pybind11 extension for unary function from OneMKL VM
                     return getattr(vmi, mkl_impl_fn)(
@@ -231,6 +233,11 @@ class DPNPUnaryTwoOutputsFunc(UnaryElementwiseFunc):
         corresponds to computational tasks associated with function evaluation.
     docs : {str}
         Documentation string for the unary function.
+    mkl_fn_to_call : {None, str}
+        Check input arguments to answer if function from OneMKL VM library
+        can be used.
+    mkl_impl_fn : {None, str}
+        Function from OneMKL VM library to call.
 
     """
 
@@ -240,11 +247,29 @@ def __init__(
         result_type_resolver_fn,
         unary_dp_impl_fn,
         docs,
+        mkl_fn_to_call=None,
+        mkl_impl_fn=None,
     ):
+        def _call_func(src, dst1, dst2, sycl_queue, depends=None):
+            """A callback to register in UnaryElementwiseFunc class."""
+
+            if depends is None:
+                depends = []
+
+            if vmi._is_available() and not (
+                mkl_impl_fn is None or mkl_fn_to_call is None
+            ):
+                if getattr(vmi, mkl_fn_to_call)(sycl_queue, src, dst1, dst2):
+                    # call pybind11 extension for unary function from OneMKL VM
+                    return getattr(vmi, mkl_impl_fn)(
+                        sycl_queue, src, dst1, dst2, depends
+                    )
+            return unary_dp_impl_fn(src, dst1, dst2, sycl_queue, depends)
+
         super().__init__(
             name,
             result_type_resolver_fn,
-            unary_dp_impl_fn,
+            _call_func,
             docs,
         )
         self.__name__ = "DPNPUnaryTwoOutputsFunc"
@@ -458,12 +483,12 @@ class DPNPBinaryFunc(BinaryElementwiseFunc):
         evaluation.
     docs : {str}
         Documentation string for the unary function.
-    mkl_fn_to_call : {callable}
+    mkl_fn_to_call : {None, str}
         Check input arguments to answer if function from OneMKL VM library
         can be used.
-    mkl_impl_fn : {callable}
+    mkl_impl_fn : {None, str}
         Function from OneMKL VM library to call.
-    binary_inplace_fn : {callable}, optional
+    binary_inplace_fn : {None, callable}, optional
         Data-parallel implementation function with signature
         `impl_fn(src: usm_ndarray, dst: usm_ndarray,
             sycl_queue: SyclQueue, depends: Optional[List[SyclEvent]])`
@@ -475,7 +500,7 @@ class DPNPBinaryFunc(BinaryElementwiseFunc):
         including async lifetime management of Python arguments,
         while the second event corresponds to computational tasks
         associated with function evaluation.
-    acceptance_fn : {callable}, optional
+    acceptance_fn : {None, callable}, optional
         Function to influence type promotion behavior of this binary
         function. The function takes 6 arguments:
             arg1_dtype - Data type of the first argument
@@ -488,7 +513,7 @@ class DPNPBinaryFunc(BinaryElementwiseFunc):
         The function is only called when both arguments of the binary
         function require casting, e.g. both arguments of
         `dpctl.tensor.logaddexp` are arrays with integral data type.
-    weak_type_resolver : {callable}, optional
+    weak_type_resolver : {None, callable}, optional
         Function to influence type promotion behavior for Python scalar types
         of this binary function. The function takes 3 arguments:
             o1_dtype - Data type or Python scalar type of the first argument
@@ -520,7 +545,9 @@ def _call_func(src1, src2, dst, sycl_queue, depends=None):
             if depends is None:
                 depends = []
 
-            if vmi._is_available() and mkl_fn_to_call is not None:
+            if vmi._is_available() and not (
+                mkl_impl_fn is None or mkl_fn_to_call is None
+            ):
                 if getattr(vmi, mkl_fn_to_call)(sycl_queue, src1, src2, dst):
                     # call pybind11 extension for binary function from OneMKL VM
                     return getattr(vmi, mkl_impl_fn)(

dpnp/dpnp_iface_mathematical.py

@@ -3423,6 +3423,8 @@ def interp(x, xp, fp, left=None, right=None, period=None):
     ufi._modf_result_type,
     ufi._modf,
     _MODF_DOCSTRING,
+    mkl_fn_to_call="_mkl_modf_to_call",
+    mkl_impl_fn="_modf",
 )