Skip to content

Commit a046ab9

Browse files
Unskip singular matrix tests for linalg functions
1 parent f7f3467 commit a046ab9

File tree

3 files changed

+0
-18
lines changed

3 files changed

+0
-18
lines changed

dpnp/tests/test_linalg.py

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -460,10 +460,6 @@ def test_det_singular_matrix(self, matrix):
460460

461461
assert_allclose(result, expected)
462462

463-
# TODO: remove skipif when MKLD-13852 is resolved
464-
# _getrf_batch does not raise an error with singular matrices.
465-
# Skip running on cpu because dpnp uses _getrf_batch only on cpu.
466-
@pytest.mark.skipif(is_cpu_device(), reason="MKLD-13852")
467463
def test_det_singular_matrix_3D(self):
468464
a_np = numpy.array(
469465
[[[1, 2], [3, 4]], [[1, 2], [1, 2]], [[1, 3], [3, 1]]]
@@ -1761,9 +1757,6 @@ def test_inv_singular_matrix(self, matrix):
17611757
assert_raises(numpy.linalg.LinAlgError, numpy.linalg.inv, a_np)
17621758
assert_raises(dpnp.linalg.LinAlgError, dpnp.linalg.inv, a_dp)
17631759

1764-
# TODO: remove skip when MKLD-13852 is resolved
1765-
# _getrf_batch does not raise an error with singular matrices.
1766-
@pytest.mark.skip("MKLD-13852")
17671760
def test_inv_singular_matrix_3D(self):
17681761
a_np = numpy.array(
17691762
[[[1, 2], [3, 4]], [[1, 2], [1, 2]], [[1, 3], [3, 1]]]
@@ -2815,10 +2808,6 @@ def test_slogdet_singular_matrix(self, matrix):
28152808
assert_allclose(sign_result, sign_expected)
28162809
assert_allclose(logdet_result, logdet_expected)
28172810

2818-
# TODO: remove skipif when MKLD-13852 is resolved
2819-
# _getrf_batch does not raise an error with singular matrices.
2820-
# Skip running on cpu because dpnp uses _getrf_batch only on cpu.
2821-
@pytest.mark.skipif(is_cpu_device(), reason="MKLD-13852")
28222811
def test_slogdet_singular_matrix_3D(self):
28232812
a_np = numpy.array(
28242813
[[[1, 2], [3, 4]], [[1, 2], [1, 2]], [[1, 3], [3, 1]]]

dpnp/tests/third_party/cupy/linalg_tests/test_norms.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,6 @@ def test_det_zero_dim(self, dtype):
170170
with pytest.raises(xp.linalg.LinAlgError):
171171
xp.linalg.det(a)
172172

173-
# TODO: remove skipif when MKLD-13852 is resolved
174-
# _getrf_batch does not raise an error with singular matrices.
175-
# Skip running on cpu because dpnp uses _getrf_batch only on cpu.
176-
@pytest.mark.skipif(is_cpu_device(), reason="MKLD-13852")
177173
@testing.for_float_dtypes(no_float16=True)
178174
@testing.numpy_cupy_allclose(rtol=1e-3, atol=1e-4)
179175
def test_det_singular(self, xp, dtype):

dpnp/tests/third_party/cupy/linalg_tests/test_solve.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -213,9 +213,6 @@ def test_inv(self, dtype):
213213
):
214214
xp.linalg.inv(a)
215215

216-
# TODO: remove skip when MKLD-13852 is resolved
217-
# _getrf_batch does not raise an error with singular matrices.
218-
@pytest.mark.skip("MKLD-13852")
219216
@testing.for_dtypes("ifdFD")
220217
def test_batched_inv(self, dtype):
221218
for xp in (numpy, cupy):

0 commit comments

Comments
 (0)