Skip to content

Commit c30a2a4

Browse files
Temporary skip bached cholesky tests failing on win ARL and MTL (#2579)
The PR proposes to skip tests (**dpnp.linalg.cholesky() batch**) which are failing in internal CI due to known issue on Intel Arrow Lake or Meteor Lake GPU windows
1 parent 266faed commit c30a2a4

File tree

5 files changed

+34
-3
lines changed

5 files changed

+34
-3
lines changed

dpnp/tests/helper.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -404,6 +404,14 @@ def has_support_aspect64(device=None):
404404
return dev.has_aspect_fp64
405405

406406

407+
def is_arl_or_mtl(device=None):
408+
"""
409+
Return True if a test is running on Arrow Lake or Meteor Lake GPU device,
410+
False otherwise.
411+
"""
412+
return _get_dev_mask(device) == 0x7D00
413+
414+
407415
def is_cpu_device(device=None):
408416
"""
409417
Return True if a test is running on CPU device, False otherwise.

dpnp/tests/test_linalg.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,8 @@
2323
get_float_complex_dtypes,
2424
get_integer_float_dtypes,
2525
has_support_aspect64,
26-
is_cpu_device,
26+
is_arl_or_mtl,
27+
is_win_platform,
2728
numpy_version,
2829
)
2930
from .third_party.cupy import testing
@@ -109,6 +110,8 @@ def test_usm_ndarray_linalg_batch(func, gen_kwargs, func_kwargs):
109110
)
110111
for _ in range(2)
111112
]
113+
elif func == "cholesky" and is_win_platform() and is_arl_or_mtl():
114+
pytest.skip("SAT-8206")
112115
else:
113116
dpt_args = [
114117
dpt.asarray(generate_random_numpy_array(shape, **gen_kwargs))
@@ -158,6 +161,8 @@ class TestCholesky:
158161
def test_cholesky(self, array, dtype):
159162
a = numpy.array(array, dtype=dtype)
160163
ia = dpnp.array(a)
164+
if ia.ndim > 2 and is_win_platform() and is_arl_or_mtl():
165+
pytest.skip("SAT-8206")
161166
result = dpnp.linalg.cholesky(ia)
162167
expected = numpy.linalg.cholesky(a)
163168
assert_dtype_allclose(result, expected)
@@ -177,6 +182,8 @@ def test_cholesky(self, array, dtype):
177182
@pytest.mark.parametrize("dtype", get_all_dtypes(no_bool=True))
178183
def test_cholesky_upper(self, array, dtype):
179184
ia = dpnp.array(array, dtype=dtype)
185+
if ia.ndim > 2 and is_win_platform() and is_arl_or_mtl():
186+
pytest.skip("SAT-8206")
180187
result = dpnp.linalg.cholesky(ia, upper=True)
181188

182189
if ia.ndim > 2:
@@ -219,6 +226,8 @@ def test_cholesky_upper(self, array, dtype):
219226
def test_cholesky_upper_numpy(self, array, dtype):
220227
a = numpy.array(array, dtype=dtype)
221228
ia = dpnp.array(a)
229+
if ia.ndim > 2 and is_win_platform() and is_arl_or_mtl():
230+
pytest.skip("SAT-8206")
222231
result = dpnp.linalg.cholesky(ia, upper=True)
223232
expected = numpy.linalg.cholesky(a, upper=True)
224233
assert_dtype_allclose(result, expected)

dpnp/tests/test_sycl_queue.py

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,12 @@
1212
from dpnp.dpnp_array import dpnp_array
1313
from dpnp.dpnp_utils import get_usm_allocations
1414

15-
from .helper import generate_random_numpy_array, get_all_dtypes, is_win_platform
15+
from .helper import (
16+
generate_random_numpy_array,
17+
get_all_dtypes,
18+
is_arl_or_mtl,
19+
is_win_platform,
20+
)
1621

1722
list_of_backend_str = ["cuda", "host", "level_zero", "opencl"]
1823

@@ -1488,6 +1493,8 @@ def test_cholesky(self, data, is_empty, device):
14881493
else:
14891494
dtype = dpnp.default_float_type(device)
14901495
x = dpnp.array(data, dtype=dtype, device=device)
1496+
if x.ndim > 2 and is_win_platform() and is_arl_or_mtl():
1497+
pytest.skip("SAT-8206")
14911498

14921499
result = dpnp.linalg.cholesky(x)
14931500
assert_sycl_queue_equal(result.sycl_queue, x.sycl_queue)

dpnp/tests/test_usm_type.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
import dpnp
1111
from dpnp.dpnp_utils import get_usm_allocations
1212

13-
from .helper import generate_random_numpy_array, is_win_platform
13+
from .helper import generate_random_numpy_array, is_arl_or_mtl, is_win_platform
1414

1515
list_of_usm_types = ["device", "shared", "host"]
1616

@@ -1341,6 +1341,8 @@ def test_cholesky(self, data, is_empty, usm_type):
13411341
x = dpnp.empty(data, dtype=dtype, usm_type=usm_type)
13421342
else:
13431343
x = dpnp.array(data, dtype=dtype, usm_type=usm_type)
1344+
if x.ndim > 2 and is_win_platform() and is_arl_or_mtl():
1345+
pytest.skip("SAT-8206")
13441346

13451347
result = dpnp.linalg.cholesky(x)
13461348
assert x.usm_type == result.usm_type

dpnp/tests/third_party/cupy/linalg_tests/test_decomposition.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,9 @@
66
import dpnp as cupy
77
from dpnp.tests.helper import (
88
has_support_aspect64,
9+
is_arl_or_mtl,
910
is_cpu_device,
11+
is_win_platform,
1012
)
1113
from dpnp.tests.third_party.cupy import testing
1214
from dpnp.tests.third_party.cupy.testing import _condition
@@ -82,6 +84,9 @@ def test_decomposition(self, dtype):
8284
# np.linalg.cholesky only uses a lower triangle of an array
8385
self.check_L(numpy.array([[1, 2], [1, 9]], dtype))
8486

87+
@pytest.mark.skipif(
88+
is_win_platform() and is_arl_or_mtl(), reason="SAT-8206"
89+
)
8590
@testing.for_dtypes(
8691
[
8792
numpy.int32,

0 commit comments

Comments
 (0)